From: tjhunt <tjhunt>
Date: Sun, 1 Oct 2006 20:32:12 +0000 (+0000)
Subject: Fix performance problem with lots of categories. http://moodle.org/mod/forum/discuss... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=cc0809130008a9ff928c3c45a13b29b954200db0;p=moodle.git

Fix performance problem with lots of categories. http://moodle.org/mod/forum/discuss.php?d=54945#252145. Merged from MOODLE_16_STABLE.
---

diff --git a/question/question.php b/question/question.php
index d42e17b20b..f2bdcb778f 100644
--- a/question/question.php
+++ b/question/question.php
@@ -258,13 +258,7 @@
     $gradeoptions = $creategrades->gradeoptions;
     $gradeoptionsfull = $creategrades->gradeoptionsfull;
 
-    if (!$categories = question_category_menu($course->id, false)) {
-        error("No categories!");
-    }
-
-
-    // Print the question editing form
-
+    // Initialise defaults if necessary.
     if (empty($question->id)) {
         $question->id = "";
     }
@@ -287,7 +281,7 @@
         $question->generalfeedback = "";
     }
 
-    // Set up some Richtext editing if necessary
+    // Set up some richtext editing if necessary
     if ($usehtmleditor = can_use_richtext_editor()) {
         $defaultformat = FORMAT_HTML;
     } else {
@@ -298,6 +292,7 @@
         $err = $question->errors;
     }
 
+    // Print the question editing form
     echo '<br />';
     print_simple_box_start('center');
     require_once('type/'.$qtype.'/editquestion.php');