From: moodler <moodler>
Date: Fri, 22 Dec 2006 04:19:52 +0000 (+0000)
Subject: Added CDATA to Javascript
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=ce926cb8d8a54cfeec2dd2a4b123ab4c14cf933e;p=moodle.git

Added CDATA to Javascript
---

diff --git a/blocks/admin_tree/block_admin_tree.php b/blocks/admin_tree/block_admin_tree.php
index 22ae106faf..af544670b7 100644
--- a/blocks/admin_tree/block_admin_tree.php
+++ b/blocks/admin_tree/block_admin_tree.php
@@ -129,7 +129,7 @@ class block_admin_tree extends block_base {
 
             $this->content = new stdClass;
             $this->content->text  = '<script type="text/javascript">'."\n";
-            $this->content->text .= '<!--' . "\n";
+            $this->content->text .= '//<![CDATA[' . "\n";
             $this->content->text .= 'var vh_numspans = ' . ($this->spancounter - 1) . ';' . "\n";
             $this->content->text .= 'var vh_content = new Array();' . "\n";
             $this->content->text .= 'function getspan(spanid) {' . "\n";
@@ -177,7 +177,7 @@ class block_admin_tree extends block_base {
             $this->content->text .= '  }' . "\n";
             $this->content->text .= '}' . "\n";
 
-            $this->content->text .= '-->' . "\n";
+            $this->content->text .= '//]]>' . "\n";
             $this->content->text .= '</script>' . "\n";
             $this->content->text .= '<div align="left">' . "\n";
 
@@ -185,11 +185,11 @@ class block_admin_tree extends block_base {
 
             $this->content->text .= '</div>' . "\n";
             $this->content->text .= '<script type="text/javascript">' . "\n";
-            $this->content->text .= '<!--' . "\n";
+            $this->content->text .= '//<![CDATA[' . "\n";
             $this->content->text .= 'collapseall();' . "\n";
             $this->content->text .= $this->expandjavascript;
 
-            $this->content->text .= '-->' . "\n";
+            $this->content->text .= '//]]>' . "\n";
             $this->content->text .= '</script>' . "\n";
 
             $searchcontent = isset($CFG->adminsearchquery) ? $CFG->adminsearchquery : '';
diff --git a/lib/weblib.php b/lib/weblib.php
index e9aea72d7a..58e772b997 100644
--- a/lib/weblib.php
+++ b/lib/weblib.php
@@ -1016,9 +1016,9 @@ function popup_form($common, $options, $formname, $selected='', $nothing='choose
     $output .= '<div id="noscript'.$formname.'" style="display: inline;">';
     $output .= '<input type="submit" value="'.$go.'" /></div>';
     $output .= '<script type="text/javascript">'.
-               "\n<!--\n".
+               "\n//<![CDATA[\n".
                'document.getElementById("noscript'.$formname.'").style.display = "none";'.
-               "\n-->\n".'</script>';
+               "\n//]]>\n".'</script>';
     $output .= '</form>' . "\n";
 
     if ($help) {