From: tjhunt <tjhunt>
Date: Tue, 16 Oct 2007 21:26:50 +0000 (+0000)
Subject: MDL-5262 - PHP notice when sorting on R% coloumn in the Item analysis report - I... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=d309fd09263da611b43aa9c7ee31450431834ab2;p=moodle.git

MDL-5262 - PHP notice when sorting on R% coloumn in the Item analysis report - I adopted the simple solution of stopping people sorting on that column, since it is the same as sorting on rcount, I think. Merged from MOODLE_19_STABLE.
---

diff --git a/mod/quiz/report/analysis/report.php b/mod/quiz/report/analysis/report.php
index 3106d9f5d1..cdfdaa8fc6 100644
--- a/mod/quiz/report/analysis/report.php
+++ b/mod/quiz/report/analysis/report.php
@@ -87,8 +87,8 @@ class quiz_report extends quiz_default_report {
         $sql = 'SELECT  qa.* FROM '.$CFG->prefix.'quiz_attempts qa, '.$CFG->prefix.'user u '.$groupmembers.
                  'WHERE u.id = qa.userid AND qa.quiz = '.$quiz->id.' AND qa.preview = 0 AND ( qa.sumgrades >= '.$scorelimit.' ) '.$groupwhere;
 
-        // ^^^^^^ es posible seleccionar aqu� TODOS los quizzes, como quiere Jussi,
-        // pero habr�a que llevar la cuenta ed cada quiz para restaura las preguntas (quizquestions, states)
+        // ^^^^^^ es posible seleccionar aqu TODOS los quizzes, como quiere Jussi,
+        // pero habra que llevar la cuenta ed cada quiz para restaura las preguntas (quizquestions, states)
 
         /// Fetch the attempts
         $attempts = get_records_sql($sql);
@@ -244,6 +244,7 @@ class quiz_report extends quiz_default_report {
         $table->define_baseurl($CFG->wwwroot.'/mod/quiz/report.php?q='.$quiz->id.'&amp;mode=analysis');
 
         $table->sortable(true);
+        $table->no_sorting('rpercent');
         $table->collapsible(true);
         $table->initialbars(false);