From: stronk7 <stronk7>
Date: Thu, 24 Sep 2009 13:51:41 +0000 (+0000)
Subject: MDL-19057 No more exceptions in tests for oracle. If tests fail, MDL-20339 can be... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=d578c197579ee967f7dc225ade0dda3a3ed29e07;p=moodle.git

MDL-19057 No more exceptions in tests for oracle. If tests fail, MDL-20339 can be the culprit.
---

diff --git a/lib/dml/simpletest/testdml.php b/lib/dml/simpletest/testdml.php
index cb20d044f7..5b2a232aae 100755
--- a/lib/dml/simpletest/testdml.php
+++ b/lib/dml/simpletest/testdml.php
@@ -51,12 +51,7 @@ class dml_test extends UnitTestCase {
         $dbman = $this->tdb->get_manager();
 
         if ($tablename == '') {
-            if ($DB->get_dbfamily() == 'oracle') { // To avoid one strange (OCI internal schema cache?) bug causing ORA-01007 errors
-                static $i = 0;                     // if the same table is created multiple times and SELECT * are
-                $tablename = "unit_table".$i++;    // executed against it. Curiously error doesn't happen if the query
-            } else {                               // specify the list of columns instead of *. Haven't found any logic cause
-                $tablename = "unit_table";         // for the problem in our code, just this workaround. Luckily this isn't a
-            }                                      // problem in normal usage (same table being recreated once and again)
+            $tablename = "unit_table";
         }
 
         $table = new xmldb_table($tablename);