From: moodler <moodler>
Date: Fri, 8 Oct 2004 13:58:33 +0000 (+0000)
Subject: Minor changes for XHTML compatibility
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=d7d21c383c02f9e542d170b4365ec96954ad7839;p=moodle.git

Minor changes for XHTML compatibility
---

diff --git a/lib/weblib.php b/lib/weblib.php
index 706efa7f65..5904173eee 100644
--- a/lib/weblib.php
+++ b/lib/weblib.php
@@ -541,7 +541,7 @@ function button_to_popup_window ($url, $name='popup', $linkname='click here',
     $fullscreen = 0;
 
     echo '<input type="button" name="popupwindow" title="'. $title .'" value="'. $linkname .' ..." '.
-         "onClick=\"return openpopup('$url', '$name', '$options', $fullscreen);\" />\n";
+         "onclick=\"return openpopup('$url', '$name', '$options', $fullscreen);\" />\n";
 }
 
 
@@ -554,7 +554,7 @@ function close_window_button() {
     echo '<script type="text/javascript">' . "\n";
     echo '<!--' . "\n";
     echo "document.write('<form>');\n";
-    echo "document.write('<input type=\"button\" onClick=\"self.close();\" value=\"".get_string("closewindow")."\" />');\n";
+    echo "document.write('<input type=\"button\" onclick=\"self.close();\" value=\"".get_string("closewindow")."\" />');\n";
     echo "document.write('</form>');\n";
     echo '-->' . "\n";
     echo '</script>' . "\n";
diff --git a/mod/dialogue/lib.php b/mod/dialogue/lib.php
index 2d4cb570eb..a82bbf0201 100644
--- a/mod/dialogue/lib.php
+++ b/mod/dialogue/lib.php
@@ -171,7 +171,7 @@ function dialogue_print_recent_activity($course, $isteacher, $timestart) {
                 if (instance_is_visible("dialogue",$tempmod)) {
                     $date = userdate($log->time, $strftimerecent);
                     echo '<p><font size="1">'.$date.' - '.fullname($log).'<br />';
-                    echo "\"<a href=\"$CFG->wwwroot/mod/dialogue/$log->url\">";
+                    echo "\"<a href=\"$CFG->wwwroot/mod/dialogue/".str_replace('&', '&amp;', $log->url)."\">";
                     echo "$log->name";
                     echo "</a>\"</font></p>";
                 }
@@ -205,7 +205,7 @@ function dialogue_print_recent_activity($course, $isteacher, $timestart) {
                 if (instance_is_visible("dialogue",$tempmod)) {
                     $date = userdate($log->time, $strftimerecent);
                     echo '<p><font size="1">'.$date.' - '.fullname($log).'<br />';
-                    echo "\"<a href=\"$CFG->wwwroot/mod/dialogue/$log->url\">";
+                    echo "\"<a href=\"$CFG->wwwroot/mod/dialogue/".str_replace('&', '&amp;', $log->url)."\">";
                     echo "$log->name";
                     echo "</a>\"</font></p>";
                 }
@@ -240,7 +240,7 @@ function dialogue_print_recent_activity($course, $isteacher, $timestart) {
                     $date = userdate($log->time, $strftimerecent);
                     echo "<p><font size=1>$date - ".get_string("namehascloseddialogue", "dialogue",
                         fullname($log))."<br />";
-                    echo "\"<a href=\"$CFG->wwwroot/mod/dialogue/$log->url\">";
+                    echo "\"<a href=\"$CFG->wwwroot/mod/dialogue/".str_replace('&', '&amp;', $log->url)."\">";
                     echo "$log->name";
                     echo "</a>\"</font></p>";
                 }
diff --git a/mod/exercise/lib.php b/mod/exercise/lib.php
index f2a406207b..d84b2414c2 100644
--- a/mod/exercise/lib.php
+++ b/mod/exercise/lib.php
@@ -342,7 +342,7 @@ function exercise_print_recent_activity($course, $isteacher, $timestart) {
                     if (instance_is_visible("exercise",$tempmod)) {
                         $date = userdate($log->time, $strftimerecent);
                         echo '<p><font size="1">'.$date.' - '.fullname($log).'<br />';
-                        echo "\"<a href=\"$CFG->wwwroot/mod/exercise/$log->url\">";
+                        echo "\"<a href=\"$CFG->wwwroot/mod/exercise/".str_replace('&', '&amp;', $log->url)."\">";
                         echo "$log->name";
                         echo "</a>\"</font></p>";
                         }
@@ -377,7 +377,7 @@ function exercise_print_recent_activity($course, $isteacher, $timestart) {
                 if (instance_is_visible("exercise",$tempmod)) {
                     $date = userdate($log->time, $strftimerecent);
                     echo '<p><font size="1">'.$date.' - '.fullname($log).'<br />';
-                    echo "\"<a href=\"$CFG->wwwroot/mod/exercise/$log->url\">";
+                    echo "\"<a href=\"$CFG->wwwroot/mod/exercise/".str_replace('&', '&amp;', $log->url)."\">";
                     echo "$log->name";
                     echo "</a>\"</font></p>";
                     }
@@ -412,7 +412,7 @@ function exercise_print_recent_activity($course, $isteacher, $timestart) {
                     if (instance_is_visible("exercise",$tempmod)) {
                         $date = userdate($log->time, $strftimerecent);
                         echo '<p><font size="1">'.$date.' - '.fullname($log).'<br />';
-                        echo "\"<a href=\"$CFG->wwwroot/mod/exercise/$log->url\">";
+                        echo "\"<a href=\"$CFG->wwwroot/mod/exercise/".str_replace('&', '&amp;', $log->url)."\">";
                         echo "$log->name";
                         echo "</a>\"</font></p>";
                         }
diff --git a/mod/glossary/lib.php b/mod/glossary/lib.php
index 86f69de06f..3a7b4ba61a 100644
--- a/mod/glossary/lib.php
+++ b/mod/glossary/lib.php
@@ -248,7 +248,7 @@ function glossary_print_recent_activity($course, $isteacher, $timestart) {
         if ($modvisible and $entry->approved) {
             $entries[$log->info] = glossary_log_info($log);
             $entries[$log->info]->time = $log->time;
-            $entries[$log->info]->url  = $log->url;
+            $entries[$log->info]->url  = str_replace('&', '&amp;', $log->url);
         }
     }
 
diff --git a/mod/journal/lib.php b/mod/journal/lib.php
index a2a8673b5c..077f1dc118 100644
--- a/mod/journal/lib.php
+++ b/mod/journal/lib.php
@@ -212,7 +212,7 @@ function journal_print_recent_activity($course, $isteacher, $timestart) {
             if (!isset($journals[$log->info])) {
                 $journals[$log->info] = $j_log_info;
                 $journals[$log->info]->time = $log->time;
-                $journals[$log->info]->url = $log->url;
+                $journals[$log->info]->url = str_replace('&', '&amp;', $log->url);
             }
         }
     }
diff --git a/mod/survey/lib.php b/mod/survey/lib.php
index 1c41ac3a56..e53c92e196 100644
--- a/mod/survey/lib.php
+++ b/mod/survey/lib.php
@@ -156,7 +156,7 @@ function survey_print_recent_activity($course, $isteacher, $timestart) {
         if ($modvisible) {
             $surveys[$log->id] = survey_log_info($log);
             $surveys[$log->id]->time = $log->time;
-            $surveys[$log->id]->url = $log->url;
+            $surveys[$log->id]->url = str_replace('&', '&amp;' $log->url);
         }
     }
 
diff --git a/mod/workshop/lib.php b/mod/workshop/lib.php
index 60fa08914a..1e17df003b 100644
--- a/mod/workshop/lib.php
+++ b/mod/workshop/lib.php
@@ -716,7 +716,7 @@ function workshop_print_recent_activity($course, $isteacher, $timestart) {
                         else { // don't break anonymous rule
                             echo "<p><font size=\"1\">$date - A $course->student<br />";
                             }
-                        echo "\"<a href=\"$CFG->wwwroot/mod/workshop/$log->url\">";
+                        echo "\"<a href=\"$CFG->wwwroot/mod/workshop/".str_replace('&', '&amp;', $log->url)."\">";
                         echo "$log->name";
                         echo "</a>\"</font></p>";
                         }
@@ -757,7 +757,7 @@ function workshop_print_recent_activity($course, $isteacher, $timestart) {
                         else { // don't break anonymous rule
                             echo "<p><font size=\"1\">$date - A $course->student<br />";
                             }
-                        echo "\"<a href=\"$CFG->wwwroot/mod/workshop/$log->url\">";
+                        echo "\"<a href=\"$CFG->wwwroot/mod/workshop/".str_replace('&', '&amp;', $log->url)."\">";
                         echo "$log->name";
                         echo "</a>\"</font></p>";
                         }
@@ -793,7 +793,7 @@ function workshop_print_recent_activity($course, $isteacher, $timestart) {
                     if (instance_is_visible("workshop",$tempmod)) {
                         $date = userdate($log->time, $strftimerecent);
                         echo "<p><font size=\"1\">$date - A $course->student<br />";
-                        echo "\"<a href=\"$CFG->wwwroot/mod/workshop/$log->url\">";
+                        echo "\"<a href=\"$CFG->wwwroot/mod/workshop/".str_replace('&', '&amp;', $log->url)."\">";
                         echo "$log->name";
                         echo "</a>\"</font></p>";
                         }
@@ -828,7 +828,7 @@ function workshop_print_recent_activity($course, $isteacher, $timestart) {
                 if (instance_is_visible("workshop",$tempmod)) {
                     $date = userdate($log->time, $strftimerecent);
                     echo "<p><font size=\"1\">$date - $course->teacher<br />";
-                    echo "\"<a href=\"$CFG->wwwroot/mod/workshop/$log->url\">";
+                    echo "\"<a href=\"$CFG->wwwroot/mod/workshop/".str_replace('&', '&amp;', $log->url)."\">";
                     echo "$log->name";
                     echo "</a>\"</font></p>";
                     }
@@ -863,7 +863,7 @@ function workshop_print_recent_activity($course, $isteacher, $timestart) {
                     if (instance_is_visible("workshop",$tempmod)) {
                         $date = userdate($log->time, $strftimerecent);
                         echo "<p><font size=\"1\">$date - ".fullname($log)."<br />";
-                        echo "\"<a href=\"$CFG->wwwroot/mod/workshop/$log->url\">";
+                        echo "\"<a href=\"$CFG->wwwroot/mod/workshop/".str_replace('&', '&amp;', $log->url)."\">";
                         echo "$log->name";
                         echo "</a>\"</font></p>";
                         }