From: Andrew Davis Date: Thu, 17 Dec 2009 07:29:57 +0000 (+0000) Subject: gradebook MDL-20945 Title attribute missing from cells in grader report X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=e09e9d55b6a2d53e73be0fbb91b7932ebad51ca2;p=moodle.git gradebook MDL-20945 Title attribute missing from cells in grader report --- diff --git a/grade/report/grader/grader.js b/grade/report/grader/grader.js index f785d7b582..a45c23b29a 100644 --- a/grade/report/grader/grader.js +++ b/grade/report/grader/grader.js @@ -6,11 +6,11 @@ YAHOO.graderreport.init = function() { var rows = YAHOO.util.Dom.getElementsByClassName('heading_name_row'); if(rows && rows.length>0) { - var header_cell_region = YAHOO.util.Dom.getRegion(rows[rows.length-1].firstChild); + var header_cell_region = YAHOO.util.Dom.getRegion(rows[rows.length-1]); if(header_cell_region) { var height = header_cell_region.bottom - header_cell_region.top; - if(!isNan(height)) + if(!isNaN(height)) { YAHOO.util.Dom.setStyle('studentheader', 'height', height + 'px'); } diff --git a/lib/outputrenderers.php b/lib/outputrenderers.php index d89da02703..d2271647a4 100644 --- a/lib/outputrenderers.php +++ b/lib/outputrenderers.php @@ -1878,7 +1878,8 @@ class core_renderer extends renderer_base { 'id' => $cell->id, 'class' => $cell->get_classes_string(), 'abbr' => $cell->abbr, - 'scope' => $cell->scope); + 'scope' => $cell->scope, + 'title' => html_entity_decode($cell->title)); $tagtype = 'td'; if ($cell->header === true) { $tagtype = 'th';