From: martinlanghoff <martinlanghoff>
Date: Sun, 6 May 2007 05:27:31 +0000 (+0000)
Subject: get_my_courses() - tighten default fields - faster, risky
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=e4271d740c47d091629d76c4e3b473cbcea0c129;p=moodle.git

get_my_courses() - tighten default fields - faster, risky

This makes get_my_courses() faster/lighter in 2 ways

 - We fetch a ton less data from the DB
 - We store a tone less data in the Session

In a test environment, with a student enrolled in  3 _empty_ courses
(just created, empty modinfo, etc), this shaves 50% off the session
size on-disk.

The problem is callers that may be expecting a given field to appear by
default. Next step: walk all callers...
---

diff --git a/lib/datalib.php b/lib/datalib.php
index 34498d029b..65dce50b3c 100644
--- a/lib/datalib.php
+++ b/lib/datalib.php
@@ -686,7 +686,7 @@ function get_my_courses($userid, $sort=NULL, $fields=NULL, $doanything=false,$li
 
     // Default parameters
     $d_sort   = 'visible DESC,sortorder ASC';
-    $d_fields = '*';
+    $d_fields = 'id, category, sortorder, shortname, fullname, idnumber, newsitems, teacher, teachers, student, students, guest, startdate, visible, cost, enrol, summary';
 
     $usingdefaults = true;
     if (is_null($sort)) {