From: skodak <skodak>
Date: Thu, 5 Jun 2008 14:08:58 +0000 (+0000)
Subject: MDL-15100 gradebook conversion
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=ea1e551da63e9c318d21886c80e838605c588aeb;p=moodle.git

MDL-15100 gradebook conversion
---

diff --git a/grade/report/user/lib.php b/grade/report/user/lib.php
index 4a2b0413c8..11a668a155 100644
--- a/grade/report/user/lib.php
+++ b/grade/report/user/lib.php
@@ -140,7 +140,7 @@ class grade_report_user extends grade_report {
     }
 
     public function fill_table() {
-        global $CFG;
+        global $CFG, $DB;
         $numusers = $this->get_numusers(false); // total course users
         $items =& $this->gseq->items;
         $grades = array();
@@ -265,9 +265,9 @@ class grade_report_user extends grade_report {
                     /// find the number of users with a higher grade
                     $sql = "SELECT COUNT(DISTINCT(userid))
                               FROM {grade_grades}
-                             WHERE finalgrade > {$grade_grade->finalgrade}
-                                   AND itemid = {$grade_item->id}";
-                    $rank = count_records_sql($sql) + 1;
+                             WHERE finalgrade > ?
+                                   AND itemid = ?";
+                    $rank = $DB->count_records_sql($sql, array($grade_grade->finalgrade, $grade_item->id)) + 1;
 
                     $data[] = '<span class="'.$hidden.$class.'">'."$rank/$numusers".'</span>';
                 }