From: stronk7 <stronk7>
Date: Mon, 28 Sep 2009 23:16:05 +0000 (+0000)
Subject: MDL-14679 table/column meta cache is reset on each request and DDL operation.
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=f713581bc38b9909411cac076adf7349355495e4;p=moodle.git

MDL-14679 table/column meta cache is reset on each request and DDL operation.
No need to call it with false parameter but in very exceptional ocasions.
---

diff --git a/lib/ddl/database_manager.php b/lib/ddl/database_manager.php
index 2b0d010196..60a469a4d3 100644
--- a/lib/ddl/database_manager.php
+++ b/lib/ddl/database_manager.php
@@ -152,7 +152,7 @@ class database_manager {
         }
 
     /// Get list of fields in table
-        $columns = $this->mdb->get_columns($tablename, false);
+        $columns = $this->mdb->get_columns($tablename);
 
         $exists = array_key_exists($fieldname,  $columns);
 
@@ -1010,7 +1010,7 @@ class database_manager {
             }
 
             // a) check for required fields
-            $dbfields = $this->mdb->get_columns($tablename, false);
+            $dbfields = $this->mdb->get_columns($tablename);
             $fields   = $table->getFields();
             foreach ($fields as $field) {
                 $fieldname = $field->getName();
diff --git a/lib/ddl/mssql_sql_generator.php b/lib/ddl/mssql_sql_generator.php
index eb56aba40b..9392aed3ab 100644
--- a/lib/ddl/mssql_sql_generator.php
+++ b/lib/ddl/mssql_sql_generator.php
@@ -299,7 +299,7 @@ class mssql_sql_generator extends sql_generator {
         $fieldname = $xmldb_field->getName();
 
     /// Take a look to field metadata
-        $meta = $this->mdb->get_columns($tablename, false);
+        $meta = $this->mdb->get_columns($tablename);
         $metac = $meta[$fieldname];
         $oldmetatype = $metac->meta_type;
 
diff --git a/lib/ddl/mysql_sql_generator.php b/lib/ddl/mysql_sql_generator.php
index b3f5d06c18..74b092f321 100644
--- a/lib/ddl/mysql_sql_generator.php
+++ b/lib/ddl/mysql_sql_generator.php
@@ -308,7 +308,7 @@ class mysql_sql_generator extends sql_generator {
         $tablename = $xmldb_table->getName($xmldb_table);
 
     /// Fetch all the columns in the table
-        if (!$columns = $this->mdb->get_columns($tablename, false)) {
+        if (!$columns = $this->mdb->get_columns($tablename)) {
             return array();
         }
 
diff --git a/lib/ddl/postgres_sql_generator.php b/lib/ddl/postgres_sql_generator.php
index 19c83d1d86..9d78fbcc61 100644
--- a/lib/ddl/postgres_sql_generator.php
+++ b/lib/ddl/postgres_sql_generator.php
@@ -198,7 +198,7 @@ class postgres_sql_generator extends sql_generator {
         $fieldname = $xmldb_field->getName();
 
     /// Take a look to field metadata
-        $meta = $this->mdb->get_columns($tablename, false);
+        $meta = $this->mdb->get_columns($tablename);
         $metac = $meta[$xmldb_field->getName()];
         $oldmetatype = $metac->meta_type;
         $oldlength = $metac->max_length;