From: stronk7 <stronk7>
Date: Fri, 23 Jan 2009 16:32:21 +0000 (+0000)
Subject: MDL-17998 forum ajax rating - avoid 'null' printout + improved search by class (IE7... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=fd6a649399f94ee876c9fcee01cdb294d22c581c;p=moodle.git

MDL-17998 forum ajax rating - avoid 'null' printout + improved search by class (IE7, you know) ; merged from 19_STABLE
---

diff --git a/mod/forum/rate_ajax.js b/mod/forum/rate_ajax.js
index 7f4fb3d75d..39de748fab 100644
--- a/mod/forum/rate_ajax.js
+++ b/mod/forum/rate_ajax.js
@@ -144,17 +144,17 @@ function display_response(menu, response) {
 
     /** Process ok response, displaying it **/
     var ratingsDiv  = YAHOO.util.Dom.getAncestorByTagName(menu, 'div');
-    var ratingsSpan = YAHOO.util.Dom.getFirstChildBy(ratingsDiv, function(el){return el.getAttribute('class') == 'forumpostratingtext';});
+    var ratingsSpan = YAHOO.util.Dom.getFirstChildBy(ratingsDiv, function(el){return YAHOO.util.Dom.hasClass(el,'forumpostratingtext');});
 
-    /** span doesn't exist (first rate), add it, shouldn't happen ever but... **/
+    /** span doesn't exist (first rate), add it, shouldn't happen ever but... fallback**/
     if (!ratingsSpan) {
-        var ratingsSpan = document.createElement('span');
+        ratingsSpan = document.createElement('span');
         YAHOO.util.Dom.addClass(ratingsSpan, 'forumpostratingtext');
         ratingsDiv.appendChild(ratingsSpan);
     }
 
     /** finally replace span HTML **/
-    ratingsSpan.innerHTML = response.message;
+    ratingsSpan.innerHTML = response.message ? response.message : ''; /** Prevent null to be printed in IE7 **/
 }
 
 /**