From: skodak <skodak>
Date: Wed, 27 Feb 2008 10:11:22 +0000 (+0000)
Subject: MDL-13690 activity outcome items do not support calculation - remove calc icon; merge... 
X-Git-Url: http://git.mjollnir.org/gw?a=commitdiff_plain;h=ff1bc6034d8c2da55853575b031644476f394962;p=moodle.git

MDL-13690 activity outcome items do not support calculation - remove calc icon; merged from MOODLE_19_STABLE
---

diff --git a/grade/edit/tree/calculation.php b/grade/edit/tree/calculation.php
index 0c718fabd0..1b7145d4fb 100644
--- a/grade/edit/tree/calculation.php
+++ b/grade/edit/tree/calculation.php
@@ -49,9 +49,8 @@ if (!$grade_item = grade_item::fetch(array('id'=>$id, 'courseid'=>$course->id)))
     error('Incorect item id');
 }
 
-// module items and items without grade can not have calculation
-if (($grade_item->is_external_item() and !$grade_item->is_outcome_item())
-  or ($grade_item->gradetype != GRADE_TYPE_VALUE and $grade_item->gradetype != GRADE_TYPE_SCALE)) {
+// activity items and items without grade can not have calculation
+if ($grade_item->is_external_item() or ($grade_item->gradetype != GRADE_TYPE_VALUE and $grade_item->gradetype != GRADE_TYPE_SCALE)) {
     redirect($returnurl, get_string('errornocalculationallowed', 'grades')); 
 }
 
diff --git a/grade/lib.php b/grade/lib.php
index dfe586116f..2948aab9bb 100644
--- a/grade/lib.php
+++ b/grade/lib.php
@@ -1096,8 +1096,7 @@ class grade_structure {
             $streditcalculation = get_string('editcalculationverbose', 'grades', $strparams);
 
             // show calculation icon only when calculation possible
-            if ((!$object->is_external_item() or $object->is_outcome_item())
-              and ($object->gradetype == GRADE_TYPE_SCALE or $object->gradetype == GRADE_TYPE_VALUE)) {
+            if (!$object->is_external_item() and ($object->gradetype == GRADE_TYPE_SCALE or $object->gradetype == GRADE_TYPE_VALUE)) {
                 if ($object->is_calculated()) {
                     $icon = 'calc.gif';
                 } else {