tjhunt [Wed, 12 Dec 2007 17:23:55 +0000 (17:23 +0000)]
MDL-9459 - Provide information relating to groups in the summary message "Attemts: 123". Now, depending on the situation, you see one of three messages: "Attempts: 123", "Attemtps 123 (45 from your groups)" or "Attemtps 123 (45 from this group)".
I also took the opportunity to improve the layout of this message slightly, and clarify the message that tells you that you cannot add or remove questions from the quiz if there are attemts.
tjhunt [Tue, 11 Dec 2007 18:49:56 +0000 (18:49 +0000)]
MDL-12546 - The choice module was calling get_users_by_capability, which hammers the database and returns lots of data, inside a loop over users - and it was calling it with identical parameters each time. Ouch!
Actually, since the fix for MDL-12331, which changed the get_users_by_capability call at the top of this function, the check it was doing is entirely redundant anyway, so I removed it.
tjhunt [Tue, 11 Dec 2007 15:55:25 +0000 (15:55 +0000)]
MDL-12542 - backup_todb not called on restore on date before it is inserted into mdl_user. This would cause a backup from a pre 1.7 site (or a pre 1.7 that has been upgraded to 1.9) to a 1.9 fresh install, to fail sometimes. Merged from MOODLE_19_STABLE.
tjhunt [Tue, 11 Dec 2007 10:37:53 +0000 (10:37 +0000)]
Take out debugging output in role_assign. It only tells you that something has worked, and everywhere else we use debugging output to warn people they have called an API wrongly. Therefore, this is just confusing now that we trust this bit of roles code.
tjhunt [Mon, 10 Dec 2007 17:37:14 +0000 (17:37 +0000)]
MDL-12512 - Gradebook calculations are broken. This was caused by == FALSE that should have been === FALSE deep in the 3rd pary maths lib. Merged from MOODLE_19_STABLE.
nicolasconnault [Fri, 7 Dec 2007 09:14:51 +0000 (09:14 +0000)]
MDL-11835 Changing default aggregateonlygraded back to true, but set this value to false for upgraded course categories. Also set grade display type to percentage for upgraded items, since this is the default setting in 1.8. Site default is Real display type.
tjhunt [Wed, 5 Dec 2007 16:14:29 +0000 (16:14 +0000)]
MDL-12450 - Matching up roles on the restore settings form is broken - this is basically a complete rewrite of these two functions. Merged from MOODLE_19_STABLE.
nicolasconnault [Wed, 5 Dec 2007 09:35:19 +0000 (09:35 +0000)]
MDL-11835 Implemented changes discussed in http://moodle.org/mod/forum/discuss.php?d=85908. Also added item name and module name and category name (for category totals) in alt tags of icons
poltawski [Tue, 4 Dec 2007 12:57:02 +0000 (12:57 +0000)]
MDL-12415 - When we have more than one category/lots of courses the course
block shows two links next to search other (Search Courses/All courses)
which point to the same place....
The all courses link is able to be switched off and the search courses is not,
for this reason i've gone for removing the search courses link.
nicolasconnault [Tue, 4 Dec 2007 10:35:25 +0000 (10:35 +0000)]
MDL-12389 Removed the selectallornone element in favour of a more generic submitlink element. The checkbox controller is now added to a form using moodleform::add_checkbox_controller.
Oracle does not accept column labels in the GROUP BY section -
get_logs_usercourse() and get_logs_userday() were computing the
day/hours column and using it in the GROUP BY. The compatible fix
is to reproduce the same computation in the GROUP BY section.
Credit for the fix goes to Dennis Rochford <Dennis.Rochford@usq.edu.au>.
stronk7 [Mon, 3 Dec 2007 20:30:41 +0000 (20:30 +0000)]
Adding two new functions: sql_isempty() and sql_isnotempty() to perform
SQL comparisons to empties in a cross-db way. General solution for
problems like MDL-12084
nicolasconnault [Mon, 3 Dec 2007 20:13:01 +0000 (20:13 +0000)]
MDL-12389 Added a new getElementsByClassName function in lib/javascript.php, added the selectallornone formslib element, modified the advcheckbox element to support the group variable, and implemented the new element in grade_export_form
nicolasconnault [Mon, 3 Dec 2007 15:42:11 +0000 (15:42 +0000)]
MDL-12389 Added a new getElementsByClassName function in lib/javascript.php, added the selectallornone formslib element, modified the advcheckbox element to support the group variable, and implemented the new element in grade_export_form