]> git.mjollnir.org Git - moodle.git/log
moodle.git
15 years agoworkshop uses plain checkbox instead of advcheckbox
David Mudrak [Mon, 4 Jan 2010 18:27:07 +0000 (18:27 +0000)]
workshop uses plain checkbox instead of advcheckbox

15 years agoworkshop in reply to MDL-20204 - new output API
David Mudrak [Mon, 4 Jan 2010 18:26:56 +0000 (18:26 +0000)]
workshop in reply to MDL-20204 - new output API

15 years agoworkshop in reply to MDL-20787: module icon moved to the new location
David Mudrak [Mon, 4 Jan 2010 18:26:21 +0000 (18:26 +0000)]
workshop in reply to MDL-20787: module icon moved to the new location

15 years agoworkshop: fixed two grading evaluation errors
David Mudrak [Mon, 4 Jan 2010 18:26:02 +0000 (18:26 +0000)]
workshop: fixed two grading evaluation errors

The first one was caused by the wrong rounding. The second one caused
the best assessment not being recognized properly.

15 years agoFixed deprecated call by reference
David Mudrak [Mon, 4 Jan 2010 18:25:52 +0000 (18:25 +0000)]
Fixed deprecated call by reference

15 years agoYet another MySQL fix
David Mudrak [Mon, 4 Jan 2010 18:25:41 +0000 (18:25 +0000)]
Yet another MySQL fix

15 years agoAn attempt to fix an SQL bug appearing at MySQL
David Mudrak [Mon, 4 Jan 2010 18:25:23 +0000 (18:25 +0000)]
An attempt to fix an SQL bug appearing at MySQL

15 years agoworkshop submission: fixed error preventing to submit at MySQL server
David Mudrak [Mon, 4 Jan 2010 18:25:13 +0000 (18:25 +0000)]
workshop submission: fixed error preventing to submit at MySQL server

15 years agoFixed missing library include when deleting an instance
David Mudrak [Mon, 4 Jan 2010 18:25:03 +0000 (18:25 +0000)]
Fixed missing library include when deleting an instance

15 years agoMDL-19937 workshop migration - setting day zero versions
David Mudrak [Mon, 4 Jan 2010 18:24:52 +0000 (18:24 +0000)]
MDL-19937 workshop migration - setting day zero versions

15 years agoDropping support for scheduled release of grades - it is gradebook's
David Mudrak [Mon, 4 Jan 2010 18:24:28 +0000 (18:24 +0000)]
Dropping support for scheduled release of grades - it is gradebook's
duty

15 years agoVarious fixes found during testing
David Mudrak [Mon, 4 Jan 2010 18:24:17 +0000 (18:24 +0000)]
Various fixes found during testing

15 years agoMDL-20058 totalgrade stuff removed from workshop code
David Mudrak [Mon, 4 Jan 2010 18:24:03 +0000 (18:24 +0000)]
MDL-20058 totalgrade stuff removed from workshop code

15 years agoMDL-20058 workshop pushed grades into gradebook
David Mudrak [Mon, 4 Jan 2010 18:23:52 +0000 (18:23 +0000)]
MDL-20058 workshop pushed grades into gradebook

15 years agoRenamed a param to handle block editing mode
David Mudrak [Mon, 4 Jan 2010 18:23:42 +0000 (18:23 +0000)]
Renamed a param to handle block editing mode

15 years agoMDL-20058 workshop grades can be overridden in grading evaluation phase only
David Mudrak [Mon, 4 Jan 2010 18:23:32 +0000 (18:23 +0000)]
MDL-20058 workshop grades can be overridden in grading evaluation phase only

15 years agoMDL-20058 workshop allows override grade for submission
David Mudrak [Mon, 4 Jan 2010 18:23:22 +0000 (18:23 +0000)]
MDL-20058 workshop allows override grade for submission

15 years agoRefactor submission.php a bit to prepare for feedback form
David Mudrak [Mon, 4 Jan 2010 18:23:08 +0000 (18:23 +0000)]
Refactor submission.php a bit to prepare for feedback form

15 years agoworkshop: fixed link to the attachment in a folder
David Mudrak [Mon, 4 Jan 2010 18:22:58 +0000 (18:22 +0000)]
workshop: fixed link to the attachment in a folder

15 years agoMDL-20058 workshop grading report fixes and small improvements
David Mudrak [Mon, 4 Jan 2010 18:22:47 +0000 (18:22 +0000)]
MDL-20058 workshop grading report fixes and small improvements

15 years agoDo not display given grade before the workshop is closed
David Mudrak [Mon, 4 Jan 2010 18:22:37 +0000 (18:22 +0000)]
Do not display given grade before the workshop is closed

15 years agoReplaced develtools with a temporary loginas tab
David Mudrak [Mon, 4 Jan 2010 18:22:27 +0000 (18:22 +0000)]
Replaced develtools with a temporary loginas tab

15 years agoworkshop: general cleanup
David Mudrak [Mon, 4 Jan 2010 18:22:10 +0000 (18:22 +0000)]
workshop: general cleanup

Moving stuff from lib.php into static methods in localib.php. Removing
things from workshop core that were implemented in a subplugin. Dropping
stuff related to features not to be implemented in 2.0.

15 years agoMDL-19930 workshop: comments grading strategy
David Mudrak [Mon, 4 Jan 2010 18:21:42 +0000 (18:21 +0000)]
MDL-19930 workshop: comments grading strategy

15 years agoRough search and replace accumulative > comments
David Mudrak [Mon, 4 Jan 2010 18:21:24 +0000 (18:21 +0000)]
Rough search and replace accumulative > comments

15 years agoInitial copy of form/accumulative code
David Mudrak [Mon, 4 Jan 2010 18:21:04 +0000 (18:21 +0000)]
Initial copy of form/accumulative code

15 years agoAssessments overrides and feedbacks
David Mudrak [Mon, 4 Jan 2010 18:20:24 +0000 (18:20 +0000)]
Assessments overrides and feedbacks

This requires the patch of MDL-20623 to be applied

15 years agoFrozen grid rubric layout fix
David Mudrak [Mon, 4 Jan 2010 18:20:10 +0000 (18:20 +0000)]
Frozen grid rubric layout fix

15 years agoVIP Assessment review
David Mudrak [Mon, 4 Jan 2010 18:19:58 +0000 (18:19 +0000)]
VIP Assessment review

15 years agoFixed submission grade aggregation
David Mudrak [Mon, 4 Jan 2010 18:19:48 +0000 (18:19 +0000)]
Fixed submission grade aggregation

Overriding the submission grade influence the total grade, not the
aggregated one.

15 years agoAssessment form preview handled by a dedicated script
David Mudrak [Mon, 4 Jan 2010 18:19:37 +0000 (18:19 +0000)]
Assessment form preview handled by a dedicated script

This was part of assessment.php but it makes the things too complicated.

15 years agoeval/best/ is officially called 'Comparison with the best assessment'
David Mudrak [Mon, 4 Jan 2010 18:19:24 +0000 (18:19 +0000)]
eval/best/ is officially called 'Comparison with the best assessment'

15 years agoAllow opening assessment forms in read-only mode
David Mudrak [Mon, 4 Jan 2010 18:19:13 +0000 (18:19 +0000)]
Allow opening assessment forms in read-only mode

15 years agoRemember the recently used grading evaluation settings
David Mudrak [Mon, 4 Jan 2010 18:18:53 +0000 (18:18 +0000)]
Remember the recently used grading evaluation settings

15 years agoGrading evaluation is now configurable on-the-fly
David Mudrak [Mon, 4 Jan 2010 18:18:30 +0000 (18:18 +0000)]
Grading evaluation is now configurable on-the-fly

15 years agoWorkshop total grade calculation support
David Mudrak [Mon, 4 Jan 2010 18:18:00 +0000 (18:18 +0000)]
Workshop total grade calculation support

15 years agoDisplay real grade values in the grading report
David Mudrak [Mon, 4 Jan 2010 18:17:47 +0000 (18:17 +0000)]
Display real grade values in the grading report

15 years agoGrading grades aggregations
David Mudrak [Mon, 4 Jan 2010 18:17:37 +0000 (18:17 +0000)]
Grading grades aggregations

15 years agoFaking assessments reworked
David Mudrak [Mon, 4 Jan 2010 18:17:27 +0000 (18:17 +0000)]
Faking assessments reworked

15 years agoFixed regression and broken interafce implementation
David Mudrak [Mon, 4 Jan 2010 18:17:17 +0000 (18:17 +0000)]
Fixed regression and broken interafce implementation

15 years agoGetting rid of supports_evaluation()
David Mudrak [Mon, 4 Jan 2010 18:17:03 +0000 (18:17 +0000)]
Getting rid of supports_evaluation()

This seems to be over-desing-patternized. Methods needed by standard
eval plugins (ie part of standard distribution) are part of strategy
API. Contributed eval methods will have to patch strategy plugins if
they need some other data from them.

15 years agoMethods to get info about assessments and dimensions are part of strategy API
David Mudrak [Mon, 4 Jan 2010 18:16:41 +0000 (18:16 +0000)]
Methods to get info about assessments and dimensions are part of strategy API

15 years agoPagination a sorting fix
David Mudrak [Mon, 4 Jan 2010 18:16:23 +0000 (18:16 +0000)]
Pagination a sorting fix

15 years agoRubric: fixed best evaluation support
David Mudrak [Mon, 4 Jan 2010 18:16:13 +0000 (18:16 +0000)]
Rubric: fixed best evaluation support

15 years agoMDL-19932 Rubric grading strategy implemented
David Mudrak [Mon, 4 Jan 2010 18:16:02 +0000 (18:16 +0000)]
MDL-19932 Rubric grading strategy implemented

The only weak point here is that we store a raw grade into
workshop_grades and not a direct id of the selected level. Therefore,
when re-assessing, we need to actually guess what level the assessor
chose previously. This is not problem if there are not two levels with
the same grade. Such case is not common when using Rubric. In the
future, this may get refactored so Rubric would use its own storage of
filled assessment forms.

15 years agoMoving some helper functions from the renderer to the workshop API
David Mudrak [Mon, 4 Jan 2010 18:15:48 +0000 (18:15 +0000)]
Moving some helper functions from the renderer to the workshop API

15 years agoMDL-19932 First drafts of Rubric strategy
David Mudrak [Mon, 4 Jan 2010 18:15:38 +0000 (18:15 +0000)]
MDL-19932 First drafts of Rubric strategy

Assessment form editing should work

15 years agoParameter consistency check
David Mudrak [Mon, 4 Jan 2010 18:15:24 +0000 (18:15 +0000)]
Parameter consistency check

15 years agoConstant name fixed and improved empty input check
David Mudrak [Mon, 4 Jan 2010 18:15:14 +0000 (18:15 +0000)]
Constant name fixed and improved empty input check

15 years agoFixed a table name
David Mudrak [Mon, 4 Jan 2010 18:15:00 +0000 (18:15 +0000)]
Fixed a table name

15 years agoInitial commit of rubric code, copied from accumulative
David Mudrak [Mon, 4 Jan 2010 18:14:49 +0000 (18:14 +0000)]
Initial commit of rubric code, copied from accumulative

15 years agoFixed a phpDoc param type
David Mudrak [Mon, 4 Jan 2010 18:14:12 +0000 (18:14 +0000)]
Fixed a phpDoc param type

15 years agoGrading evaluation - best subplugin
David Mudrak [Mon, 4 Jan 2010 18:14:01 +0000 (18:14 +0000)]
Grading evaluation - best subplugin

I am not happy with the algorithm at all. We should replace it with some
more sophisticated subplugin, using ICC or some similar statistics.

15 years agoRenamed unittest files and a small change due to evaluation
David Mudrak [Mon, 4 Jan 2010 18:13:42 +0000 (18:13 +0000)]
Renamed unittest files and a small change due to evaluation

15 years agoCall the parent's constructor in renderers
David Mudrak [Mon, 4 Jan 2010 18:13:17 +0000 (18:13 +0000)]
Call the parent's constructor in renderers

15 years agoGrading report - columns sorting support
David Mudrak [Mon, 4 Jan 2010 18:13:04 +0000 (18:13 +0000)]
Grading report - columns sorting support

15 years agoUnit tests for workshop::aggregate_submission_grades_process()
David Mudrak [Mon, 4 Jan 2010 18:12:54 +0000 (18:12 +0000)]
Unit tests for workshop::aggregate_submission_grades_process()

15 years agoaggregate_submission_grades() refactoring to allow unit testing
David Mudrak [Mon, 4 Jan 2010 18:12:44 +0000 (18:12 +0000)]
aggregate_submission_grades() refactoring to allow unit testing

15 years agoImproved the workshop constructor to support unit testing
David Mudrak [Mon, 4 Jan 2010 18:12:32 +0000 (18:12 +0000)]
Improved the workshop constructor to support unit testing

Thanks to Tim Hunt for the hint.

15 years agoMDL-20264 work in progress on grading evaluation support
David Mudrak [Mon, 4 Jan 2010 18:12:12 +0000 (18:12 +0000)]
MDL-20264 work in progress on grading evaluation support

Also fixes small bugs in workshop api constructor and in using "scales"
instead of "scale" for the core table name.

15 years agoMDL-20058 Grading report, aggregation of submission grades
David Mudrak [Mon, 4 Jan 2010 18:11:48 +0000 (18:11 +0000)]
MDL-20058 Grading report, aggregation of submission grades

Not finished yet

15 years agoImproved context handling
David Mudrak [Mon, 4 Jan 2010 18:11:35 +0000 (18:11 +0000)]
Improved context handling

Getting a context from instance is very cheap and I can actually do it
just once when constructing the workshop API class. In the future, I
will get rid of all $PAGE->context which is actually meant for things
like blocks etc.

15 years agoAssessment weight DEFAULTs to 1
David Mudrak [Mon, 4 Jan 2010 18:11:22 +0000 (18:11 +0000)]
Assessment weight DEFAULTs to 1

15 years agoAdded an important documentation to a capability
David Mudrak [Mon, 4 Jan 2010 18:11:11 +0000 (18:11 +0000)]
Added an important documentation to a capability

15 years agoDisplay a button to run aggregation process
David Mudrak [Mon, 4 Jan 2010 18:11:02 +0000 (18:11 +0000)]
Display a button to run aggregation process

15 years agoAdded timeaggregated time stamp
David Mudrak [Mon, 4 Jan 2010 18:10:52 +0000 (18:10 +0000)]
Added timeaggregated time stamp

15 years agoAdded new helpfile (just for testing purposes)
David Mudrak [Mon, 4 Jan 2010 18:10:42 +0000 (18:10 +0000)]
Added new helpfile (just for testing purposes)

15 years agoWork in progress: grading report refactoring
David Mudrak [Mon, 4 Jan 2010 18:10:28 +0000 (18:10 +0000)]
Work in progress: grading report refactoring

15 years agoAdding percent_to_value() helper + its unittests
David Mudrak [Mon, 4 Jan 2010 18:10:18 +0000 (18:10 +0000)]
Adding percent_to_value() helper + its unittests

15 years agoFixed the id of the string from null to nullgrade
David Mudrak [Mon, 4 Jan 2010 18:10:08 +0000 (18:10 +0000)]
Fixed the id of the string from null to nullgrade

15 years agoPreparing for the future feature to let the user to set users per page
David Mudrak [Mon, 4 Jan 2010 18:09:58 +0000 (18:09 +0000)]
Preparing for the future feature to let the user to set users per page

15 years agoAdding new table workshop_aggregations
David Mudrak [Mon, 4 Jan 2010 18:09:48 +0000 (18:09 +0000)]
Adding new table workshop_aggregations

This table replaces the recently added workshop_evaluations and will
contain all grades aggregations done within a workshop activity. NULL
grades mean not aggregated yet.

15 years agoFixed an OUTPUT issue
David Mudrak [Mon, 4 Jan 2010 18:09:38 +0000 (18:09 +0000)]
Fixed an OUTPUT issue

15 years agoFixed a bug caused by incorrect comparison of float values
David Mudrak [Mon, 4 Jan 2010 18:09:28 +0000 (18:09 +0000)]
Fixed a bug caused by incorrect comparison of float values

15 years agoWorkshop planner tool now correctly counts the submissions and allocations
David Mudrak [Mon, 4 Jan 2010 18:09:18 +0000 (18:09 +0000)]
Workshop planner tool now correctly counts the submissions and allocations

15 years agoAllows to fake grading
David Mudrak [Mon, 4 Jan 2010 18:09:08 +0000 (18:09 +0000)]
Allows to fake grading

15 years agoMake sure we do not pass empty arrays to $DB->get_in_or_equal()
David Mudrak [Mon, 4 Jan 2010 18:08:58 +0000 (18:08 +0000)]
Make sure we do not pass empty arrays to $DB->get_in_or_equal()

15 years agoAdded a column to store the assessment weight
David Mudrak [Mon, 4 Jan 2010 18:08:48 +0000 (18:08 +0000)]
Added a column to store the assessment weight

15 years agoAllow submission attachments to be stored in subfolders
David Mudrak [Mon, 4 Jan 2010 18:08:38 +0000 (18:08 +0000)]
Allow submission attachments to be stored in subfolders

15 years agoMDL-20058 first prototype of the grading report renderer
David Mudrak [Mon, 4 Jan 2010 18:08:27 +0000 (18:08 +0000)]
MDL-20058 first prototype of the grading report renderer

15 years agoA lot of work here and there
David Mudrak [Mon, 4 Jan 2010 18:08:13 +0000 (18:08 +0000)]
A lot of work here and there

DB columns userid renamed to authorid or reviewerid to make the value
clear. Improved manual allocation UI. Raw grades are stored as numeric
values from 0.00000 to 100.00000 (instead of the current 0 to 1) to be
more precise. Started to work on the Grading report (it est the overall
report of all grades form submission and grades for assessments).

15 years agoAdded workshop_evaluations to store aggregated grades for assessments
David Mudrak [Mon, 4 Jan 2010 18:07:48 +0000 (18:07 +0000)]
Added workshop_evaluations to store aggregated grades for assessments

The gradinggrade can not be stored in workshop_submissions because
participants without their own submission can be reviewers, too.

15 years agoMDL-19717 workshop manual allocator - pagination support and performance issues
David Mudrak [Mon, 4 Jan 2010 18:07:38 +0000 (18:07 +0000)]
MDL-19717 workshop manual allocator - pagination support and performance issues

15 years agoScalability issues
David Mudrak [Mon, 4 Jan 2010 18:07:28 +0000 (18:07 +0000)]
Scalability issues

Did not display properly with dozens of users

15 years agoInstructions for reviewers work
David Mudrak [Mon, 4 Jan 2010 18:07:17 +0000 (18:07 +0000)]
Instructions for reviewers work

15 years agoConform the new interface requirments
David Mudrak [Mon, 4 Jan 2010 18:07:07 +0000 (18:07 +0000)]
Conform the new interface requirments

15 years agoAdded and re-sorted strings
David Mudrak [Mon, 4 Jan 2010 18:06:57 +0000 (18:06 +0000)]
Added and re-sorted strings

15 years agoFixed "Edit submission" button link
David Mudrak [Mon, 4 Jan 2010 18:06:47 +0000 (18:06 +0000)]
Fixed "Edit submission" button link

15 years agoFixed pluginfile support
David Mudrak [Mon, 4 Jan 2010 18:06:37 +0000 (18:06 +0000)]
Fixed pluginfile support

15 years agoAdded the skelet for grading evaluation subplugins
David Mudrak [Mon, 4 Jan 2010 18:06:26 +0000 (18:06 +0000)]
Added the skelet for grading evaluation subplugins

15 years agoMDL-20236 overall codebase architecture cleanup and fixing regression
David Mudrak [Mon, 4 Jan 2010 18:05:48 +0000 (18:05 +0000)]
MDL-20236 overall codebase architecture cleanup and fixing regression

See the issue description for more details

15 years agoAdded instructions for submitting
David Mudrak [Mon, 4 Jan 2010 18:02:27 +0000 (18:02 +0000)]
Added instructions for submitting

File API seems to be broken right now so I can't test properly. The new
mod/page code was re-used here.

15 years agoDisplays all assigned submissions to be reviewed and saves the calculated grade
David Mudrak [Mon, 4 Jan 2010 18:02:16 +0000 (18:02 +0000)]
Displays all assigned submissions to be reviewed and saves the calculated grade

15 years agoRefactoring some critical parts
David Mudrak [Mon, 4 Jan 2010 18:02:05 +0000 (18:02 +0000)]
Refactoring some critical parts

Critical issue fixed here: after recent refactorings, I called
get_users_with_capability() inside the loop in another loop! (oops :-)
This was used in my very first code using the renderers. I have learnt
I should follow the core approach (as suggested by Tim) to prepare a
data object and pass it to the renderer. The fact the renderer called
a workshop method indicated something was really wrong...

WIP

15 years agoGo workshop, go!
David Mudrak [Mon, 4 Jan 2010 18:01:50 +0000 (18:01 +0000)]
Go workshop, go!

15 years agoDisplays the list of submissions
David Mudrak [Mon, 4 Jan 2010 18:01:40 +0000 (18:01 +0000)]
Displays the list of submissions

15 years agoPhases can be switched from the Workshop plan tool
David Mudrak [Mon, 4 Jan 2010 18:01:29 +0000 (18:01 +0000)]
Phases can be switched from the Workshop plan tool

There may be more conditions checks written in the future and the
explanation added on what can be expected to happen after the phase
switch.

15 years agoUses tabs for all actions, removed temporary links
David Mudrak [Mon, 4 Jan 2010 18:01:15 +0000 (18:01 +0000)]
Uses tabs for all actions, removed temporary links

15 years agoMore work done on the Workshop Plan UI
David Mudrak [Mon, 4 Jan 2010 18:01:05 +0000 (18:01 +0000)]
More work done on the Workshop Plan UI

15 years agoMostly working on the view.php UI plus some changes
David Mudrak [Mon, 4 Jan 2010 18:00:54 +0000 (18:00 +0000)]
Mostly working on the view.php UI plus some changes