]>
git.mjollnir.org Git - moodle.git/log
martinlanghoff [Sun, 6 May 2007 05:37:28 +0000 (05:37 +0000)]
get_my_courses() - ensure we have groupmode, groupmodeforce in $d_fields - calendar/lib.php counts on it
martinlanghoff [Sun, 6 May 2007 05:32:40 +0000 (05:32 +0000)]
get_my_courses() callers update - check of the $fields param - pass null instead
The default way to call get_my_courses() is now to pass null in the $fields
param to get the (cached copy) of the useful fields. Cuts down enormously
on DB traffic, memory footprint, and session size.
martinlanghoff [Sun, 6 May 2007 05:28:39 +0000 (05:28 +0000)]
get_my_courses() - added optimisation for guest login
- was causing very slow page generation
martinlanghoff [Sun, 6 May 2007 05:27:31 +0000 (05:27 +0000)]
get_my_courses() - tighten default fields - faster, risky
This makes get_my_courses() faster/lighter in 2 ways
- We fetch a ton less data from the DB
- We store a tone less data in the Session
In a test environment, with a student enrolled in 3 _empty_ courses
(just created, empty modinfo, etc), this shaves 50% off the session
size on-disk.
The problem is callers that may be expecting a given field to appear by
default. Next step: walk all callers...
martinlanghoff [Sun, 6 May 2007 05:26:59 +0000 (05:26 +0000)]
get_my_courses() - skip checks if we know the user has moodle/site:doanything and we are observing $doanything
Author: Martin Langhoff <martin@catalyst.net.nz>
martinlanghoff [Sun, 6 May 2007 05:26:04 +0000 (05:26 +0000)]
get_my_courses(): tighten cache scheme - part 2
the tighter cache was fragile as we always edit $field
martinlanghoff [Sun, 6 May 2007 05:22:03 +0000 (05:22 +0000)]
get_my_courses(): tighten cache scheme
This tightens the rather lax caching mechanism that
cached regardless of parameters.
Thanks to Matt Clarkson for the heads-up...
moodler [Sun, 6 May 2007 04:50:49 +0000 (04:50 +0000)]
Automatic installer.php lang files by installer_builder (
20070506 )
martinlanghoff [Sun, 6 May 2007 04:38:24 +0000 (04:38 +0000)]
calendar: fixed group event display when only one course being viewed
Author: Matt Clarkson <mattc@catalyst.net.nz>
martinlanghoff [Sun, 6 May 2007 04:37:38 +0000 (04:37 +0000)]
calendar: bug fixed to previous commit (MDL-7416 MDL-9617)
Author: Matt Clarkson <mattc@catalyst.net.nz>
martinlanghoff [Sun, 6 May 2007 04:28:11 +0000 (04:28 +0000)]
calendar: performance optimisations + behaviour fix (MDL-7416 MDL-9617)
With 2500 courses the calendar was causing around 15000 queries at login and 5000 on the home page.
- Replaced queries inside loops with single unlooped queries.
- Fixed calendar so that course events will show when the users role is assigned at a category level.
- Moved calendar_session_vars() function call out of calendar/lib.php (including a lib should not have side effects)
Author: Matt Clarkson - with some conflict resolution from MartinL
poltawski [Sat, 5 May 2007 15:16:39 +0000 (15:16 +0000)]
Fixed MDL-9639 and syntax error, merged from 18_STABLE
thepurpleblob [Sat, 5 May 2007 14:44:12 +0000 (14:44 +0000)]
MDL-9675:
Default value added for 'answernumbering'. Default is 'abc'
ikawhero [Sat, 5 May 2007 07:43:08 +0000 (07:43 +0000)]
Call theme_setup() after change so new theme displays correctly
thepurpleblob [Fri, 4 May 2007 14:31:56 +0000 (14:31 +0000)]
Fixed hard coded string
thepurpleblob [Fri, 4 May 2007 14:10:56 +0000 (14:10 +0000)]
Fix a hard coded string
csantossaenz [Fri, 4 May 2007 12:27:49 +0000 (12:27 +0000)]
Made some changes on scorm_seq_overall
csantossaenz [Fri, 4 May 2007 11:17:15 +0000 (11:17 +0000)]
Fixed some problems with the variables stored in scorm_scoes_track and the last two functions have been commented and we are going to use scorm_seq_is() instead of them.
jamiesensei [Fri, 4 May 2007 10:46:33 +0000 (10:46 +0000)]
removed more session stuff from question list and category form in question bank display code
tjhunt [Fri, 4 May 2007 10:04:20 +0000 (10:04 +0000)]
Matching qestion type was failing to correctly determine wheterh the student had changed their answer - further improvements. Merged from MOODLE_18_STABLE.
nicolasconnault [Fri, 4 May 2007 09:04:40 +0000 (09:04 +0000)]
MDL-9506 Fixed some small issues.
jamiesensei [Fri, 4 May 2007 08:33:28 +0000 (08:33 +0000)]
tightening up reg expressions used for submitted data a bit
jgutierr25 [Fri, 4 May 2007 08:06:40 +0000 (08:06 +0000)]
patch for bug when you connect from authentication block on main page
csantossaenz [Fri, 4 May 2007 07:46:15 +0000 (07:46 +0000)]
Changed some data from scorm_scoes_track to scorm_scoes_data
nicolasconnault [Fri, 4 May 2007 07:40:51 +0000 (07:40 +0000)]
MDL-9506 Moved unit tests in a simpletest subfolder so they can be automatically grouped. Added grade_history and grade_text object and another heap of small implementations.
toyomoyo [Fri, 4 May 2007 07:35:54 +0000 (07:35 +0000)]
adding a missing feedbackformat field
jamiesensei [Fri, 4 May 2007 06:09:37 +0000 (06:09 +0000)]
removing TODO comment as the question.php script no longer treats quiz as special.
jamiesensei [Fri, 4 May 2007 05:51:59 +0000 (05:51 +0000)]
removed global var declaration for var that wasn't used in function
jamiesensei [Fri, 4 May 2007 05:47:59 +0000 (05:47 +0000)]
passing cmid to question.php and removed use of session modform var. Question.php now independent of quiz module. Small improvement to displayed breadcrumbs.
jamiesensei [Fri, 4 May 2007 05:45:33 +0000 (05:45 +0000)]
added a param to moodle_url constructor to provide params as an array just as a convenience to quickly construct a url with an array of params.
jamiesensei [Fri, 4 May 2007 05:30:03 +0000 (05:30 +0000)]
deleted redundant method which was just calling the parent method.
toyomoyo [Fri, 4 May 2007 05:25:49 +0000 (05:25 +0000)]
merged fix for MDL-9617, performance issues in calendar
gbateson [Fri, 4 May 2007 02:53:52 +0000 (02:53 +0000)]
remove duplicate id attribute from body tag; microincrement version to
2007040200 (release 2.4.2)
nicolasconnault [Fri, 4 May 2007 02:31:16 +0000 (02:31 +0000)]
MDL-9506 Reorganised the gradebook unit tests into more manageable classes.
toyomoyo [Fri, 4 May 2007 02:15:46 +0000 (02:15 +0000)]
MDL-9510, cron job support of legacy grade functions in modules. Implementation is not finished as the gradebook grade_added event is not complete
csantossaenz [Thu, 3 May 2007 12:55:22 +0000 (12:55 +0000)]
Added some functions for the Sequencing and Navigation task for SCOMR 2004 compliance. This is a work-in-progress file
csantossaenz [Thu, 3 May 2007 12:52:11 +0000 (12:52 +0000)]
Added auxiliar functions for sequencinglib.php
jamiesensei [Thu, 3 May 2007 10:38:35 +0000 (10:38 +0000)]
removed use of session for reordertool and show page breaks. Reordertool and show page breaks params are now passed from page request to page request only for page requests for quiz/edit.php
jamiesensei [Thu, 3 May 2007 10:10:01 +0000 (10:10 +0000)]
moved question sort order and paging params to be passed from page to page as get params instead of being saved in session var.
jamiesensei [Thu, 3 May 2007 10:03:59 +0000 (10:03 +0000)]
change to print_paging_bar function to optionally support the use of a moodle_url object as a parameter instead of a string.
small changes to moodle_url class
nicolasconnault [Thu, 3 May 2007 08:51:48 +0000 (08:51 +0000)]
MDL-9506 Added grade_outcome.php. Also added unit test for creation of log in history table when grade_raw is updated.
nicolasconnault [Thu, 3 May 2007 08:08:38 +0000 (08:08 +0000)]
MDL-9506 See previous revision. This adds same functionality but in relation to the hidden field.
nicolasconnault [Thu, 3 May 2007 08:02:51 +0000 (08:02 +0000)]
MDL-9506 Added grade_item::toggle_locking and unit tests. Affects all final grades if reqested.
ikawhero [Thu, 3 May 2007 07:39:27 +0000 (07:39 +0000)]
Config setting for the theme order priorities.
ikawhero [Thu, 3 May 2007 07:15:30 +0000 (07:15 +0000)]
New mimetype for Inspiration application.
Icon and code patch from Julian Ridden.
nicolasconnault [Thu, 3 May 2007 07:10:22 +0000 (07:10 +0000)]
MDL-9506 Upgraded grade_item::adjust_grade with Darlene's more elegant formula. Completed grade_category::get_children($depth, $arraytype). Added 4 constants to help that method. Added and passed all unit tests (111 now).
ikawhero [Thu, 3 May 2007 07:00:55 +0000 (07:00 +0000)]
GUI for category themes.
New language strings.
nicolasconnault [Thu, 3 May 2007 05:44:33 +0000 (05:44 +0000)]
MDL-9506 Removed childrentype after discussion with Martin D.
jamiesensei [Thu, 3 May 2007 05:17:07 +0000 (05:17 +0000)]
small fix to get question code to return to correct place after creating a new question.
jamiesensei [Thu, 3 May 2007 04:34:53 +0000 (04:34 +0000)]
MDL-9644 new class 'moodle_url' in weblib.php to handle constructing a url. It would internally stores params as an array and have methods to manipulate the array. The class can also output the params as hidden fields in a form or as a url with get params appended.
nicolasconnault [Thu, 3 May 2007 01:43:33 +0000 (01:43 +0000)]
MDL-9506 Added childrentype field to grade_categories table
gbateson [Thu, 3 May 2007 01:02:06 +0000 (01:02 +0000)]
set default body font-size to "small"
gbateson [Thu, 3 May 2007 00:22:50 +0000 (00:22 +0000)]
add HP 6.2 templates; add compatability with Safari (Mac browser); microincrement version to
2007020201 (release 2.4.1)
danmarsden [Thu, 3 May 2007 00:06:17 +0000 (00:06 +0000)]
MDL-8394 Allow students to remove their choice when they are allowed to update their choice. LANG file update.
danmarsden [Thu, 3 May 2007 00:04:53 +0000 (00:04 +0000)]
MDL-8394 Allow students to remove their choice when they are allowed to update their choice.
ikawhero [Wed, 2 May 2007 09:35:35 +0000 (09:35 +0000)]
1. Changes to allow different priorities in the theme selection based on
CFG->themeorder setting
2. Changes to allow category themes. Theme can now be set for a category
which will apply to all sub-categories (unless they specifically have a
theme set) and to child courses (course theme and $CFG->themeorder
settings permitting). New config setting $CFG->allowcategorythemes must
be set. Off by default as it means extra database calls.
There is an ugly hack to find out if we are viewing course/category.php -
anyone welcome to tidy this up if they have a better idea.
GUI for setting category theme coming.
poltawski [Wed, 2 May 2007 09:33:56 +0000 (09:33 +0000)]
MDL-9627 - moving uploaduser to formslib
nicolasconnault [Wed, 2 May 2007 07:20:13 +0000 (07:20 +0000)]
MDL-9506 Finished all unit test stubs, another batch to write soon. One one test fails because I haven't implemented recursive category hierarchy output yet, and not sure if it's needed. A grade_category already returns its immediate children, and that may be enough.
ikawhero [Wed, 2 May 2007 06:50:28 +0000 (06:50 +0000)]
New field for category themes
toyomoyo [Wed, 2 May 2007 06:30:54 +0000 (06:30 +0000)]
adding capabilities for gradebook, MDL-9511
poltawski [Tue, 1 May 2007 12:03:45 +0000 (12:03 +0000)]
MDL-9660 - Fixed groups matches functions and added unit tests for them..
toyomoyo [Tue, 1 May 2007 08:59:39 +0000 (08:59 +0000)]
modifications to eventslib
nicolasconnault [Tue, 1 May 2007 08:56:37 +0000 (08:56 +0000)]
MDL-9506 Implemented category path and depth, and wrote unit tests for them.
tjhunt [Tue, 1 May 2007 07:03:52 +0000 (07:03 +0000)]
Fix all the PHP syntax errors in this code. I can't think of any valid reason for checking code with that many syntax errors into CVS, especially when there are plenty of editors out there that check the syntax for you and highlight the errors.\r \r Also, can I point out that Moodle coding guidelines require spaces for indents, not tabs. (http://docs.moodle.org/en/Development:Coding)
skodak [Tue, 1 May 2007 06:55:03 +0000 (06:55 +0000)]
MDL-9654 enforced password strength ignored in chage password - patch by Iñaki Arenaza
nicolasconnault [Tue, 1 May 2007 05:47:10 +0000 (05:47 +0000)]
MDL-9506 Forgot to add the grade_scale.php file.
nicolasconnault [Tue, 1 May 2007 05:45:54 +0000 (05:45 +0000)]
MDL-9506 Finished grade_item::adjust_grade, which now also adjusts scale grades correctly. Added grade_scale object to wrap around the current non-normalized scale DB table. When/if we upgrade to grade_scales and grade_scale_items DB tables, changing the grade_scale class will be easy.
moodler [Tue, 1 May 2007 04:14:59 +0000 (04:14 +0000)]
Automatic installer.php lang files by installer_builder (
20070501 )
nicolasconnault [Tue, 1 May 2007 03:18:55 +0000 (03:18 +0000)]
MDL-9506 Implemented rescaling and grade adjustment formulas in grade_item::adjust_grade(). Also wrote unit tests.
andreabix [Mon, 30 Apr 2007 18:18:07 +0000 (18:18 +0000)]
Fixed Task MDL-9611
skodak [Mon, 30 Apr 2007 18:03:19 +0000 (18:03 +0000)]
MDL-9652 rename new password reveal to unmask
skodak [Mon, 30 Apr 2007 17:28:29 +0000 (17:28 +0000)]
MDL-9647 simplify dealing with headers/footers in admin sections; some more cleanup
fixed continue button in error() on admin page when link present
skodak [Mon, 30 Apr 2007 17:28:29 +0000 (17:28 +0000)]
MDL-9647 simplify dealing with headers/footers in admin sections; some more cleanup
fixed continue button in error() on admin page when link present
skodak [Mon, 30 Apr 2007 17:28:28 +0000 (17:28 +0000)]
MDL-9647 simplify dealing with headers/footers in admin sections; some more cleanup
fixed continue button in error() on admin page when link present
skodak [Mon, 30 Apr 2007 17:13:37 +0000 (17:13 +0000)]
MDL-9647 simplify dealing with headers/footers in admin sections; fixed double footers when using print_footer() in admin page
skodak [Mon, 30 Apr 2007 17:08:34 +0000 (17:08 +0000)]
MDL-9647 simplify dealing with headers/footers in admin sections
moodler [Mon, 30 Apr 2007 13:26:06 +0000 (13:26 +0000)]
Fixed discussions tab ... this is an old change I never checked in
anthonyforth [Mon, 30 Apr 2007 13:19:33 +0000 (13:19 +0000)]
Fix for bug 9646
csantossaenz [Mon, 30 Apr 2007 12:46:08 +0000 (12:46 +0000)]
Fixed some bugs about undefined variables and added some more functions. Still work-in-progress file
moodler [Mon, 30 Apr 2007 09:36:06 +0000 (09:36 +0000)]
SOme small changes from the meeting today
nicolasconnault [Mon, 30 Apr 2007 09:09:32 +0000 (09:09 +0000)]
MDL-9506 Lots more unit tests, and work on grade_item::update method and associated functionality. 3 unit tests currently fail, so more work needed.
toyomoyo [Mon, 30 Apr 2007 08:46:39 +0000 (08:46 +0000)]
events and grades db fixes
jamiesensei [Mon, 30 Apr 2007 06:48:57 +0000 (06:48 +0000)]
standardizing params for edit question page. All pages now use courseid instead of course or id.
nicolasconnault [Mon, 30 Apr 2007 05:25:19 +0000 (05:25 +0000)]
MLD-9506 Corrected update_final_grades() in grade_item, which was updating the grade_raw table
instead of grade_final. Made a few other adjustments.
nicolasconnault [Mon, 30 Apr 2007 05:00:17 +0000 (05:00 +0000)]
MDL-9506 Removed redundant portion of code.
nicolasconnault [Mon, 30 Apr 2007 04:49:25 +0000 (04:49 +0000)]
MDL-9506 Added grade_grades_raw as a proper object used by grade_item. Also added a global function in gradelib for updating grade_grades_raw objects.
donal72 [Mon, 30 Apr 2007 03:14:43 +0000 (03:14 +0000)]
MDL-8973 : Undo API change in previous commit
toyomoyo [Mon, 30 Apr 2007 02:56:46 +0000 (02:56 +0000)]
merged fix for MDL-9613
toyomoyo [Mon, 30 Apr 2007 02:06:48 +0000 (02:06 +0000)]
adding 2 fields back
nicolasconnault [Mon, 30 Apr 2007 02:05:51 +0000 (02:05 +0000)]
MDL-9506 Implemented get_raw and get_final, plus added method_exists() checks for each unit test.
martinlanghoff [Sun, 29 Apr 2007 20:31:47 +0000 (20:31 +0000)]
ddllib: Introducing create_temp_table()
Close sibling to create_table() - will create a temporary table.
Two aspects of its usage are interesting
- you _must_ truncate the table after creation as you may be
"inheriting" an existing temp table from the former user
of your persistent connection
- you must use the tablename returned to support MSSQL and any
other DB that needs special names for temp tables
A couple of TODOs
- I just don't know how to actually munge the tablename for MSSQL
(help! Eloooooyyyy!)
- Surely Eloy will have something better than the preg_replace() ;-)
donal72 [Sun, 29 Apr 2007 15:08:29 +0000 (15:08 +0000)]
Typo in previous commit: MDL-8973 : Update to the require_logout function
donal72 [Sun, 29 Apr 2007 15:01:47 +0000 (15:01 +0000)]
MDL-8973 : Update to the require_logout function to ensure that the user's auth plugin is the first (& only) one to have its prelogout_hook invoked.
donal72 [Sun, 29 Apr 2007 14:09:27 +0000 (14:09 +0000)]
MDL-9288 - use addslashes to avoid injection attacks on data imported vi mnet
donal72 [Sun, 29 Apr 2007 13:55:11 +0000 (13:55 +0000)]
Bugfix: The $this->response['faultCode'] was returning the 1th element of the $this->response string (because a non-empty string == 1).
donal72 [Sun, 29 Apr 2007 13:50:33 +0000 (13:50 +0000)]
Prevent notices on user creation
skodak [Sun, 29 Apr 2007 11:40:26 +0000 (11:40 +0000)]
MDL-9217 rearanged groups installation and upgrade - roles require groups; merged from MOODLE_18_STABLE
moodler [Sun, 29 Apr 2007 04:28:00 +0000 (04:28 +0000)]
Automatic installer.php lang files by installer_builder (
20070429 )
donal72 [Sun, 29 Apr 2007 00:51:29 +0000 (00:51 +0000)]
Add missing closing-bracket from previous commit
moodler [Sat, 28 Apr 2007 04:19:24 +0000 (04:19 +0000)]
Automatic installer.php lang files by installer_builder (
20070428 )