martinlanghoff [Wed, 19 Sep 2007 06:52:34 +0000 (06:52 +0000)]
accesslib:get_child_contexts() reworked to use context.path
Using context.path, now get_child_contexts...
- always takes 1 query
- populated the context_cache
- returns full records
- when called with an category, it won't
recurse into the children of courses
Also
- All callers in accesslib changed to the new
calling convention
A normal course page with a std blocks and a few
activities sees around 100 queries less with this patch.
Note: this commit is slightly different on HEAD/19 and on
MOODLE_18_STABLE, as groups-related tables have changed.
martinlanghoff [Wed, 19 Sep 2007 06:50:53 +0000 (06:50 +0000)]
accesslib: Introducing cleanup_contexts() and use it in cron
The newly minted cleanup_contexts() walks the context table
matching contexts with the tables they are referencing and
clearing any leftover contexts.
toyomoyo [Wed, 19 Sep 2007 03:48:44 +0000 (03:48 +0000)]
minor fix for count of users
toyomoyo [Wed, 19 Sep 2007 03:31:22 +0000 (03:31 +0000)]
MDL-11324, only display users with moodle:course/view capability when assinging in module context or lower
stronk7 [Tue, 18 Sep 2007 22:20:13 +0000 (22:20 +0000)]
Now assignment_submissions->data1 & data2 are nullable. MDL-11268
stronk7 [Tue, 18 Sep 2007 18:57:59 +0000 (18:57 +0000)]
Minor improvements to messages window for wood.
skodak [Tue, 18 Sep 2007 18:50:14 +0000 (18:50 +0000)]
MDL-1883 info for 3rd party developers in DEBUG_DEVELOPER mode
skodak [Tue, 18 Sep 2007 18:37:58 +0000 (18:37 +0000)]
MDL-1883 improved perf when editing scales - new function xxx_scale_used_anywhere()
stronk7 [Tue, 18 Sep 2007 18:24:52 +0000 (18:24 +0000)]
Fix some HTML in messages (wrong <a> and roundcorners support)
urs_hunkler [Tue, 18 Sep 2007 17:10:32 +0000 (17:10 +0000)]
enhancements for messages: remove header and footer with CSS. increase user top frame height via JavaScript to view the whole user image.
nicolasconnault [Tue, 18 Sep 2007 14:26:15 +0000 (14:26 +0000)]
MDL-11312 Added new grade_letters table, and new grade_items.display field.
thepurpleblob [Tue, 18 Sep 2007 12:30:19 +0000 (12:30 +0000)]
Typo!
Merged from STABLE_18
tjhunt [Tue, 18 Sep 2007 12:15:22 +0000 (12:15 +0000)]
MDL-11317 - Slashes displayed in incorrect responses for short answer questions. Fix by adding stripslashes in the appropriate place. Merged from MOODLE_18_STABLE.
jamiesensei [Tue, 18 Sep 2007 11:23:29 +0000 (11:23 +0000)]
moved question_make_default_categories function to questionlib.php since it is needed by other modules outside the question bank editing interface.
jamiesensei [Tue, 18 Sep 2007 09:35:44 +0000 (09:35 +0000)]
MDL-11318 formslib now respects a template for an element if it is set. But since formslib uses the templates to insert help buttons for setAdvanced functionality etc. if you use templates you will lose this functionality.
moodler [Tue, 18 Sep 2007 08:35:12 +0000 (08:35 +0000)]
The "alias" role names were not being used in the role assign screens. Now they are. MDL-11323
toyomoyo [Tue, 18 Sep 2007 07:14:37 +0000 (07:14 +0000)]
added a string for backup/restore
toyomoyo [Tue, 18 Sep 2007 07:00:57 +0000 (07:00 +0000)]
MDL-11234, if role definitions matches, restore role mapping should be allowed with or without role assign capabilities
moodler [Tue, 18 Sep 2007 04:21:57 +0000 (04:21 +0000)]
Automatic installer.php lang files by installer_builder (
20070918)
toyomoyo [Tue, 18 Sep 2007 04:03:02 +0000 (04:03 +0000)]
added needsupdate flag into backup/restore, added a new switch for restore on/off for grade histories, fixed some NULL related warnings
moodler [Tue, 18 Sep 2007 03:38:33 +0000 (03:38 +0000)]
iAdded a string for preview rows in exports
moodler [Tue, 18 Sep 2007 03:36:47 +0000 (03:36 +0000)]
Cleaned up the display of the export pages
moodler [Tue, 18 Sep 2007 03:24:28 +0000 (03:24 +0000)]
Some layout for the grades export download link / buttons
stronk7 [Mon, 17 Sep 2007 22:10:22 +0000 (22:10 +0000)]
Adding Id to file
stronk7 [Mon, 17 Sep 2007 21:58:55 +0000 (21:58 +0000)]
Added data_decode_content_links_caller() and data_decode_content_links()
to provide interlinking capabilities to restore. MDL-9576
iarenaza [Mon, 17 Sep 2007 21:30:20 +0000 (21:30 +0000)]
MDL-11299 - Make objectClass string comparison case insensitive.
LDAP serves accept attribute names in a case insensitive way, so don't
force the users to use any particular spelling.
stronk7 [Mon, 17 Sep 2007 17:59:54 +0000 (17:59 +0000)]
Adding data_encode_content_links() to backup, so data module
links are encoded to be transported in backup files. Part of MDL-11268.
diml [Mon, 17 Sep 2007 17:45:29 +0000 (17:45 +0000)]
mismatched code version in file.
nicolasconnault [Mon, 17 Sep 2007 17:39:35 +0000 (17:39 +0000)]
MDL-11282 Just displaying a simple notice, and continuing with the regrading.
nicolasconnault [Mon, 17 Sep 2007 17:32:20 +0000 (17:32 +0000)]
MDL-11275
nicolasconnault [Mon, 17 Sep 2007 17:31:48 +0000 (17:31 +0000)]
MDL-11275 added (submissions). Also fixed :
Issue:
Teachers can edit grader report preferences (including switches for quickgrading and
quickfeedback), but do not have access to the "Turn editing on/off" button, so they
can't do quickgrading.
Solutions:
1.Decouple the quickgrading and quickfeedback modes from the editing mode,
and turn them on/off through the preferences page. New capability: moodle/grade:edit
* preferences: don't show quickgrading if no capability grade:edit
* If quickgrading is switched off as a preference and user doesn't have manage cap, show edit icons around grades when in editing mode
tjhunt [Mon, 17 Sep 2007 16:17:24 +0000 (16:17 +0000)]
MDL-11267 - Anywone who can view quiz reports can delete student attempts. Merged from MOODLE_18_STABLE.
moodler [Mon, 17 Sep 2007 15:32:24 +0000 (15:32 +0000)]
Fixing a string I thought I fixed before ...
tjhunt [Mon, 17 Sep 2007 14:39:52 +0000 (14:39 +0000)]
MDL-11310 - Multichoice edititing form should have space for 5 answers by default. Merged from MOODLE_18_STABLE.
thepurpleblob [Mon, 17 Sep 2007 12:37:51 +0000 (12:37 +0000)]
MDL-11104
Markdown updated to latest version.
thepurpleblob [Mon, 17 Sep 2007 12:30:22 +0000 (12:30 +0000)]
MDL-11104:
Added some extra information for markdown-extra features.
Merged from STABLE_18
thepurpleblob [Mon, 17 Sep 2007 11:01:53 +0000 (11:01 +0000)]
Forgot to take out duplicate question count check.
Merged from STABLE_18
thepurpleblob [Mon, 17 Sep 2007 10:57:49 +0000 (10:57 +0000)]
MDL-11279:
Code was not properly checking for empty category.
Check moved to right place and proper print_error() function called as appropriate
Merged from STABLE_18
toyomoyo [Mon, 17 Sep 2007 06:53:24 +0000 (06:53 +0000)]
MDL-11084, "s in grade comments causes problems
moodler [Mon, 17 Sep 2007 05:39:20 +0000 (05:39 +0000)]
FIxed wierd blue line in forum posts
moodler [Mon, 17 Sep 2007 04:54:36 +0000 (04:54 +0000)]
Automatic installer.php lang files by installer_builder (
20070917)
toyomoyo [Mon, 17 Sep 2007 04:25:51 +0000 (04:25 +0000)]
MDL-11276, average calculations are inaccurate in percentage form due to double rounding
moodler [Mon, 17 Sep 2007 04:25:38 +0000 (04:25 +0000)]
Fixed popup window call (eg from email)
toyomoyo [Mon, 17 Sep 2007 02:15:51 +0000 (02:15 +0000)]
removing extra number_format(), format_float() already calls number_format()
skodak [Sun, 16 Sep 2007 21:48:47 +0000 (21:48 +0000)]
MDL-10820 Fixed double quotes in SQL statements
skodak [Sun, 16 Sep 2007 21:43:08 +0000 (21:43 +0000)]
MDL-11230 fixing wrong include for tags library - always use require_once() instead of include() when dealing with library files!
skodak [Sun, 16 Sep 2007 21:37:28 +0000 (21:37 +0000)]
MDL-11046 multiple tag/edit.php issues - see bug report
skodak [Sun, 16 Sep 2007 21:24:13 +0000 (21:24 +0000)]
MDL-11301 tag autocomplete on edit page works again
stronk7 [Sun, 16 Sep 2007 21:06:56 +0000 (21:06 +0000)]
Delete one unused table when grading online assignment submissions.
stronk7 [Sun, 16 Sep 2007 21:06:01 +0000 (21:06 +0000)]
Stylise online assignment word count.
skodak [Sun, 16 Sep 2007 20:19:19 +0000 (20:19 +0000)]
MDL-11300
1/ potential sql injection through tag types - missing param type + can add new types + usually no addslashes before update of tags
2/ paging does not work at all
3/ missing param type definitions
4/ not xhtml strict compliant
5/ CSRF - missing sesskey checks
6/ UI code in tag/lib.php - should be in manage.php or other file
7/ missing localization of types - default/standard
stronk7 [Sun, 16 Sep 2007 20:13:30 +0000 (20:13 +0000)]
Fixing assignment submission visualization for wood.
skodak [Sun, 16 Sep 2007 19:31:56 +0000 (19:31 +0000)]
MDL-11297 adding new PARAM_TAG - numeric tags not allowed
stronk7 [Sun, 16 Sep 2007 19:26:13 +0000 (19:26 +0000)]
Hide the metacourse dropdown menu if the course
isn't a metacourse and general XHTML compliance. MDL-9922
Merged from MOODLE_18_STABLE
skodak [Sun, 16 Sep 2007 18:54:11 +0000 (18:54 +0000)]
fixed undefined notice
skodak [Sun, 16 Sep 2007 18:49:41 +0000 (18:49 +0000)]
MDL-11298 use textlib_get_instance() instead of new textlib()
skodak [Sun, 16 Sep 2007 18:41:57 +0000 (18:41 +0000)]
MDL-11048 + MDL-11297 improved tag normalisation, more security
stronk7 [Sun, 16 Sep 2007 18:34:22 +0000 (18:34 +0000)]
Prevent some warning when restoring site courses... MDL-10054 MDL-10118
Merged from MOODLE_18_STABLE
stronk7 [Sun, 16 Sep 2007 17:34:54 +0000 (17:34 +0000)]
Show the roll dates option only if the backup course has a start date
(some formats like main page, social..., haven't it and rolling dates
from 0 produces crazy dates. MDL-10125
Merged from MOODLE_18_STABLE
skodak [Sun, 16 Sep 2007 14:20:32 +0000 (14:20 +0000)]
MDL-11297 adding new PARAM_TAG and PARAM_TAGLIST that are needed for blog and interest tags
skodak [Sun, 16 Sep 2007 11:45:30 +0000 (11:45 +0000)]
MDL-11048 adding new method to textlib strtotitle() - please note that is may not be usable in all locales, it might also produce different results when mbstring available
skodak [Sun, 16 Sep 2007 09:39:03 +0000 (09:39 +0000)]
improved accessibility of user edit page - adding help icons, removing incorrect static help from interest, improving interests strings
skodak [Sun, 16 Sep 2007 09:27:00 +0000 (09:27 +0000)]
fixed incorrect coding style {}
skodak [Sun, 16 Sep 2007 09:25:35 +0000 (09:25 +0000)]
fixed warning - must initialise objects properly
skodak [Sun, 16 Sep 2007 09:21:29 +0000 (09:21 +0000)]
MDL-9574 + MDL-9607 fixed undefined $user->id in personal context
stronk7 [Sun, 16 Sep 2007 08:30:19 +0000 (08:30 +0000)]
Fixed wrong link to log report. Shouldn't these links be in php
code instead of lang files? MDL-11281
Merged from MOODLE_18_STABLE
moodler [Sun, 16 Sep 2007 04:12:52 +0000 (04:12 +0000)]
Automatic installer.php lang files by installer_builder (
20070916)
iarenaza [Sat, 15 Sep 2007 21:38:13 +0000 (21:38 +0000)]
Remove additional check when dealing with hidden courses in LDAP enrolment.
The check is superfluous and uses an inexistant variable ($type) that
was removed when we switched to role based enrolment.
Fixes MDL-11098 MDL-10282 and MDL-8346.
skodak [Sat, 15 Sep 2007 21:17:11 +0000 (21:17 +0000)]
MDL-11296 fixed incorrect detection of duplicate scales in course
skodak [Sat, 15 Sep 2007 19:43:01 +0000 (19:43 +0000)]
applying the same patch to advcheckbox - Fixes MDL-8627, "HTML QuickForm displays (some?) disabled elements in a non-accessible way", overrides parent::getFrozenHtml.
skodak [Sat, 15 Sep 2007 19:36:31 +0000 (19:36 +0000)]
MDL-11295 editorshortcutshelpbutton breaking xhtml strict
skodak [Sat, 15 Sep 2007 19:24:10 +0000 (19:24 +0000)]
MDL-9542 new function needed for showing of final grades in Quiz + minor changes in grading public API used by modules
skodak [Sat, 15 Sep 2007 13:23:28 +0000 (13:23 +0000)]
fixed wrong $options - this->keepdrop_options used instead
skodak [Sat, 15 Sep 2007 09:42:24 +0000 (09:42 +0000)]
MDL-10277 Force password change cannot be unchecked once selected
skodak [Sat, 15 Sep 2007 09:29:58 +0000 (09:29 +0000)]
MDL-11292 fixed Cannot create child auth plugins - patch by Mark Nielsen; used inlude_once() when searching for functions/methods in files
nicolasconnault [Fri, 14 Sep 2007 19:32:50 +0000 (19:32 +0000)]
MDL-11282 Using notice_yesno(), but not sure how to provide a backlink with the cancel action...
nicolasconnault [Fri, 14 Sep 2007 17:21:30 +0000 (17:21 +0000)]
MDL-11278 Implementation is complete, but grade_categories records in DB are not affected by global settings. This way, when global settings are switched back to "Do not Force", the original category settings will be in place.
nicolasconnault [Fri, 14 Sep 2007 10:40:49 +0000 (10:40 +0000)]
MDL-11278 Admin settings page completed, implementation of settings in the gradebook coming up next.
tjhunt [Fri, 14 Sep 2007 09:42:53 +0000 (09:42 +0000)]
MDL-11271 - The closing bracket "}" can't be used in cloze question type. Now, you can excape a closing } with a backslash. Do feedback, as well as answer. Merged from MOODLE_18_STABLE.
tjhunt [Fri, 14 Sep 2007 09:34:52 +0000 (09:34 +0000)]
MDL-11271 - The closing bracket "}" can't be used in cloze question type. Now, you can excape a closing } with a backslash. Merged from MOODLE_18_STABLE.
tjhunt [Fri, 14 Sep 2007 09:33:30 +0000 (09:33 +0000)]
MDL-11284 - Can't save edited questions
nicolasconnault [Fri, 14 Sep 2007 08:54:46 +0000 (08:54 +0000)]
MDL-11278 Admin settings page completed, implementation of settings in the gradebook coming up next.
toyomoyo [Fri, 14 Sep 2007 08:43:10 +0000 (08:43 +0000)]
MDL-11274, hide grades in the grader report if the current grades has no viewhidden capability
nicolasconnault [Fri, 14 Sep 2007 06:57:30 +0000 (06:57 +0000)]
Issue:
The number of submissions in the Group average and Course average calculations
should be shown in brackets. (submissions) should be added after the Group average
and Course average labels.
Solution:
new grader report preference (Display number of grades in average cells).
moodler [Fri, 14 Sep 2007 06:51:57 +0000 (06:51 +0000)]
Fix the location of the link to the site-wide grading preferences
moodler [Fri, 14 Sep 2007 05:45:38 +0000 (05:45 +0000)]
Changing string for Overall average (was logged under MDL-11233 even though that's not strictly the correct bug)
stronk7 [Thu, 13 Sep 2007 17:51:48 +0000 (17:51 +0000)]
Now using one cross-db solution to be able to
simulate the status boolean ins assignment
submissions. MDL-8164 & MDL-10846
tjhunt [Thu, 13 Sep 2007 17:29:08 +0000 (17:29 +0000)]
MDL-11081 and MDL-11211 - Implement quiz_question_list_instances. The lach of this function was causing a horrible dataloss bug: MDL-11211. Fix thanks to Janne Mikkonen, refined by me. Merged from MOODLE_16_STABLE.
tjhunt [Thu, 13 Sep 2007 16:25:00 +0000 (16:25 +0000)]
MDL-11213 - Quiz preview attempts show up in item analysis. Fix thanks to Jean-Michel Vedrine. Merged from MOODLE_18_STABLE.
nicolasconnault [Thu, 13 Sep 2007 15:11:16 +0000 (15:11 +0000)]
Issue:
Only students should appear in the tutor report, however
sorting by Surname results in the tutor being included, which we don't want.
Solution:
Confirmed as a bug and filed in tracker: http://tracker.moodle.org/browse/MDL-11233
Issue:
Clicking on Hide Groups reveals the results for all students
and all tutors and course staff appear. A tutor should only be able to see
the results for their tutor group
Solution:
Prevent tutors from ever seeing student grades from other groups: use existing capabilities
moodle/site:accessallgroups = off AND moodle/grade:viewall = on
Issue:
Preferences tab should not be available to users without gradereport/grader:manage capability
Solution:
Hide the tab completely
Issue:
Apply different style to average cells
Solution:
Add css classes to the different average cells, and write a default style in css file.
Issue:
The Average under group average might be better labelled Course average.
Solution:
Rename to "Complete average"
nicolasconnault [Thu, 13 Sep 2007 13:44:35 +0000 (13:44 +0000)]
MDL-11233 Corrected typo in grader report lib, and added a second sort parameter for lastname and firstname sorts, to add consistency to result sets. Non-students no longer appear in the list
tjhunt [Thu, 13 Sep 2007 10:47:05 +0000 (10:47 +0000)]
MDL-11231 - Missing "correct" tick in Close question with answer '0'. Merged from MOODLE_18_STABLE.
nfreear [Thu, 13 Sep 2007 09:13:00 +0000 (09:13 +0000)]
MDL-11160, Cron exhausts memory on "Removing expired enrolments ..." - changing nested foreach to JOINs with while(..rs_fetch_next_record).
moodler [Thu, 13 Sep 2007 08:59:31 +0000 (08:59 +0000)]
Added Zoomspider as allowed to enter when opentogoogle is open
moodler [Thu, 13 Sep 2007 06:42:49 +0000 (06:42 +0000)]
Patch as suggested by Eloy in MDL-11237 to work around a nasty PHP bug in PHP 5.20
nicolasconnault [Thu, 13 Sep 2007 04:02:55 +0000 (04:02 +0000)]
MDL-11238 Removed reference to $grade_grade->feedback and replaced with grade_grade_text->feedback. Also instantiated the $grade_grade object properly instead of just get_record(), so that its set_hidden() method could be accessible.
diml [Wed, 12 Sep 2007 21:23:55 +0000 (21:23 +0000)]
changes reindexing strategy : deletes records rather than create back table
search db model transfered to block_search. No db model needed here.
diml [Wed, 12 Sep 2007 21:22:15 +0000 (21:22 +0000)]
changes reindexing strategy : deletes records rather than create back table
checkDB() and checkTableExists() in indexlib.php are obsolete
table name synced with search block install.xml table name
nicolasconnault [Wed, 12 Sep 2007 15:02:06 +0000 (15:02 +0000)]
Replacing the capability gradereport/grader:manage with moodle/grade:manage
nfreear [Wed, 12 Sep 2007 11:17:35 +0000 (11:17 +0000)]
Fixes MDL-8627, "HTML QuickForm displays (some?) disabled elements in a non-accessible way", overrides parent::getFrozenHtml.