moodlerobot [Thu, 16 Jul 2009 00:38:53 +0000 (00:38 +0000)]
Updated the HEAD build version to
20090716
sam_marshall [Wed, 15 Jul 2009 14:19:24 +0000 (14:19 +0000)]
MDL-19827: Completioninfo bugfix
tjhunt [Wed, 15 Jul 2009 08:59:51 +0000 (08:59 +0000)]
Fix boilerplate.
tjhunt [Wed, 15 Jul 2009 08:55:52 +0000 (08:55 +0000)]
blocks editing ui: MDL-19398 Remove stupid pass by reference.
Was causing errors when this method was called via block_method_result
tjhunt [Wed, 15 Jul 2009 08:52:33 +0000 (08:52 +0000)]
blocks editing ui: MDL-19398 Make block config_global.html files more strongly deprecated.
tjhunt [Wed, 15 Jul 2009 08:24:12 +0000 (08:24 +0000)]
blocks editing ui: MDL-19398 block.multiple column no longer exists, so remove admin for it.
skodak [Wed, 15 Jul 2009 08:11:28 +0000 (08:11 +0000)]
MDL-19785 temp fix for undefined completioninfo
tjhunt [Wed, 15 Jul 2009 07:45:48 +0000 (07:45 +0000)]
blocks editing ui: MDL-19398 Make invisible blocks at least partly invisible.
tjhunt [Wed, 15 Jul 2009 07:41:25 +0000 (07:41 +0000)]
blocks editing ui: MDL-19398 showing and hiding blocks now works.
tjhunt [Wed, 15 Jul 2009 06:33:13 +0000 (06:33 +0000)]
blocks editing ui: MDL-19398 give users a path back after assigning block roles
tjhunt [Wed, 15 Jul 2009 06:17:39 +0000 (06:17 +0000)]
moodlellib: MDL-19828 PARAM_LOCALURL should accept URLs like course/view.php?id=2
jerome [Wed, 15 Jul 2009 06:11:55 +0000 (06:11 +0000)]
moodle_page: MDL-12212 misspelling
tjhunt [Wed, 15 Jul 2009 05:40:15 +0000 (05:40 +0000)]
filters admin: Re-fix heading.
tjhunt [Wed, 15 Jul 2009 05:37:31 +0000 (05:37 +0000)]
outputlib tables: MDL-19755 fix all cases of deprecated $table->rowclass
Also fix wrong title on Manage filters admin page.
tjhunt [Wed, 15 Jul 2009 04:06:03 +0000 (04:06 +0000)]
question bank: MDL-19826 Merge from MOODLE_19_STABLE.
tjhunt [Wed, 15 Jul 2009 04:05:05 +0000 (04:05 +0000)]
weblib: Let redirect() take a moodle_url object.
nicolasconnault [Wed, 15 Jul 2009 02:54:40 +0000 (02:54 +0000)]
MDL-19808 Upgraded view.php to new pagelib and outputlib APIs
Moodle HQ git importer [Wed, 15 Jul 2009 00:37:05 +0000 (00:37 +0000)]
Fix CVS drift
moodlerobot [Wed, 15 Jul 2009 00:37:05 +0000 (00:37 +0000)]
Updated the HEAD build version to
20090715
sam_marshall [Tue, 14 Jul 2009 14:00:34 +0000 (14:00 +0000)]
MDL-19692: Completion tracking help icon enhancements
tjhunt [Tue, 14 Jul 2009 11:16:21 +0000 (11:16 +0000)]
blocks editing ui: MDL-19398 permissions checks when deleting a block.
tjhunt [Tue, 14 Jul 2009 10:57:06 +0000 (10:57 +0000)]
blocks editing ui: MDL-19398 move generating the block edit icons to blocklib.php
Since that is where the resulting actions are processed.
tjhunt [Tue, 14 Jul 2009 10:41:59 +0000 (10:41 +0000)]
blocks editing ui: MDL-19398 fix adding a block to a page that forgets to call $PAGE->set_url.
tjhunt [Tue, 14 Jul 2009 09:36:02 +0000 (09:36 +0000)]
forum: $PAGE->set_url on forum view page.
tjhunt [Tue, 14 Jul 2009 09:35:33 +0000 (09:35 +0000)]
fix typo
tjhunt [Tue, 14 Jul 2009 09:28:10 +0000 (09:28 +0000)]
blocks editing ui: MDL-19398 fix some bugs with adding a block.
tjhunt [Tue, 14 Jul 2009 08:37:28 +0000 (08:37 +0000)]
blocks editing ui: MDL-19398 add block now secure. Delete block works insecurely.
Will add security checks in a moment.
tjhunt [Tue, 14 Jul 2009 08:36:40 +0000 (08:36 +0000)]
blocks: MDL-19010 Delete weird line of legacy code.
tjhunt [Tue, 14 Jul 2009 08:31:30 +0000 (08:31 +0000)]
setuplib: early errors were not showing debuginfo.
skodak [Tue, 14 Jul 2009 08:26:45 +0000 (08:26 +0000)]
MDL-16075 fixed incomplete conversion of glossary comments
skodak [Tue, 14 Jul 2009 08:25:51 +0000 (08:25 +0000)]
MDL-14589 fixed incorrect condition testing if files allowed when postprocessing editor element data, thanks Nicolas for reporting this
tjhunt [Tue, 14 Jul 2009 07:18:57 +0000 (07:18 +0000)]
blocks editing ui: MDL-19398 you can now add new blocks!
tjhunt [Tue, 14 Jul 2009 07:06:06 +0000 (07:06 +0000)]
blocks: MDL-19010 show empty blocks if they have controls.
skodak [Tue, 14 Jul 2009 06:33:34 +0000 (06:33 +0000)]
MDL-16089 new general page type needed for framed resources, this is not accessible but unfortunately it works much better than object embedding; it will be also used by phpmyadmin integration
tjhunt [Tue, 14 Jul 2009 05:14:45 +0000 (05:14 +0000)]
themes: MDL-19077 Don't need both output_starting_hook and starting_output method on page.
tjhunt [Tue, 14 Jul 2009 04:18:58 +0000 (04:18 +0000)]
Fix block manager unit tests.
moodlerobot [Tue, 14 Jul 2009 00:38:40 +0000 (00:38 +0000)]
Updated the HEAD build version to
20090714
skodak [Mon, 13 Jul 2009 20:33:56 +0000 (20:33 +0000)]
MDL-19755 fixed regression - no class test must be done before adding allign classes ;-)
mudrd8mz [Mon, 13 Jul 2009 11:10:30 +0000 (11:10 +0000)]
MDL-19755 print_table replaced with $OUTPUT->table
rowclass property has been deprecated, rowclasses should be used.
Direct assigning of the class has been deprecated,
moodle_html_elements::set_classes() should be used instead. In both
cases, debugging message is displayed.
tjhunt [Mon, 13 Jul 2009 08:37:34 +0000 (08:37 +0000)]
block contexts: MDL-19098 every block should have a context
even non-course and sticky blocks.
The parent context is block_instances.parentcontextid.
The block context should be used for checking permissions directly
related to the block, like moodle/block:view or moodle/site:manageblocks.
However, if the block is displaying information about the current page,
for example the participants block showing who 'here', then it may be
better to use the context of the page where the bloack is appearing -
in other words $this->page->context - to check permissions about the
user's ability to see participants here.
Or, if the block is displaying something stronly related to courses,
for example, a course meny block, the block should probably use the
context for $this->page->course to check permissions.
tjhunt [Mon, 13 Jul 2009 06:16:48 +0000 (06:16 +0000)]
themes: MDL-19077 Don't us $OUTPUT in debugging.
tjhunt [Mon, 13 Jul 2009 06:10:03 +0000 (06:10 +0000)]
themes: MDL-19077 fix bugs in cli_renderer. Use correct doctype with legacy header.html.
tjhunt [Mon, 13 Jul 2009 06:08:48 +0000 (06:08 +0000)]
cron: MDL-19774 temporary hack so cron does not crash.
tjhunt [Mon, 13 Jul 2009 05:44:35 +0000 (05:44 +0000)]
feedback MDL-19773 - temporary work-around so cron can run.
This still needs to be fixed properly.
tjhunt [Mon, 13 Jul 2009 04:27:05 +0000 (04:27 +0000)]
developer tools MDL-19772: Script to list all todos in code
And make sure they link to an open tracker issue as per
http://docs.moodle.org/en/Development:Coding_style#TODO_comments_must_link_to_a_tracker_issue
tjhunt [Mon, 13 Jul 2009 04:24:29 +0000 (04:24 +0000)]
themes: MDL-19077 $OUTPUT->header does the main skip destination, layout.php should now.
tjhunt [Mon, 13 Jul 2009 04:23:39 +0000 (04:23 +0000)]
anomaly theme: XHTML strict.
tjhunt [Mon, 13 Jul 2009 04:21:15 +0000 (04:21 +0000)]
themes: MDL-19077 - Incorrect initialisation order for user/editadvanced.php
moodlerobot [Mon, 13 Jul 2009 00:38:07 +0000 (00:38 +0000)]
Updated the HEAD build version to
20090713
moodlerobot [Mon, 13 Jul 2009 00:27:41 +0000 (00:27 +0000)]
Automatic installer.php lang files by installer_builder (
20090713)
moodlerobot [Sun, 12 Jul 2009 00:37:38 +0000 (00:37 +0000)]
Updated the HEAD build version to
20090712
moodlerobot [Sat, 11 Jul 2009 00:37:27 +0000 (00:37 +0000)]
Updated the HEAD build version to
20090711
tjhunt [Fri, 10 Jul 2009 08:44:01 +0000 (08:44 +0000)]
upgrade: MDL-19763 Improve the redirect that forces a DB upgrade when there are major changes
Also fix redirect, so 303 redirects don't need to fully initialise $OUTPUT.
samhemelryk [Fri, 10 Jul 2009 08:08:17 +0000 (08:08 +0000)]
weblib MDL-19750 Fixed regression caused by implementing new PAGE methods
skodak [Fri, 10 Jul 2009 08:08:00 +0000 (08:08 +0000)]
MDL-19010 fixed redirect at login page if upgrade required, otherwise it would end with exception due to DB structure changes
skodak [Fri, 10 Jul 2009 08:03:06 +0000 (08:03 +0000)]
MDL-19010 fixed redirect at main page if upgrade required, otherwise it would end with exception due to DB structure changes
jerome [Fri, 10 Jul 2009 07:08:12 +0000 (07:08 +0000)]
output MDL-19077 typo bug on $debugdisableredirect
tjhunt [Fri, 10 Jul 2009 05:58:59 +0000 (05:58 +0000)]
blocks MDL-19536: rename block_instances.contextid to parentcontextid to avoid gross confusion
tjhunt [Fri, 10 Jul 2009 05:42:54 +0000 (05:42 +0000)]
Clarify comment.
tjhunt [Fri, 10 Jul 2009 05:37:36 +0000 (05:37 +0000)]
Remove unnecessary 'none' passed to footer.
tjhunt [Fri, 10 Jul 2009 03:39:09 +0000 (03:39 +0000)]
Fix comment.
tjhunt [Fri, 10 Jul 2009 03:31:30 +0000 (03:31 +0000)]
setup: Need memory before setup_DB.
!This is the correct version of the previous commit!
I was getting an interesting failure with $CFG->prefix commented
out in config.php (by mistake!). Abbreviated stack trace
lib/setup.php -> setup_DB -> dml_exception('prefixcannotbeempty') ->
get_string -> string_manager->__construct -> get_plugin_types
That loads lib.php from every module, which runs out of memeory.
tjhunt [Fri, 10 Jul 2009 03:30:43 +0000 (03:30 +0000)]
setup: Need memory before setup_DB.
I was getting an interesting failure with $CFG->prefix commented
out in config.php (by mistake!). Abbreviated stack trace
lib/setup.php -> setup_DB -> dml_exception('prefixcannotbeempty') ->
get_string -> string_manager->__construct -> get_plugin_types
That loads lib.php from every module, which runs out of memeory.
moodlerobot [Fri, 10 Jul 2009 00:37:20 +0000 (00:37 +0000)]
Updated the HEAD build version to
20090710
skodak [Thu, 9 Jul 2009 20:17:41 +0000 (20:17 +0000)]
MDL-16630 do not show admin tree until the site is fully configured
skodak [Thu, 9 Jul 2009 20:07:51 +0000 (20:07 +0000)]
removed php closing tag
skodak [Thu, 9 Jul 2009 20:02:27 +0000 (20:02 +0000)]
fixed obsolete readme info
skodak [Thu, 9 Jul 2009 19:58:29 +0000 (19:58 +0000)]
fixed whitespace and added TODO for release
skodak [Thu, 9 Jul 2009 19:54:54 +0000 (19:54 +0000)]
fixed whitespace
skodak [Thu, 9 Jul 2009 19:14:31 +0000 (19:14 +0000)]
MDL-16706 fix of fix that was supposed to fix previous regression
skodak [Thu, 9 Jul 2009 16:33:58 +0000 (16:33 +0000)]
MDL-16706 fix of previous fix - multiple editors in one form shoudl work again
tjhunt [Thu, 9 Jul 2009 09:09:37 +0000 (09:09 +0000)]
themes & blocks - MDL-19077 & MDL-19010 missing lang file changes.
tjhunt [Thu, 9 Jul 2009 08:17:23 +0000 (08:17 +0000)]
blocks - MDL-19010 fix bug where blocks did not show up with editing off.
tjhunt [Thu, 9 Jul 2009 07:35:03 +0000 (07:35 +0000)]
themes & blocks - MDL-19077 & MDL-19010 blocks are now printed by the theme
The code to print blocks in now in theme layout.php files. (Or in
moodle_core_renderer::handle_legacy_theme)
Code for printing blocks everywhere else has been stripped out.
(Total diffstat 1225 insertions, 2019 deletions)
The way the HTML for a block instance is generated has been cleaned
up a lot. Now, the block_instance generates a block_contents
object which gives a structured representation of the block,
and then $OUTPUT->block builds all the HTML from that.
How theme config.php files specify the layout template and block
regions by page general type has been changed to be even more flexible.
Further refinement for how the theme and block code gets initialised.
Ability for scrits to add 'pretend blocks' to the page. That is,
things that look like blocks, but are not normal block_instances.
(Like the add a new block UI.)
Things that are still broken:
* some pages in lesson, quiz and resource. I'm working on it.
* lots of developer debug notices pointing out things that
need to be updated.
dongsheng [Thu, 9 Jul 2009 07:17:18 +0000 (07:17 +0000)]
"MDL-13766, use OUTPUT to print box"
tjhunt [Thu, 9 Jul 2009 02:06:22 +0000 (02:06 +0000)]
themes MDL-19077: Update deprecated stuff in all theme config.php files.
moodlerobot [Thu, 9 Jul 2009 01:44:46 +0000 (01:44 +0000)]
Updated the HEAD build version to
20090709
mudrd8mz [Wed, 8 Jul 2009 09:37:06 +0000 (09:37 +0000)]
MDL-19731 get_renderer() accepts optional subtype
The initial patch has been reviewed at the issue page. This commit also
fixes template_renderer_factory::get_renderer() and sets up folders for
subtypes there.
samhemelryk [Wed, 8 Jul 2009 09:01:20 +0000 (09:01 +0000)]
outputlib MDL-19740 Fixed up outputlib focus handling to deal with the three different ways of requesting focus.
dongsheng [Wed, 8 Jul 2009 07:45:51 +0000 (07:45 +0000)]
"MDL-19733, directory name need to be cleaned before saving into database"
samhemelryk [Wed, 8 Jul 2009 04:12:11 +0000 (04:12 +0000)]
javascript-UFO MDL-19738 Stopped ufo.js being included in outputlib and included it in each place it was actually being used.
It will no only be loaded when it is being used. If something new comes along they will need to remember to require it.
At the same time cleaned up a few deprecated calls
samhemelryk [Wed, 8 Jul 2009 03:27:27 +0000 (03:27 +0000)]
lib MDL-19739 Moved call to include dropdown.js out of outputlib and into the same body of code in weblib
that uses it.
This ensures that it is only loaded if it is used, which is only is the browser is opera, or IE
samhemelryk [Wed, 8 Jul 2009 01:56:15 +0000 (01:56 +0000)]
ajaxlib MDL-19690 Fixed minor bug because of missing global
samhemelryk [Wed, 8 Jul 2009 01:52:16 +0000 (01:52 +0000)]
filelib MDL-19707 Modified file_extension_icon to use extisting function mimeinfo and reverted
two uses of file_extension_icon in course-lib that were incorrect
moodlerobot [Wed, 8 Jul 2009 00:36:49 +0000 (00:36 +0000)]
Updated the HEAD build version to
20090708
samhemelryk [Tue, 7 Jul 2009 09:09:16 +0000 (09:09 +0000)]
javascript MDL-16673 Removed all removeable uses of CFG->javascript
In doing this I was able to eliminate the need for javascript.php files, now removed.
I will also be filing several subtasks to clean up the linked to JS files in OUTPUT as well
as all instance of the old style of focusing.
samhemelryk [Tue, 7 Jul 2009 08:49:00 +0000 (08:49 +0000)]
lib-form MDL-16706 Changed inline JS to use PAGE methods
moodler [Tue, 7 Jul 2009 07:43:36 +0000 (07:43 +0000)]
Fixing a notice for Tim
moodler [Tue, 7 Jul 2009 07:35:59 +0000 (07:35 +0000)]
Upgraded this theme to use the new $THEME->pluginsheets
dongsheng [Tue, 7 Jul 2009 07:16:22 +0000 (07:16 +0000)]
"MDL-16706, fixed javascript object used to assoicate editorid with file picker clientid"
moodler [Tue, 7 Jul 2009 07:06:19 +0000 (07:06 +0000)]
accesslib MDL-19730 fixing regression from MDL-19077 where has_capability fails when $USER->id=0 (so they couldn't see blocks etc)
samhemelryk [Tue, 7 Jul 2009 06:16:01 +0000 (06:16 +0000)]
filelib MDL-19707 Converted existing ...str_replace('png','gif')... to use file_extension_icon and file_mimetype_icon
samhemelryk [Tue, 7 Jul 2009 06:05:39 +0000 (06:05 +0000)]
course-modedit MDL-16089 Fixed bug caused by recent changes, unable to edit resources
tjhunt [Tue, 7 Jul 2009 05:06:38 +0000 (05:06 +0000)]
themes: MDL-19077 - take out test code I did not mean to include in my last commit.
tjhunt [Tue, 7 Jul 2009 05:05:06 +0000 (05:05 +0000)]
themes: MDL-19077 - more work on the theme_config class.
* Writing lots more PHPdoc comments for all the settings.
* Strip the comments from the standard theme config.php (see below)
* Move finding the layout template from moodle_core_renderer to the theme_config class
* Move loading meta.php files from moodle_core_renderer to the theme_config class
* MDL-19719 Remove support for $THEME->langsheets, and lang/.../styles.php
* MDL-19719 Put the Vietnamese-specific code into the standard theme
* Support for styles.php in all plugin types (at the theme's discretion). (c/f MDL-16438)
* More PHP doc comments for moodle_core_renderer methods.
About stripping comments from config.php: I'm not sure if this
is a good idea, and I may revert this bit. I am hoping that once
http://phpdocs.moodle.org/HEAD/moodlecore/theme_config.html has
been updated, that will be better than copying and pasting these
comments into every theme. I intend to post in the themes forum
to canvas opinions.
tjhunt [Tue, 7 Jul 2009 04:37:12 +0000 (04:37 +0000)]
Catch another potential type of infinite recursion output initialisation.
samhemelryk [Tue, 7 Jul 2009 04:03:33 +0000 (04:03 +0000)]
lib-filelib MDL-19707 Modified file_extension_icon() to accept full filename
samhemelryk [Tue, 7 Jul 2009 03:56:15 +0000 (03:56 +0000)]
lib-filelib MDL-19707 Added file_extension_icon() and file_mimetype_icon()
After talking with Tim we decided that this would be a better solution than adding more methods to $OUTPUT
tjhunt [Tue, 7 Jul 2009 03:49:46 +0000 (03:49 +0000)]
Typo fix.
tjhunt [Tue, 7 Jul 2009 03:49:13 +0000 (03:49 +0000)]
MDL-19690 - pixpath - cannot use $OUTPUT in CSS. Use $PAGE->theme instead.