martinlanghoff [Fri, 23 Nov 2007 00:23:39 +0000 (00:23 +0000)]
user/index: Add "enrolment details" view to Participants page - MDL-12311
With this patch, the additional roles/groups/groupings columns get moved
to a special "enrolment details" view. To support this, the handling of
the $mode is revamped to use $mode constants.
To keep performance issues at bay, the enrolment details view is only
available when viewing paginated resultsets, and will reset itself to
'brief' if the conditions aren't met. The $mode is sticky, so it is
quite possible to have a mismatched $mode -- so he handle the case
explicitly.
nfreear [Wed, 21 Nov 2007 14:50:32 +0000 (14:50 +0000)]
Fixes reopened bug MDL-7472, "Explicitly label radio buttons in Survey" - removes use of USER->screenreader using get_accesshide + many other accessibility fixes.
tjhunt [Tue, 20 Nov 2007 17:31:13 +0000 (17:31 +0000)]
MDL-12172 - Sorry, more fall-out from converting continue buttons to use GET instead of POST. Sometimes, URLs were being passed in with & already repalced by & and we weren't handling that properly. Should now be fixed. Merged from MOODLE_19_STABLE.
tjhunt [Tue, 20 Nov 2007 16:57:22 +0000 (16:57 +0000)]
MDL-12282 - Numerical question type - the units are displayed on the editing form with a stupidly large number of decimal places. Merged from MOODLE_18_STABLE.
tjhunt [Tue, 20 Nov 2007 15:08:05 +0000 (15:08 +0000)]
MDL-12133 - Errors calling parent::validation in a moodle form subclass because the base class method returns true not an empty array. This patch allow subclasses to start their validate method with
$errors = parent::validation($data, $files);
which is what you naturally want to do if you are used to object oriented programming.
tjhunt [Tue, 20 Nov 2007 12:41:04 +0000 (12:41 +0000)]
MDL-12133 - Errors calling parent::validation in a moodle form subclass because the base class method signature was changed. This patch fixes all calls to parent::validation in the question editing forms. Merged from MOODLE_19_STABLE.
martinlanghoff [Tue, 20 Nov 2007 00:18:31 +0000 (00:18 +0000)]
accesslib: has_capability_in_accessdata() respects rdef locality a bit more
With this patch, we respect rdef locality when two roles
assignments in the same context have conflicting rdefs.
In that case, the most local rdef wins.
So RA locality still matters most. If you are a teacher
sitewide and a student in course X, student role trumps
teacher.
For a use case, see the discussion here
http://moodle.org/mod/forum/discuss.php?d=84472
Notes:
- If we wanted to have locality of RDEF trump everything
we can. A comment in this patch shows how.
- I don't know how to reproduce this in pure SQL.
And Also:
This patch also fixes a bug where if CAP_PROHIBIT was set
_and_ another role added to it in the same context, we would
add or substract 1 to CAP_PROHIBIT, and it would lose its magic.
And while at it, tighten the code to avoid casts. All the
ints are unambiguously ints.
martinlanghoff [Mon, 19 Nov 2007 02:43:48 +0000 (02:43 +0000)]
user_login() was not converted to using get_cache_flags().
It was still using the 'old' get_config() interface, so the 'cookie'
set by ntlmsso_finish() wasn't retrieved at all, and the automatic
login always failed.
Signed-off-by: Iñaki Arenaza <iarenuno@eteo.mondragon.edu>
Author: Iñaki Arenaza <iarenuno@eteo.mondragon.edu>
Committer: Martin Langhoff <martin@catalyst.net.nz>
martinlanghoff [Mon, 19 Nov 2007 02:43:34 +0000 (02:43 +0000)]
If the cache flag is not set, it doesn't make sense trying to test its value
Signed-off-by: Iñaki Arenaza <iarenuno@eteo.mondragon.edu>
Author: Iñaki Arenaza <iarenuno@eteo.mondragon.edu>
Committer: Martin Langhoff <martin@catalyst.net.nz>
martinlanghoff [Mon, 19 Nov 2007 02:43:16 +0000 (02:43 +0000)]
Fix typo in ntlmsso_finish()
Signed-off-by: Iñaki Arenaza <iarenuno@eteo.mondragon.edu>
Author: Iñaki Arenaza <iarenuno@eteo.mondragon.edu>
Committer: Martin Langhoff <martin@catalyst.net.nz>
urs_hunkler [Fri, 16 Nov 2007 13:33:51 +0000 (13:33 +0000)]
merged from 1.9 :: MDL-12221 :: Added wrapper functions for print_box, print_box_start and print_box_end to be able to add custom_corners to any boxes.
If you call print_custom_corners_box with the same parameters as print_box and custom_corners is enabled you get the custom corners divs within those boxes and can style them accordingly.
urs_hunkler [Fri, 16 Nov 2007 07:29:14 +0000 (07:29 +0000)]
merged from 1.9 :: MDL-12045 :: the extra "clearer" div broke the custom_corners theme on IE7. I removed the "clearer" div and added the class "clerafix" to the surrounding coursebox.
projects / moodle.git / log