tjhunt [Thu, 11 Dec 2008 09:21:41 +0000 (09:21 +0000)]
admin tree: MDL-10047 and MDL-13104 weird things happen when you turn editing on and off.
That was becuase not enough information was being passed in for the blocks editing controls to construct the right URL to reload the page.
It is also now possible for admin external pages to add some UI next to the turn blocks editing on/off button. For example, when you are editing the list of course catgories, the turn editing off button is now in the right place.
tjhunt [Thu, 11 Dec 2008 07:01:57 +0000 (07:01 +0000)]
forum subscriptions: MDL-14876 user of deprecated functions was breaking managing subscribers.
This was visible when, for example, unusual role definitions meant that someone could access a forum without being enrolled in a course.
Note that one of the places that was previously broken was front page forums. Since subscribers.php does not do paging at all, the fact that I have fixed this bug makes this page dangerous on large sites. A proper solution will have to wait until bug 17550 is fixed in HEAD.
This also fixes a minor problem introduced by MDL-12979.
tjhunt [Wed, 10 Dec 2008 09:11:30 +0000 (09:11 +0000)]
quiz manual grading: MDL-5517 manual grading pop-up is too small. HTML editor does not fit. Merged from MOODLE_19_STABLE.
Also MDL-17585 Improve layout of manual grading forms to make them look more like formslib forms. The standard trick of stealing the HTML and class names that formslib works, so the standard style rules apply to your form.
tjhunt [Wed, 10 Dec 2008 06:26:47 +0000 (06:26 +0000)]
quiz: MDL-6085 when editing a question from various places like a preview attempt or review screen, don't use a popup, instead take advantage of the fact that question.php now takes a returnurl. Merged from MOODLE_19_STABLE.
And MDL-17568 minor niggles with new queston navigation:
* The bit that scrolls down to the question you just submitted in adaptive mode was not working with random questions.
* Teachers reviewing an open attempt were shown the qusetions as editable, not read only!
moodler [Wed, 10 Dec 2008 06:23:35 +0000 (06:23 +0000)]
admin MDL-17429 Move registration button to admin menu, and make registration page a proper admin page, also fix bad DML call
admin MDL-16867 Change "Optional subsystems" menu item to "Advanced features"
tjhunt [Wed, 10 Dec 2008 02:57:41 +0000 (02:57 +0000)]
course request: MDL-17575 and MDL-6160 further improvements:
1/ email notification when course requested
2/ course request capability so that we can limit who can request new course
3/ list of my pending course requests on the request form
Implemented in 1.9 by Petr Skoda, and reviewed and merged to HEAD by me.
tjhunt [Tue, 9 Dec 2008 05:14:15 +0000 (05:14 +0000)]
define roles: MDL-16966 go back to 'Define roles' in the admin menu, rather than 'Manage roles'
Define is a stronger verb than manage, and most of the things there are to do with defining roles. I keep finding myself looking for 'Define roles' in the menu when I am testing, which suggests changing the working in 1.9 does more harm than good.
tjhunt [Mon, 8 Dec 2008 07:28:19 +0000 (07:28 +0000)]
course categories: MDL-17502 when deleting a category and its contents, check moodle/course:delete capability.
* Note: this would never lead to problems with default role definions.
* Also ended up mostly rewriting delete_category_form to simplify the messages that are displayed.
* New helper function require_all_capabilities, a bit like require_any_capability.
tjhunt [Mon, 8 Dec 2008 02:31:05 +0000 (02:31 +0000)]
course settings: MDL-17501 check for moodle/course:visibility in the course settings form.
1. If a user does not have that capability, don't let them change whether the course is visible.
2. Give teachers that capability by default.
3. To avoid regressions, on upgrade, give moodle/course:visibility to any role that has moodle/course:update.
danmarsden [Sun, 7 Dec 2008 21:54:49 +0000 (21:54 +0000)]
skip content structure page:MDL-11908: skip content structure page with multiple scos - if a teacher has set to skip, it should skip! - even with multiple scos.
tjhunt [Fri, 5 Dec 2008 08:56:54 +0000 (08:56 +0000)]
course request: MDL-9854 major cleanup to the course request code.
* Rewrite all the forms to use formslib and improve usability.
* Put the place where admins need to go to process approvals in the admin menu.
* Show the request course/pending requests button on the page for the category that requested courses get added to.
pilpi [Thu, 4 Dec 2008 15:13:22 +0000 (15:13 +0000)]
quiz editing: MDL-17409 converted strings to use $a
converted concatenation to use $a instead for new (committed with the rest of Quiz UI redesign project) strings, created new strings for old strings that did not yet use $a
pilpi [Thu, 4 Dec 2008 13:28:20 +0000 (13:28 +0000)]
quiz editing: MDL-17409 removed ":" from source
removed ":" from source where they occured with new (committed with the rest of Quiz UI redesign project) strings and changed the strings accordingly
samulik [Thu, 4 Dec 2008 12:23:12 +0000 (12:23 +0000)]
course import: MDL-17497 PHP was running out of memory if a category had a lot of courses. Now get_courses only fetches course id and fullname (merge from 19_STABLE)