bobopinna [Tue, 5 Jun 2007 09:30:19 +0000 (09:30 +0000)]
fixed some others problem with learner_response element
toyomoyo [Tue, 5 Jun 2007 09:28:15 +0000 (09:28 +0000)]
grade import temporary buffer tables and encoding/import form changes
nicolasconnault [Tue, 5 Jun 2007 08:50:24 +0000 (08:50 +0000)]
MDL-9629 Changed grade_item.gradetype default to 1, added GRADE_TYPE_NONE constant = 0, incrementing existing constants by 1. Set up auto-generation of idnumber for grade_item if itemmodule and iteminstance are set, only a temporary stub if they are not set (must be replaced by correct generation code). New category form now has server-side validation (not using formslib)
jgutierr25 [Tue, 5 Jun 2007 08:35:57 +0000 (08:35 +0000)]
automatic authentication when direct access from another CAS application and multiauth
toyomoyo [Tue, 5 Jun 2007 05:40:10 +0000 (05:40 +0000)]
adding a usermodified field to post table
nicolasconnault [Tue, 5 Jun 2007 04:16:14 +0000 (04:16 +0000)]
Added some strings
toyomoyo [Tue, 5 Jun 2007 01:54:19 +0000 (01:54 +0000)]
part of the user management improvements on enrolment, forgot to check this in
nicolasconnault [Tue, 5 Jun 2007 01:19:09 +0000 (01:19 +0000)]
MDL-9972 Removed the __destruct() method, which was not needed. Also fixed a few bugs that caused notices in PHP5.
nicolasconnault [Tue, 5 Jun 2007 00:39:01 +0000 (00:39 +0000)]
MDL-9629 Category edit page now supports creation of a new category for selected items or categories.
poltawski [Mon, 4 Jun 2007 22:53:50 +0000 (22:53 +0000)]
MDL-8080 Grade exceptions broken for teacher by invalid capability check.
Thanks to Paul Ortman for the patch. Merged from MOODLE_17_STABLE
poltawski [Mon, 4 Jun 2007 22:24:23 +0000 (22:24 +0000)]
MDL-10001 - Change the ordering of height and width parameters in the interface to reflect
previous ordering. merged from MOODLE_18_STABLE
poltawski [Mon, 4 Jun 2007 22:01:59 +0000 (22:01 +0000)]
MDL-9987 - Reffering to wrong capability name, merged from 18_STABLE
skodak [Mon, 4 Jun 2007 21:43:57 +0000 (21:43 +0000)]
MDL-10018 Discussion for all groups not sent when groups used to users without access to all groups
bobopinna [Mon, 4 Jun 2007 15:50:44 +0000 (15:50 +0000)]
fixed some problems with learner_response values
moodler [Mon, 4 Jun 2007 12:42:17 +0000 (12:42 +0000)]
Merged typo fixes for MDL-10013
bobopinna [Mon, 4 Jun 2007 11:19:27 +0000 (11:19 +0000)]
Commented lines that block ADL test suite check
bobopinna [Mon, 4 Jun 2007 07:26:00 +0000 (07:26 +0000)]
General cleaning of function SetValue
First step for solving CMIFeedback pattern matching
skodak [Sun, 3 Jun 2007 19:36:20 +0000 (19:36 +0000)]
MDL-10012 Implement grade_updated event triggers in Database
skodak [Sun, 3 Jun 2007 19:12:55 +0000 (19:12 +0000)]
MDL-9516 fixed mod_form.php logic + related lib issues
skodak [Sun, 3 Jun 2007 19:08:14 +0000 (19:08 +0000)]
MDL-9516 fixed mod_form.php logic
skodak [Sun, 3 Jun 2007 16:24:03 +0000 (16:24 +0000)]
MDL-9548 Implement grade_updated event triggers in Forum
skodak [Sun, 3 Jun 2007 16:17:39 +0000 (16:17 +0000)]
MDL-10011 cleanup xhtml and code in report.php - forum, glossary and data mod
skodak [Sun, 3 Jun 2007 15:31:30 +0000 (15:31 +0000)]
fixed some xhtm strict problems
skodak [Sun, 3 Jun 2007 12:37:50 +0000 (12:37 +0000)]
MDL-9545 minor refactoring and comment cleanup
skodak [Sun, 3 Jun 2007 12:34:56 +0000 (12:34 +0000)]
MDL-9549 function param renamed
skodak [Sun, 3 Jun 2007 12:22:23 +0000 (12:22 +0000)]
MDL-9549 some more grading and rating improvements, cleanup and fixes
skodak [Sun, 3 Jun 2007 11:29:38 +0000 (11:29 +0000)]
MDL-9549 no rating fix
skodak [Sun, 3 Jun 2007 10:30:23 +0000 (10:30 +0000)]
MDL-9549 no grading fix
skodak [Sun, 3 Jun 2007 10:10:40 +0000 (10:10 +0000)]
MDL-9549 fixed deleting of instance
skodak [Sun, 3 Jun 2007 09:56:49 +0000 (09:56 +0000)]
MDL-9549 added proper handling of magic quotes when dealing with mod_form
skodak [Sun, 3 Jun 2007 09:27:16 +0000 (09:27 +0000)]
MDL-9549 minor code formatting cleanup
skodak [Sun, 3 Jun 2007 09:26:45 +0000 (09:26 +0000)]
MDL-9545 minor code formatting cleanup
skodak [Sun, 3 Jun 2007 09:10:52 +0000 (09:10 +0000)]
MDL-9545 refactoring of grading code in assignment, whitespace cleanup
skodak [Sun, 3 Jun 2007 09:06:58 +0000 (09:06 +0000)]
MDL-9549 added comments and fixed grade item delete
tjhunt [Sun, 3 Jun 2007 07:26:54 +0000 (07:26 +0000)]
MDL-10006 - Sorting the quiz overview report on feedback breaks it. Merged from MOODLE_18_STABLE.
skodak [Sat, 2 Jun 2007 22:18:01 +0000 (22:18 +0000)]
MDL-9549 Implement grade_updated event triggers in Glossary
skodak [Sat, 2 Jun 2007 15:56:52 +0000 (15:56 +0000)]
MDL-10010 improved data validation in glossary rate.php
skodak [Sat, 2 Jun 2007 14:08:14 +0000 (14:08 +0000)]
minor xhtml strict fix and coding style
skodak [Sat, 2 Jun 2007 14:03:06 +0000 (14:03 +0000)]
MDL-10009 ratings settings do not work in glossary
skodak [Fri, 1 Jun 2007 15:13:36 +0000 (15:13 +0000)]
fixed handling of grade items when deleting assignment
tjhunt [Fri, 1 Jun 2007 13:52:36 +0000 (13:52 +0000)]
Remove invalid unit test.
csantossaenz [Fri, 1 Jun 2007 12:42:36 +0000 (12:42 +0000)]
Fixed problem with cmi.interactions.id elements' duplicated ids.
thepurpleblob [Fri, 1 Jun 2007 08:25:18 +0000 (08:25 +0000)]
MDL-9265:
'correctanswer' field missing for true/false.
nicolasconnault [Fri, 1 Jun 2007 08:01:47 +0000 (08:01 +0000)]
MDL-9137 Almost finished the edit category page. The only remaining issue is some sort of endless loop starting in grade_category::set_as_parent. Big issue...
nicolasconnault [Fri, 1 Jun 2007 04:46:24 +0000 (04:46 +0000)]
MDL-9137 Removed hidden field from grade_categories and added deleted field to grade_items. Also added 2 images in pix/i
nicolasconnault [Fri, 1 Jun 2007 04:02:37 +0000 (04:02 +0000)]
MDL-9629 Category edit page now implements delete, show/hide, lock/unlock, moveup/movedown and move actions. The edit icon is also shown but not yet implemented.
toyomoyo [Fri, 1 Jun 2007 02:44:34 +0000 (02:44 +0000)]
adding some form headers to help read
skodak [Thu, 31 May 2007 20:34:41 +0000 (20:34 +0000)]
bgufixing and external grading improvements
csantossaenz [Thu, 31 May 2007 16:24:53 +0000 (16:24 +0000)]
Fixed a problem with cmi.interactions.n.objectives.n.id duplicated ids
toyomoyo [Thu, 31 May 2007 09:00:09 +0000 (09:00 +0000)]
gradebook backup and restore fixes
nicolasconnault [Thu, 31 May 2007 08:57:05 +0000 (08:57 +0000)]
MDL-9628 Move work on the category edit page
thepurpleblob [Thu, 31 May 2007 08:32:07 +0000 (08:32 +0000)]
Fixed typo stopping image importing working
nicolasconnault [Thu, 31 May 2007 03:15:43 +0000 (03:15 +0000)]
MDL-9506 MDL-9137 MDL-9629
Added a number of small getters and setters to grade_item and grade_category, to hide the structural differences between the two, and provide a common interface for cases when we are not sure whether an $object is of one type or another.
The grade_tree::renumber() method now adds complete objects to the need_update array, because both grade_category and grade_item need to update their parent field when moved to a different parent. Amazingly, these important changes worked straight away (after 1 hour of coding without testing anything), and all the unit tests passed!
skodak [Wed, 30 May 2007 08:54:52 +0000 (08:54 +0000)]
MDL-4687 Password expiration support for AD (with patch) - patch by Iñaki Arenaza, thanks!
skodak [Wed, 30 May 2007 08:49:19 +0000 (08:49 +0000)]
MDL-9954 LDAP auth settings form problem with 'Member Attribute' and 'Member Attribute uses dn'; patch by Iñaki Arenaza - thanks!
nicolasconnault [Wed, 30 May 2007 08:48:11 +0000 (08:48 +0000)]
Implemented a test version of the gradebook category edit page, and developed the get_edit_tree method in grade_tree. Items can be successfully moved up and down, and a "move" button lets the user select a source element, then a destination box. All actions use POST.
skodak [Wed, 30 May 2007 08:47:00 +0000 (08:47 +0000)]
MDL-9626 Enable user signup with Active Directory (via LDAP); patch by Iñaki Arenaza - thanks!
toyomoyo [Wed, 30 May 2007 08:45:13 +0000 (08:45 +0000)]
more fixes for gradebook backup/restore
toyomoyo [Wed, 30 May 2007 06:38:23 +0000 (06:38 +0000)]
fix ordering bug when restoring grade item
toyomoyo [Wed, 30 May 2007 06:23:21 +0000 (06:23 +0000)]
added itemtype to backup/restore, only restore a mod type gradeitem if user data is included
nicolasconnault [Wed, 30 May 2007 05:47:26 +0000 (05:47 +0000)]
MDL-9506 Added ksort() of each level of categories and items for the gradebook. Unsorted arrays caused erratic behaviour when moving elements of the tree around.
toyomoyo [Wed, 30 May 2007 05:32:47 +0000 (05:32 +0000)]
respecting sortorder when restoring grade_itmes, other minor fixes
nicolasconnault [Wed, 30 May 2007 03:09:38 +0000 (03:09 +0000)]
MDL-9506 Refactored grade_tree::get_tree by doing the following:
- Extracted the $fillers array into a class variable
- Extracted the addition of elements to grade_tree::fillers into a new add_fillers($array) method
- Extracted the inclusion of fillers into the tree_array to a new include_fillers($tree, $object=NULL) method
- Removed the building of the tree_filled, which was already performed by build_tree_filled()
- Removed the generation of next_sortorder and previous_sortorder attributes, which was already performed by renumber()
Result is a much leaner and scalable set of methods, and a tighter definition of responsibilities for the varying classes. I think I have also noticed a significant inprovement in speed.
toyomoyo [Wed, 30 May 2007 02:22:43 +0000 (02:22 +0000)]
fixing a typo
toyomoyo [Wed, 30 May 2007 02:20:56 +0000 (02:20 +0000)]
during backup parent categories need to go before children
wildgirl [Tue, 29 May 2007 17:26:45 +0000 (17:26 +0000)]
typo fix MDL-8093
thepurpleblob [Tue, 29 May 2007 15:19:12 +0000 (15:19 +0000)]
MDL-9716
'answernumbering' field now supported
csantossaenz [Tue, 29 May 2007 11:22:49 +0000 (11:22 +0000)]
Fixed problem with cmi.interactions.n.id duplicated ids
dwoolhead [Tue, 29 May 2007 09:56:44 +0000 (09:56 +0000)]
MDL-9729 Ensure start of week day calculation observes user timezone setting in the same way as month start and end dates. Prevents incorrect display of dates (1 out) on main Moodle calendar display although mini calendar display is correct. (Merged from 1.8 stable branch)
toyomoyo [Tue, 29 May 2007 09:00:48 +0000 (09:00 +0000)]
restore for gradebook, needs testing for grade_history, outcomes, categories, calculations and text
jamiesensei [Tue, 29 May 2007 06:27:38 +0000 (06:27 +0000)]
reverting commit 1.889 "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary.
jamiesensei [Tue, 29 May 2007 06:14:09 +0000 (06:14 +0000)]
reverting last commit "added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE." It turned out to be unnecessary.
jamiesensei [Tue, 29 May 2007 06:14:09 +0000 (06:14 +0000)]
fixed bug in parsing urls
nicolasconnault [Tue, 29 May 2007 04:07:04 +0000 (04:07 +0000)]
MDL-9506 Resolved recursion issues in grade_tree:renumber and grade_tree::get_neighbour_element. Unit tests all pass now.
nicolasconnault [Tue, 29 May 2007 00:56:44 +0000 (00:56 +0000)]
MDL-9317 Applying Petr's second patch
mark-nielsen [Mon, 28 May 2007 18:55:15 +0000 (18:55 +0000)]
Merging in changes for MDL-9947 and MDL-9923 from MOODLE_18_STABLE
jamiesensei [Mon, 28 May 2007 14:25:40 +0000 (14:25 +0000)]
added another parameter to moodle_url out, out_action and get_query_string so that developer can output url with query string joined by '&' and not '&'. & breaks redirect on IE.
jamiesensei [Mon, 28 May 2007 14:21:09 +0000 (14:21 +0000)]
MDL-9745 "Checkboxes badly lined up in forms lib, e.g. "students may review" settings on quiz settings screen." Reverted previous fix for similar problem MDL-7779 as the fix for MDL-7779 causes worse problem MDL-9745 with form elements in groups. Second part of commit in HEAD, missed a bit in HEAD.
bobopinna [Mon, 28 May 2007 12:53:42 +0000 (12:53 +0000)]
patched a parse error
jamiesensei [Mon, 28 May 2007 12:17:40 +0000 (12:17 +0000)]
MDL-9745 Checkboxes badly lined up in forms lib, e.g. "students may review" settings on quiz settings screen. Reverted previous fix for similar problem MDL-7779 as the fix for MDL-7779 causes worse problems with form elements in groups.
skodak [Mon, 28 May 2007 08:55:15 +0000 (08:55 +0000)]
MDL-9632; MDL-9545 basic assignment grading support - event triggers implemented + some minor cleanup
skodak [Mon, 28 May 2007 08:49:40 +0000 (08:49 +0000)]
MDL-9960 update_record() does not store NULLs; I hope it will not break anything
skodak [Mon, 28 May 2007 08:20:07 +0000 (08:20 +0000)]
apply magic quotes before using var in sql query in fetch_all_using_this()
bobopinna [Mon, 28 May 2007 08:18:25 +0000 (08:18 +0000)]
Added the starting point for CMIFeedback type checking
nicolasconnault [Mon, 28 May 2007 08:00:19 +0000 (08:00 +0000)]
MDL-9506 Category and Item now set their own courseid if not set explicitly, and if they have enough information from
other sources. category::set_as_parent has a new constraint: cannot set over children from different courses.
Applied recursion to grade_tree::renumber(), but still some fine-tuning to do, since only grade_items are getting updated in DB.
nicolasconnault [Mon, 28 May 2007 02:05:21 +0000 (02:05 +0000)]
MDL-9137 Applied parts of Petr's patch on the gradebook objects. Unit tests unaffected.
nicolasconnault [Mon, 28 May 2007 01:26:58 +0000 (01:26 +0000)]
MDL-9506 Corrected a number of small errors in unit tests and classes.
jamiesensei [Mon, 28 May 2007 00:50:11 +0000 (00:50 +0000)]
added more phpdoc comments for hardFreezeAllVisibleExcept
jamiesensei [Mon, 28 May 2007 00:46:11 +0000 (00:46 +0000)]
new method hardFreezeAllVisibleExcept
nicolasconnault [Mon, 28 May 2007 00:22:17 +0000 (00:22 +0000)]
Removed non-standard :endif notation.
skodak [Sun, 27 May 2007 22:55:52 +0000 (22:55 +0000)]
MDL-9959 debugging() shows warnings when called from call_user_func() functions
MDL-9958 addslashes_recursive() and stripslashes_recursive() modifies function parameter in PHP5
bobopinna [Sun, 27 May 2007 21:24:51 +0000 (21:24 +0000)]
fixed translation file for othersettings string
bobopinna [Sun, 27 May 2007 21:22:27 +0000 (21:22 +0000)]
Fixed some bugs that block ADL test suite
Still to fix ex CMIFeedback type
bobopinna [Sun, 27 May 2007 17:13:16 +0000 (17:13 +0000)]
added a new string for exit activity instead using the old one
bobopinna [Sun, 27 May 2007 17:08:54 +0000 (17:08 +0000)]
Added exitactivity link in navigation bar
bobopinna [Sun, 27 May 2007 16:56:28 +0000 (16:56 +0000)]
Modified exit string now is exit activity
bobopinna [Sun, 27 May 2007 16:54:56 +0000 (16:54 +0000)]
Added some missing strings
bobopinna [Sun, 27 May 2007 16:32:59 +0000 (16:32 +0000)]
commented attend fields because this feature in not implemented yet
bobopinna [Sun, 27 May 2007 16:28:39 +0000 (16:28 +0000)]
fixed a big problem with local manifest file import
removed a white space in url generation
bobopinna [Sun, 27 May 2007 16:26:05 +0000 (16:26 +0000)]
removed an unrequired require_once
optimized an if branch