]>
git.mjollnir.org Git - moodle.git/log
nicolasconnault [Tue, 9 Oct 2007 14:08:05 +0000 (14:08 +0000)]
MDL-11608 The $rename param was obtained with PARAM_NOTAG, I changed that to PARAM_RAW. I also changed the rename field's value to htmlspecialchars($category->name)
skodak [Tue, 9 Oct 2007 13:43:51 +0000 (13:43 +0000)]
do not optimise the $USER fetching - it was broken by mnethostid and would be again in future
skodak [Tue, 9 Oct 2007 13:10:55 +0000 (13:10 +0000)]
fixed undefined $modcontext
skodak [Tue, 9 Oct 2007 13:04:33 +0000 (13:04 +0000)]
fixed missing $sql warning
nicolasconnault [Tue, 9 Oct 2007 12:53:24 +0000 (12:53 +0000)]
MDL-11543 Temporary solution originally proposed by Martin
skodak [Tue, 9 Oct 2007 12:49:54 +0000 (12:49 +0000)]
MDL-11640
* improved handling of dirty contexts in general - caching, switching in cron, marking, loading, etc.
* role_assing() and role_unassign() now marks dirty contexts because we use has_capability() in this function - we can not do it later outside to speedup bulk operations
* fixed some inline docs
* fixed notice from rs closing
* removed cached $CONTEXT from has_capability() - $context is now required parameter; this was hiding serious bugs when context did not exist or ppl passed false as parameter
* removed some ===, we can not use these on function parameters - we must support ints, strings, '', nulls, etc. - this could be a source of really dangerous bugs in future
* some other improvements and fixes - documented inline
thepurpleblob [Tue, 9 Oct 2007 10:26:09 +0000 (10:26 +0000)]
MDL-11514:
Link to missing word information and help file removed. There
was no extra help.
thepurpleblob [Tue, 9 Oct 2007 10:22:40 +0000 (10:22 +0000)]
MDL-11515:
Help file is not used.
Merged from STABLE_18
thepurpleblob [Tue, 9 Oct 2007 10:16:01 +0000 (10:16 +0000)]
MDL-11425:
Process the text properly for the category path.
Merged from STABLE_18.
skodak [Tue, 9 Oct 2007 09:29:45 +0000 (09:29 +0000)]
inherit by default decimal points in ranges and averages on grader report
moodler [Tue, 9 Oct 2007 09:16:44 +0000 (09:16 +0000)]
Added CSS classes to totals columns (cat and course) so that styles can be applied.
Made them bold by default in standard anc custom_corners.
MDL-11666
toyomoyo [Tue, 9 Oct 2007 08:56:56 +0000 (08:56 +0000)]
fixing a typo and some half finished comment
toyomoyo [Tue, 9 Oct 2007 08:51:49 +0000 (08:51 +0000)]
MDL-11669, adding a new export setting (for xml atm), so that we can choose to export only updated grades
toyomoyo [Tue, 9 Oct 2007 05:43:35 +0000 (05:43 +0000)]
MDL-11665, users with no grade:viewhidden capability gets a wrong upgrade count because after deletion of a grade, the grade can be NULL and not hidden at the same time
toyomoyo [Tue, 9 Oct 2007 04:02:43 +0000 (04:02 +0000)]
MDL-10048, revert some changes in courses regaring coloring of courses
stronk7 [Tue, 9 Oct 2007 00:11:07 +0000 (00:11 +0000)]
Modify notify_login_failures() for better scale. MDL-11661
skodak [Mon, 8 Oct 2007 23:09:10 +0000 (23:09 +0000)]
MDL-11578 , MDL-11578 , MDL-11573 :
* renamed Preferences to "My report preferences"
* renamed Site defaults to "Report defaults"
* rename Change site defaults to "Change report defaults"
* reintroduced Inherit option to Grader preferences - Nicolas was right, it is not possible to implement preference overrides without it with our current get_pref inplementation
* new separate option in plugin selector "Course settings"
* moved displaytype, decimals and aggregation position to "Course settings"
* created new table grade_settings + related functions grade_get/set_preference()
* user report now uses grade_seq class instead of grade_item::fetch_all(); added preloading of grade items into grade_grade instances
* other minor bugfixing/cleanup/improvements
Please note that the Grader report preferences and its defaults must be resaved again - sorry.
stronk7 [Mon, 8 Oct 2007 17:42:46 +0000 (17:42 +0000)]
ANSI join ON clauses should contain only the join condition. Also,
added prefix to the ORDER BY to prevent duplicate names.
skodak [Mon, 8 Oct 2007 17:27:42 +0000 (17:27 +0000)]
MDL-11653 undefined rcache in /lib/dmllib.php during upgrades
stronk7 [Mon, 8 Oct 2007 16:33:49 +0000 (16:33 +0000)]
Bump. MDL-11605
stronk7 [Mon, 8 Oct 2007 16:33:29 +0000 (16:33 +0000)]
Adding one new index to cache_text table. User to make cron deletion
of expired records faster. MDL-11605
nfreear [Mon, 8 Oct 2007 13:55:53 +0000 (13:55 +0000)]
Fixes MDL-11648, "Required" is inappropriate text for legend in user profile edit form.
nicolasconnault [Mon, 8 Oct 2007 09:54:51 +0000 (09:54 +0000)]
Creating course grade_category and course grade_item when not yet created and overview report is accessed
nicolasconnault [Mon, 8 Oct 2007 09:53:43 +0000 (09:53 +0000)]
Making the overview report viewable by student role by default
toyomoyo [Mon, 8 Oct 2007 08:51:59 +0000 (08:51 +0000)]
dropping context_rel table
ikawhero [Mon, 8 Oct 2007 08:10:45 +0000 (08:10 +0000)]
Only include data from field types that are "small"
moodler [Mon, 8 Oct 2007 07:26:29 +0000 (07:26 +0000)]
Some fixes to make preferences work correctly (if not set then they are 0) and so now ranges and averages show correctly on grader report when these are set to defaults in preferences MDL-11618
ikawhero [Mon, 8 Oct 2007 07:23:18 +0000 (07:23 +0000)]
Include custom profile fields when setting up a user object
ikawhero [Mon, 8 Oct 2007 07:21:32 +0000 (07:21 +0000)]
New function to return a partial user object with the custom profile fields
set.
moodler [Mon, 8 Oct 2007 07:11:22 +0000 (07:11 +0000)]
Cleaner saving of grader report prefs
ikawhero [Mon, 8 Oct 2007 06:59:00 +0000 (06:59 +0000)]
Check to ensure custom profile fields do not have same name as current
fields in the $USER record
moodler [Mon, 8 Oct 2007 06:55:34 +0000 (06:55 +0000)]
Re-ordered some preferences to be a bit more logical
toyomoyo [Mon, 8 Oct 2007 06:52:39 +0000 (06:52 +0000)]
MDL-11633, changing import to use $mform->getdata() instead of data_submitted()
gbateson [Mon, 8 Oct 2007 06:45:27 +0000 (06:45 +0000)]
added escaping of quotes in TimesUp message, so that apostrophes do not cause Javascript errors
moodler [Mon, 8 Oct 2007 05:11:15 +0000 (05:11 +0000)]
Fixed typo from MDL-11642, thanks Gary
toyomoyo [Mon, 8 Oct 2007 02:34:04 +0000 (02:34 +0000)]
MDL-11616, adding activity link back for hidden grade items
toyomoyo [Mon, 8 Oct 2007 00:42:41 +0000 (00:42 +0000)]
using correct capability for displaying activity report link in print_user()
diml [Sun, 7 Oct 2007 20:15:32 +0000 (20:15 +0000)]
fixes a bug in resource_get_physical_file(...) when making a ResourceDocument object.
diml [Sun, 7 Oct 2007 20:14:17 +0000 (20:14 +0000)]
add an override for system limits (execution time / memory limit) for long
reindexation works (big documents). Set statically to 300 sec and 48M.
TODO : get possibly admin defined values for these limits.
diml [Sun, 7 Oct 2007 19:44:59 +0000 (19:44 +0000)]
changing access resolution for buttons labels
diml [Sun, 7 Oct 2007 19:44:18 +0000 (19:44 +0000)]
unconsistent file
diml [Sun, 7 Oct 2007 19:40:47 +0000 (19:40 +0000)]
string nl translations for search block
diml [Sun, 7 Oct 2007 19:40:15 +0000 (19:40 +0000)]
string fr translations for search block
diml [Sun, 7 Oct 2007 19:39:42 +0000 (19:39 +0000)]
string en translations for search block
diml [Sun, 7 Oct 2007 19:36:01 +0000 (19:36 +0000)]
adding dutch translation for search engine
diml [Sun, 7 Oct 2007 19:34:59 +0000 (19:34 +0000)]
fix access check function for documents bug $context->instance to $context->instanceid
skodak [Sun, 7 Oct 2007 18:15:57 +0000 (18:15 +0000)]
MDL-11618 removed the inherit override from decimals and gradetype used on grader report preferences + several bug fixes + settings improvements
stronk7 [Sun, 7 Oct 2007 17:28:46 +0000 (17:28 +0000)]
Adding some traces here and there
moodler [Sun, 7 Oct 2007 14:53:13 +0000 (14:53 +0000)]
More passing around of context information to speed up things
moodler [Sun, 7 Oct 2007 14:52:29 +0000 (14:52 +0000)]
Added some hooks to increase debugging in admin/cron.php
$CFG->showcronsql
$CFG->showcrondebugging
skodak [Sun, 7 Oct 2007 14:08:37 +0000 (14:08 +0000)]
MDL-11448 FirstClass Authentication does not hold settings and has cosmetic and info leakage issues, patch by Dan Trockman
skodak [Sun, 7 Oct 2007 14:01:36 +0000 (14:01 +0000)]
fixed defaults and hardcoded lang strings in performance settings
skodak [Sun, 7 Oct 2007 13:46:46 +0000 (13:46 +0000)]
MDL-11568 prevent warning from $USER->mnehostid when not logged in
skodak [Sun, 7 Oct 2007 13:31:41 +0000 (13:31 +0000)]
MDL-11304 remerging fixes
moodler [Sun, 7 Oct 2007 13:18:05 +0000 (13:18 +0000)]
Removed some blank lines MDL-11632
skodak [Sun, 7 Oct 2007 13:04:49 +0000 (13:04 +0000)]
MDL-9636 grade import fixes - allow null grades, no importcode collisions and stealing, more validation and other bugfixes
skodak [Sun, 7 Oct 2007 10:51:52 +0000 (10:51 +0000)]
MDL-11611 reimplemented displaytype and decimals disabling logic in grade item edit form for dispa - now works for new items too
skodak [Sun, 7 Oct 2007 10:22:21 +0000 (10:22 +0000)]
MDL-11622, MDL-11623 xml import/export now uses user idnumber; feedback optional; related bugfixing
moodler [Sun, 7 Oct 2007 09:27:13 +0000 (09:27 +0000)]
Merged blog theme/lang fixes from MDL-10833
pichetp [Sat, 6 Oct 2007 20:51:28 +0000 (20:51 +0000)]
checking that there remain $oldwrappedids before deleting them lines 87-..
add if(is_array($oldwrappedids) && count($oldwrappedids)){
pichetp [Sat, 6 Oct 2007 19:02:26 +0000 (19:02 +0000)]
missing global $CFG ; line 577
function save_dataset_items($question, $fromform){
global $CFG;
stronk7 [Fri, 5 Oct 2007 22:27:55 +0000 (22:27 +0000)]
ORPHAN_USER_LASTACCESS_PROBLEM . MDL-11604
skodak [Fri, 5 Oct 2007 20:47:08 +0000 (20:47 +0000)]
MDL-11621 removed recursion from create_contexts()
skodak [Fri, 5 Oct 2007 20:16:51 +0000 (20:16 +0000)]
MDL-11621 new create_contexts() function that makes sure all contexts exist, optionally initialises the paths and depths too
skodak [Fri, 5 Oct 2007 15:06:38 +0000 (15:06 +0000)]
MDL-11521 fixed problems when creating contexts and aprents does not exist yet
MDL-11527 fixed warning from $CFG->defaultuserroleid when installing and upgrading
+ removed reusing of previous contexts in has_capability() and get_context_instance() because it was hiding critical errors when context was false, not specified, etc.
+ tweaked roles defaults - faster and defaults are applied when roles exist
+ SYSCONTEXTID may be specified in config.php to eliminate 1 db query
+ static context cache is now reset after rebuilding of context paths
+ path field in context table is now nullable - pg compatibility requirement
+ other minor fixes
skodak [Fri, 5 Oct 2007 14:31:57 +0000 (14:31 +0000)]
fixed whitespace
moodler [Fri, 5 Oct 2007 13:34:28 +0000 (13:34 +0000)]
Some SQL fixes to avoid putting 'quotes' around integers (performance)
skodak [Fri, 5 Oct 2007 09:47:31 +0000 (09:47 +0000)]
MDL-11576 grader report - if user can not see hidden grades they are treated as NULLs and column totals
moodler [Fri, 5 Oct 2007 07:26:02 +0000 (07:26 +0000)]
Pass $modcontext down through the functions so that print_post is more efficient MDL-11606
moodler [Fri, 5 Oct 2007 06:47:14 +0000 (06:47 +0000)]
Get imagealt during outer loops so that print_user_picture is more efficient MDL-11606
moodler [Fri, 5 Oct 2007 06:36:31 +0000 (06:36 +0000)]
Efficiency improvements to bring some SQL statements out of loops MDL-11606
moodler [Fri, 5 Oct 2007 06:32:53 +0000 (06:32 +0000)]
Small efficiency improvement for print_user_picture() when it does access the db
toyomoyo [Fri, 5 Oct 2007 06:31:11 +0000 (06:31 +0000)]
MDL-11549, print_user() should also check user context when printing activity report link
nicolasconnault [Fri, 5 Oct 2007 05:40:56 +0000 (05:40 +0000)]
MDL-11500 Catching empty $coursemod when viewhiddensection is false, + corrected type $coursemode => $coursemod
nicolasconnault [Fri, 5 Oct 2007 05:37:55 +0000 (05:37 +0000)]
MDL-11519 Commented out the Ajax option
nicolasconnault [Fri, 5 Oct 2007 04:24:42 +0000 (04:24 +0000)]
MDL-11525 When courseid is not present in the log entry, showing "Site" instead of $log->info
toyomoyo [Fri, 5 Oct 2007 03:52:17 +0000 (03:52 +0000)]
merged fix for MDL-10353, calendar export not handing course variable correctly
skodak [Thu, 4 Oct 2007 22:57:14 +0000 (22:57 +0000)]
MDL-11580 support for hidden state modification in gradebook from activities (quiz now only) - part 1
the hiding/unhiding should be IMO locked in gradebook UI when activity overrides it
wildgirl [Thu, 4 Oct 2007 20:32:09 +0000 (20:32 +0000)]
MDL-11492 help file re-write
stronk7 [Thu, 4 Oct 2007 17:55:59 +0000 (17:55 +0000)]
Reset possible changes by blocks to time_limit. MDL-11597
stronk7 [Thu, 4 Oct 2007 17:42:30 +0000 (17:42 +0000)]
Reset possible changes by modules to time_limit. MDL-11597
skodak [Thu, 4 Oct 2007 17:09:34 +0000 (17:09 +0000)]
MDL-11599 missing return statement
tjhunt [Thu, 4 Oct 2007 15:57:09 +0000 (15:57 +0000)]
MDL-11580 - refinement to Yu's checkin, including removing the $CFG->openuniversityhacks.
Also, reviewing the new code made me realise that the code in mod/quiz/report/overview/report.php was a mess, so I cleaned it up a bit.
moodler [Thu, 4 Oct 2007 15:45:37 +0000 (15:45 +0000)]
Added some default roles that should have moodle/grade:viewhidden
related to MDL-11580
nicolasconnault [Thu, 4 Oct 2007 15:07:08 +0000 (15:07 +0000)]
Re-enabling inherit options for range and average rows in grader report
nicolasconnault [Thu, 4 Oct 2007 09:30:16 +0000 (09:30 +0000)]
Re-enabling inherit options for range and average rows in grader report
moodler [Thu, 4 Oct 2007 09:21:23 +0000 (09:21 +0000)]
Just a little tidying up in the user report (padding)
skodak [Thu, 4 Oct 2007 09:00:29 +0000 (09:00 +0000)]
MDL-11582 switch category item only if it is really there - forgot to add courseitem into condition
skodak [Thu, 4 Oct 2007 08:48:04 +0000 (08:48 +0000)]
moving the class instantiation a bit earlier so that we can safely modify it
skodak [Thu, 4 Oct 2007 08:36:34 +0000 (08:36 +0000)]
MDL-11582 switch category item only if it is really there
toyomoyo [Thu, 4 Oct 2007 08:22:55 +0000 (08:22 +0000)]
MDL-11580, hide quiz grades when user has no grade:viewhidden capability and quiz is still open, need $CFG->openuniversityhacks flag set
nicolasconnault [Thu, 4 Oct 2007 08:16:13 +0000 (08:16 +0000)]
MDL-11576 Added the groupsql clause to has_hidden_grades
nicolasconnault [Thu, 4 Oct 2007 08:02:00 +0000 (08:02 +0000)]
MDL-11576 New grade_item method has_hidden_grades(), which returns a simple count of hidden grades for the item.
nicolasconnault [Thu, 4 Oct 2007 07:44:13 +0000 (07:44 +0000)]
Instantiating a full $grade_item object, otherwise the get_displaytype() method is not available and causes a fatal error
toyomoyo [Thu, 4 Oct 2007 07:06:54 +0000 (07:06 +0000)]
MDL-11544, tags migrate script postgres db problem
nicolasconnault [Thu, 4 Oct 2007 07:02:44 +0000 (07:02 +0000)]
MDL-11581 Implemented gradedisplaytype in user reports
moodler [Thu, 4 Oct 2007 06:44:51 +0000 (06:44 +0000)]
Latest tags file
moodler [Thu, 4 Oct 2007 06:06:07 +0000 (06:06 +0000)]
FIxed a string name which changed
gbateson [Thu, 4 Oct 2007 05:32:27 +0000 (05:32 +0000)]
use target="$CFG->framename" instead of $CFG->frametarget when HotPot navigation is set to "Moodle navigation frame"so that Moodle does not get stuck in sub frame
toyomoyo [Thu, 4 Oct 2007 05:13:28 +0000 (05:13 +0000)]
merged fix for MDL-10353, after setting preferences user should return to same course view