]>
git.mjollnir.org Git - moodle.git/log
stronk7 [Sat, 15 Dec 2007 00:49:53 +0000 (00:49 +0000)]
HEAD version bump by delta. Modify some timezone fields to accept new olson files. MDL-12024
stronk7 [Sat, 15 Dec 2007 00:49:05 +0000 (00:49 +0000)]
Modify some timezone fields to accept new olson files. MDL-12024
Merged from MOODLE_19_STABLE
skodak [Fri, 14 Dec 2007 21:22:38 +0000 (21:22 +0000)]
MDL-12221 reworked container autoclosing - error() and notice() do not work everywhere though; notice print header if needed now; new print_footer('empty') for empty footer - removes some hacky </body></html> - merged from MOODLE_19_STABLE
toyomoyo [Fri, 14 Dec 2007 06:16:08 +0000 (06:16 +0000)]
MDL-9290, restore performance improvements on reading xml
diml [Thu, 13 Dec 2007 21:45:28 +0000 (21:45 +0000)]
Fixes MDL-12578 for HEAD branch
adding SEARCH_TYPE_LESSON and related keys to searchlib.
urs_hunkler [Thu, 13 Dec 2007 20:25:24 +0000 (20:25 +0000)]
merged from 1.9 :: MDL-12221 :: Some enhancements to handle the changed boxes - work in progress.
urs_hunkler [Thu, 13 Dec 2007 20:21:56 +0000 (20:21 +0000)]
merged from 1.9 :: MDL-11438 :: added screenshot.jpg to prevent IEs crashing on the them selection page.
tjhunt [Thu, 13 Dec 2007 18:48:30 +0000 (18:48 +0000)]
MDL-12575 - Backup and restore problems with the new question bank. Merged from MOODLE_19_STABLE.
stronk7 [Thu, 13 Dec 2007 18:02:31 +0000 (18:02 +0000)]
Added the sql_cast_char2int() funtion to provide cross-db
casting from char/text to integer. MDL-12574
Merged from MOODLE_19_STABLE
tjhunt [Thu, 13 Dec 2007 17:24:54 +0000 (17:24 +0000)]
Improve error messages.
tjhunt [Thu, 13 Dec 2007 14:26:14 +0000 (14:26 +0000)]
MDL-12517 - Further refinement. Move the processing to after print_header, so any notices do not break XHTML strict. Merged from MOODLE_19_STABLE.
tjhunt [Thu, 13 Dec 2007 14:19:24 +0000 (14:19 +0000)]
MDL-12517 - Move checking code into the user interface layer where it belongs. Merged from MOODLE_19_STABLE.
toyomoyo [Thu, 13 Dec 2007 07:09:27 +0000 (07:09 +0000)]
MDL-12517, notify when grades entered into gradebook is out of bounds
toyomoyo [Thu, 13 Dec 2007 02:33:02 +0000 (02:33 +0000)]
MDL-12470, fixing broken span tag
tjhunt [Wed, 12 Dec 2007 19:13:09 +0000 (19:13 +0000)]
MDL-11267 - follow-up - don't show the checkboxes in the overview report if you cannot do anything with them. Merged from MOODLE_19_STABLE.
tjhunt [Wed, 12 Dec 2007 19:01:59 +0000 (19:01 +0000)]
Improve PHP doc comments.
tjhunt [Wed, 12 Dec 2007 18:10:48 +0000 (18:10 +0000)]
Fix Javascript error from essay questions on the review page.
tjhunt [Wed, 12 Dec 2007 17:47:35 +0000 (17:47 +0000)]
Fix notice.
tjhunt [Wed, 12 Dec 2007 17:23:55 +0000 (17:23 +0000)]
MDL-9459 - Provide information relating to groups in the summary message "Attemts: 123". Now, depending on the situation, you see one of three messages: "Attempts: 123", "Attemtps 123 (45 from your groups)" or "Attemtps 123 (45 from this group)".
I also took the opportunity to improve the layout of this message slightly, and clarify the message that tells you that you cannot add or remove questions from the quiz if there are attemts.
Merged from MOODLE_19_STABLE.
tjhunt [Wed, 12 Dec 2007 17:10:48 +0000 (17:10 +0000)]
Improve PHP doc comments.
toyomoyo [Wed, 12 Dec 2007 07:13:09 +0000 (07:13 +0000)]
MDL-12544, hide hidden roles in profile when user has no capability
toyomoyo [Wed, 12 Dec 2007 03:31:26 +0000 (03:31 +0000)]
MDL-12550, wrong user count in role assignment
stronk7 [Wed, 12 Dec 2007 00:58:09 +0000 (00:58 +0000)]
Reintroducing the possibility to declare a second row of tabs
via extratabs. MDL-12551
Merged from MOODLE_19_STABLE
stronk7 [Tue, 11 Dec 2007 23:39:32 +0000 (23:39 +0000)]
Adding the ability to perform custom uninstall tasks in modules. MDL-12520
Merged from MOODLE_19_STABLE
tjhunt [Tue, 11 Dec 2007 18:49:56 +0000 (18:49 +0000)]
MDL-12546 - The choice module was calling get_users_by_capability, which hammers the database and returns lots of data, inside a loop over users - and it was calling it with identical parameters each time. Ouch!
Actually, since the fix for MDL-12331, which changed the get_users_by_capability call at the top of this function, the check it was doing is entirely redundant anyway, so I removed it.
Merged from MOODLE_19_STABLE.
tjhunt [Tue, 11 Dec 2007 16:55:54 +0000 (16:55 +0000)]
MDL-12543 - Quiz overview report displays a grade of 0 the same way as a missing grade for an incomplete attempt. Merged from MOODLE_19_STABLE.
tjhunt [Tue, 11 Dec 2007 16:23:54 +0000 (16:23 +0000)]
MDL-8682 - followup. When disabling the enter key, don't disable it on links. That is bad for accessibility. Merged from MOODLE_19_STABLE.
tjhunt [Tue, 11 Dec 2007 15:55:25 +0000 (15:55 +0000)]
MDL-12542 - backup_todb not called on restore on date before it is inserted into mdl_user. This would cause a backup from a pre 1.7 site (or a pre 1.7 that has been upgraded to 1.9) to a 1.9 fresh install, to fail sometimes. Merged from MOODLE_19_STABLE.
nfreear [Tue, 11 Dec 2007 15:25:07 +0000 (15:25 +0000)]
Fixes MDL-12541 "Weeks course format - dates for each section should be marked up as heading". Merged.
tjhunt [Tue, 11 Dec 2007 15:04:31 +0000 (15:04 +0000)]
MDL-12540 - Quiz sometimes outputs content before <head> when previewing - breaks HTML strict. Merged from MOODLE_19_STABLE.
nfreear [Tue, 11 Dec 2007 13:58:39 +0000 (13:58 +0000)]
Fixes MDL-12539 "Help link text for all admin/user filters are broken".
nfreear [Tue, 11 Dec 2007 12:58:37 +0000 (12:58 +0000)]
Fixes MDL-12539 "Help link text for all admin/user filters are broken".
tjhunt [Tue, 11 Dec 2007 10:37:53 +0000 (10:37 +0000)]
Take out debugging output in role_assign. It only tells you that something has worked, and everywhere else we use debugging output to warn people they have called an API wrongly. Therefore, this is just confusing now that we trust this bit of roles code.
pichetp [Tue, 11 Dec 2007 09:13:17 +0000 (09:13 +0000)]
MDL-12421 rounding
pichetp [Tue, 11 Dec 2007 08:56:24 +0000 (08:56 +0000)]
MDL-12503 Loguniform and MDL-12421 rounding
toyomoyo [Tue, 11 Dec 2007 05:44:11 +0000 (05:44 +0000)]
MDL-12504, gradebook export does not respect course item position
scyrma [Tue, 11 Dec 2007 05:10:10 +0000 (05:10 +0000)]
prevent some notices, cleaner code.
scyrma [Tue, 11 Dec 2007 05:00:14 +0000 (05:00 +0000)]
MDL-12528 - getElementById was misspelled.
jamiesensei [Tue, 11 Dec 2007 03:24:35 +0000 (03:24 +0000)]
MDL-12410 - a way to select which questions to export, includes debug messages
toyomoyo [Tue, 11 Dec 2007 03:16:15 +0000 (03:16 +0000)]
MDL-12463, do not backup mod gradeitems if not selected
toyomoyo [Tue, 11 Dec 2007 02:04:36 +0000 (02:04 +0000)]
MDL-12519. grader report row colors override highlighting
martinlanghoff [Mon, 10 Dec 2007 21:35:58 +0000 (21:35 +0000)]
MDL-12523 accesslib:cleanup_contexts() - Fix invalid SQL syntax and reserved keywords
cleanup_contexts() was not working on Oracle - mostly due to 2 SQL
syntax problems. So probably marginally working elsewhere.
- We should not use AS when naming table/subselect aliases - only
when referring to column aliases in the resultset
- level is a reserved word - oops! - so back to contextlevel
tjhunt [Mon, 10 Dec 2007 17:37:14 +0000 (17:37 +0000)]
MDL-12512 - Gradebook calculations are broken. This was caused by == FALSE that should have been === FALSE deep in the 3rd pary maths lib. Merged from MOODLE_19_STABLE.
tjhunt [Mon, 10 Dec 2007 16:53:17 +0000 (16:53 +0000)]
Do not suppress errors from developers! it makes debugging a nightmare!
tjhunt [Mon, 10 Dec 2007 11:57:24 +0000 (11:57 +0000)]
Fix notice in numerical question.
nfreear [Mon, 10 Dec 2007 10:26:47 +0000 (10:26 +0000)]
Fixes bug MDL-2674, "backup always backsup/restores groups regardless of user settings" - restore group/grouping option.
stronk7 [Sun, 9 Dec 2007 18:22:24 +0000 (18:22 +0000)]
Document MDL-12378
Merged from MOODLE_19_STABLE
stronk7 [Sun, 9 Dec 2007 18:20:55 +0000 (18:20 +0000)]
Prevent XHTML breackage. MDL-12378
Merged from MOODLE_19_STABLE
stronk7 [Sat, 8 Dec 2007 18:54:24 +0000 (18:54 +0000)]
Changing wrong UNSIGNEDs to nulls in tests. MDL-11662
Merged from MOODLE_19_STABLE
stronk7 [Sat, 8 Dec 2007 18:44:12 +0000 (18:44 +0000)]
Changing XMLDB_UNSIGNED to nulls for non-numeric types. MDL-11662
Merged from MOODLE_19_STABLE
stronk7 [Sat, 8 Dec 2007 18:20:15 +0000 (18:20 +0000)]
XMLDB_UNSIGNED only applicable to number types. MDL-11662
Merged from MOODLE_19_STABLE
tjhunt [Fri, 7 Dec 2007 16:58:07 +0000 (16:58 +0000)]
MDL-12501 - Logic for including 'Grades' link in admin block is different for the logic in grade/report/index.php. Merged from MOODLE_19_STABLE.
sam_marshall [Fri, 7 Dec 2007 16:26:32 +0000 (16:26 +0000)]
MDL-12500 Fixed restore conversion for links in database templates
nicolasconnault [Fri, 7 Dec 2007 16:12:02 +0000 (16:12 +0000)]
MDL-11835 Making sure all upgraded grade_items have their grademax properly set
stronk7 [Fri, 7 Dec 2007 15:58:04 +0000 (15:58 +0000)]
Using new cross-db sql_isnotempty() function. MDL-12084
sam_marshall [Fri, 7 Dec 2007 11:11:44 +0000 (11:11 +0000)]
MDL-11845 Last checkin accidentally omitted a require_once (hopefully finally done now!!)
sam_marshall [Fri, 7 Dec 2007 10:24:00 +0000 (10:24 +0000)]
MDL-11845 Updated the three file downloads from Snoopy to download_file_content (which I didn't know about before :)
nicolasconnault [Fri, 7 Dec 2007 09:47:10 +0000 (09:47 +0000)]
MDL-11835 Alternating row colours for grader report
nicolasconnault [Fri, 7 Dec 2007 09:47:10 +0000 (09:47 +0000)]
MDL-11835 Alternating row colours for grader report
nicolasconnault [Fri, 7 Dec 2007 09:14:51 +0000 (09:14 +0000)]
MDL-11835 Changing default aggregateonlygraded back to true, but set this value to false for upgraded course categories. Also set grade display type to percentage for upgraded items, since this is the default setting in 1.8. Site default is Real display type.
fmarier [Fri, 7 Dec 2007 05:00:22 +0000 (05:00 +0000)]
weblib: Fix typo in print_table() which was causing invalid <th> tag
MDL-11506
toyomoyo [Fri, 7 Dec 2007 04:39:40 +0000 (04:39 +0000)]
customized cron should be in dirroot/local/cron.php
toyomoyo [Fri, 7 Dec 2007 04:07:42 +0000 (04:07 +0000)]
MDL-12373, restore should not try to restore pre 1.9 gradebook categories
toyomoyo [Fri, 7 Dec 2007 01:42:09 +0000 (01:42 +0000)]
MDL-12432, do not enable 'updated only' grades export for other plugins
mattc-catalyst [Fri, 7 Dec 2007 00:30:21 +0000 (00:30 +0000)]
MDL-12433: course/info respect the $CFG->allowvisiblecoursesinhiddencategories setting
Credit goes to Petr Kalis
mattc-catalyst [Thu, 6 Dec 2007 22:33:36 +0000 (22:33 +0000)]
MDL-12335: mod/lesson - fixed missing navigation links
sam_marshall [Thu, 6 Dec 2007 18:12:42 +0000 (18:12 +0000)]
MDL-11845 Support for config proxy options when downloading language packs (& other components), timezone file
poltawski [Thu, 6 Dec 2007 15:43:46 +0000 (15:43 +0000)]
MDL-12464 - if a glossary is deleted, it causes some breakage in the
random glossary block
Merged from MOODLE_19_STABLE
nicolasconnault [Thu, 6 Dec 2007 14:24:48 +0000 (14:24 +0000)]
MDL-11835 Changing default aggregateonlygraded to false
nicolasconnault [Thu, 6 Dec 2007 14:20:37 +0000 (14:20 +0000)]
MDL-11835 Changed upgradelib so that course category aggregation and grade category default aggregation are simple weighted mean
tjhunt [Thu, 6 Dec 2007 11:38:53 +0000 (11:38 +0000)]
MDL-12448 - Fix page_generic_activity->init_full() to use get_coursemodule_from_instance(). Merged from MOODLE_19_STABLE.
nicolasconnault [Thu, 6 Dec 2007 09:45:58 +0000 (09:45 +0000)]
MDL-11835 Merging from 1.9
skodak [Thu, 6 Dec 2007 09:21:55 +0000 (09:21 +0000)]
fixing unmerged files
nicolasconnault [Thu, 6 Dec 2007 09:17:28 +0000 (09:17 +0000)]
MDL-11835 Implemented all the default settings suggested in the pdf report, and turned down the size of the report table fonts.
skodak [Thu, 6 Dec 2007 08:44:07 +0000 (08:44 +0000)]
fixing unmerged files
toyomoyo [Thu, 6 Dec 2007 07:10:29 +0000 (07:10 +0000)]
MDL-12352, block/search fails to install on postgres
moodler [Thu, 6 Dec 2007 05:02:23 +0000 (05:02 +0000)]
Automatic installer.php lang files by installer_builder (
20071206 )
toyomoyo [Thu, 6 Dec 2007 03:57:05 +0000 (03:57 +0000)]
MDL-12451, in get_users_by_capability(), defaultroleid bit fixes
toyomoyo [Thu, 6 Dec 2007 01:08:25 +0000 (01:08 +0000)]
MDL-8270, fixing a warning
tjhunt [Wed, 5 Dec 2007 17:25:25 +0000 (17:25 +0000)]
MDL-12452 - not a fix I fear, just clarifying the comments about how this method is broken.
tjhunt [Wed, 5 Dec 2007 16:50:23 +0000 (16:50 +0000)]
MDL-12438 - followup - fix typos. Thanks to Dan Poltawski.
tjhunt [Wed, 5 Dec 2007 16:14:29 +0000 (16:14 +0000)]
MDL-12450 - Matching up roles on the restore settings form is broken - this is basically a complete rewrite of these two functions. Merged from MOODLE_19_STABLE.
diml [Wed, 5 Dec 2007 15:54:39 +0000 (15:54 +0000)]
fixing security hole. reference : http://moodle.org/mod/forum/discuss.php?d=85748#p379857
Inaki Arenzana
poltawski [Wed, 5 Dec 2007 14:33:10 +0000 (14:33 +0000)]
MDL-12446 - profile signup page not respect custom user profile field
sortorder
Merged from MOODLE_19_STABLE
nicolasconnault [Wed, 5 Dec 2007 09:35:19 +0000 (09:35 +0000)]
MDL-11835 Implemented changes discussed in http://moodle.org/mod/forum/discuss.php?d=85908. Also added item name and module name and category name (for category totals) in alt tags of icons
toyomoyo [Wed, 5 Dec 2007 07:49:56 +0000 (07:49 +0000)]
MDL-12430, if new and regrade are chosen, then preview hides 'old' students
toyomoyo [Wed, 5 Dec 2007 06:13:17 +0000 (06:13 +0000)]
MDL-12439 database preset fixes
toyomoyo [Wed, 5 Dec 2007 02:59:44 +0000 (02:59 +0000)]
MDL-12435, cancel in preferences form doesn't work
toyomoyo [Wed, 5 Dec 2007 01:13:29 +0000 (01:13 +0000)]
MDL-12437, sorting by names adds teacher to gradebook list
skodak [Tue, 4 Dec 2007 23:53:39 +0000 (23:53 +0000)]
MDL-12133 fixed regression in user advanced edit, sorry; merged from MOODLE_19_STABLE
mudrd8mz [Tue, 4 Dec 2007 21:52:16 +0000 (21:52 +0000)]
Merged from MOODLE_19_STABLE. Do not produce PHP warnings in case string file does not define array $string[]
tjhunt [Tue, 4 Dec 2007 17:29:47 +0000 (17:29 +0000)]
MDL-12438 - Print a develoer debug message if you call get_records with a non-unique first column. Merged from MOODLE_19_STABLE.
poltawski [Tue, 4 Dec 2007 12:57:02 +0000 (12:57 +0000)]
MDL-12415 - When we have more than one category/lots of courses the course
block shows two links next to search other (Search Courses/All courses)
which point to the same place....
The all courses link is able to be switched off and the search courses is not,
for this reason i've gone for removing the search courses link.
Merged from MOODLE_19_STABLE
sam_marshall [Tue, 4 Dec 2007 11:47:28 +0000 (11:47 +0000)]
MDL-12431 Added ability for filters to contain lang files
nicolasconnault [Tue, 4 Dec 2007 10:35:25 +0000 (10:35 +0000)]
MDL-12389 Removed the selectallornone element in favour of a more generic submitlink element. The checkbox controller is now added to a form using moodleform::add_checkbox_controller.
martinlanghoff [Tue, 4 Dec 2007 06:26:10 +0000 (06:26 +0000)]
datalib: get_logs_user*() - fix invalid SQL - MDL-12426
Oracle does not accept column labels in the GROUP BY section -
get_logs_usercourse() and get_logs_userday() were computing the
day/hours column and using it in the GROUP BY. The compatible fix
is to reproduce the same computation in the GROUP BY section.
Credit for the fix goes to Dennis Rochford <Dennis.Rochford@usq.edu.au>.
martinlanghoff [Tue, 4 Dec 2007 06:25:56 +0000 (06:25 +0000)]
blocks/online_users: Remove SQL "id,id" which causes errors on Oracle - MDL-12425
Credit for the fix goes to Dennis Rochford <Dennis.Rochford@usq.edu.au>
martinlanghoff [Tue, 4 Dec 2007 06:25:42 +0000 (06:25 +0000)]
mod/assignment: Remove SQL "id,id" which causes errors on Oracle - MDL-12425
This loop also needs some rewriting - it is _very_ inefficient on
large courses.
martinlanghoff [Tue, 4 Dec 2007 06:25:25 +0000 (06:25 +0000)]
accesslib: build_context_path() remove $temptable for Oracle too
The removal of $temptable was incomplete - and so build_context_path()
was broken on Oracle. MDL-11347
toyomoyo [Tue, 4 Dec 2007 05:10:12 +0000 (05:10 +0000)]
MDL-12399, shorten_text() truncates all closing tags