MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" Ooops. We do need highlighting on the reponses report. The responses page does have a grade displayed that needs highlighting. I was looking at an ungraded quiz. Need highlighting to highlight grade of graded attempt.
Reverted earlier patch and instead using a different colour for highlighting graded grade. Now using light yellow with a darker yellow border instead of green which is used in reports to highlight the correct answer.
MDL-16610 "Warnings when a question has a grade of 0" not seeing this issue in HEAD but committing some code to make code for generating html for response cell more robust.
MDL-16583 - Clean up javascript: Move some static scripts out of javascript.php and into javascript-static.js. Also, ensure the HTML editor JS is only included if the user has chosen to use the HTML editor.
MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" Ooops. We do need highlighting on the reponses report. The responses page does have a grade displayed that needs highlighting. I was looking at an ungraded quiz. Need highlighting to highlight grade of graded attempt.
Reverted earlier patch and instead using a different colour for highlighting graded grade. Now using light yellow with a darker yellow border instead of green which is used in reports to highlight the correct answer.
MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" Ooops. We do need highlighting on the reponses report. The responses page does have a grade displayed that needs highlighting. I was looking at an ungraded quiz. Need highlighting to highlight grade of graded attempt.
Reverted earlier patch and instead using a different colour for highlighting graded grade. Now using light yellow with a darker yellow border instead of green which is used in reports to highlight the correct answer.
MDL-16532 "Can width of column for Essay questions be varied?" Concatenate the answers displayed in all responses in responses report for answers above a certain character count (now set to 150). Also added a link to all responses to display a review of the question response. Both the concatenation and links are only showed in the report on the Moodle site and effects are not exported.
MDL-16625 Detection of whether a quiz has grades was broken in HEAD.
1. Fix this by factoring out a quiz_has_grades function.
2. Fix the quiz unit tests.
3. Fix quiz_has_feedback to return false for ungraded quizzes.
4. Fix use of get_records to do record_exists in quiz reports.
MDL-13894 Impoved fix with less duplicated code, no notices displayed before you get to the 'New settings' screen, and named constants instead of magic numbers.
MDL-14739: upgrade tinymce from 3.0.9 to 3.2.0.1. This fixes numerous bugs in TinyMCE. Also removed some cruft, removed in previous
versions of the editor.
I did some further work tidying up the form. I also just treat the popup like another plugin and moved all the config into the plugin.
This still needs help buttons everywhere now!
MDL-15680 Began implementing a simple YUI treeview of the grade items in their categories. Will tweak this to become a form with weights in input fields, and possible drag and drop also
MDL-16606 "userdate inserts a space in front of date when chopping off the leading 0 on day of the month produced by %d"
extra space was used in front of %d so that we can detect the difference between a leading 0 and something like 10, 20, or 30. The extra space was removed along with any leading 0 but not if there was no leading zero.
Now removing extra space even if there is no leading zero.
Now applying fix to conditional branch for when using a time offset from GMT instead of server time.
MDL-16606 "userdate inserts a space in front of date when chopping off the leading 0 on day of the month produced by %d"
extra space was used in front of %d so that we can detect the difference between a leading 0 and something like 10, 20, or 30. The extra space was removed along with any leading 0 but not if there was no leading zero.
Now removing extra space even if there is no leading zero.
MDL-16527 "responses report : use question_get_feedback_class and question_get_feedback_image from questionlib.php instead of custom styles" should not style response or add feedback image if the response is not yet graded.
MDL-16596 file listing methods now return arrays index with pathnamehash (useful when looking for existing files); create from stored file now supports directories too - very useful when moving files between areas
MDL-16486 Implemented the proxy DB class. Sort of working, but still some issues to sort out, like fix_course_sort_order, which updates a record NOT inserted by the unit test.