martinlanghoff [Wed, 14 Nov 2007 22:04:05 +0000 (22:04 +0000)]
accesslib: Move check_enrolment_plugins() to complete_user_login()
... where it belongs ;-)
load_all_capabiloties() gets called at several points where we don't
want to be re-querying the enrolment backends. It needs to be called
before load_all_capabilities() and only by callers that are setting up
a logon session.
Those callers need to be calling complete_user_login() anyway, as they
need to set the Moodle cookie, log the logon action, etc. In fact,
those callers duplicate a lot of that code already.
The callers that don't duplicate code for the login are actually the
cases where the backend enrolment plugins should not be queried.
To be followed by callers cleanup...
martinlanghoff [Wed, 14 Nov 2007 22:03:46 +0000 (22:03 +0000)]
login/index, moodlelib: move session setup logic to complete_user_login()
Move most of the user session setup logic from login/index.php to
complete_user_login().
mudrd8mz [Wed, 14 Nov 2007 21:36:16 +0000 (21:36 +0000)]
Merged MDL-11332 from stable.
tjhunt [Wed, 14 Nov 2007 17:03:32 +0000 (17:03 +0000)]
MDL-12066 - Links in the HTML block are not recoded on backup and restore.
This is messy because the links are hidden in the configdata column, which is serialized and base64encoded. So we have to untangle that, then ask the block whether there are any bits of $config that need to be fixed, then re-encode it before backup up. And reverse that on restore. It needs to remain base64 encoded in the backup file, so that the file format is backwards compatible.
I disucssed this with Eloy before doing it.
Merged from MOODLE_19_STABLE.
tjhunt [Wed, 14 Nov 2007 16:34:26 +0000 (16:34 +0000)]
MDL-12172 - print_continue should create a method="get" button, not post. Merged from MOODLE_19_STABLE.
urs_hunkler [Wed, 14 Nov 2007 16:06:58 +0000 (16:06 +0000)]
merged from 1.9 :: added 2 CSS definitions to dimm the summary and the course no. in a hidden course topic.
tjhunt [Wed, 14 Nov 2007 14:48:50 +0000 (14:48 +0000)]
Delete commented-out code that was actually not commented out properly, and so caused warnings. Merged from MOODLE_18_STABLE.
bobopinna [Wed, 14 Nov 2007 13:10:34 +0000 (13:10 +0000)]
MDL-12118 Fixed learner_response report. It was changed by SCORM2004 3rd Ed. specification
skodak [Wed, 14 Nov 2007 11:52:21 +0000 (11:52 +0000)]
MDL-12146 grade category defaults, forced settings and advanced options, merged from MOODLE_19_STABLE
bobopinna [Wed, 14 Nov 2007 09:52:16 +0000 (09:52 +0000)]
Fixed MDL-11914
toyomoyo [Wed, 14 Nov 2007 05:07:33 +0000 (05:07 +0000)]
removing duplicate entries in grade_grades prior to adding unique key
toyomoyo [Wed, 14 Nov 2007 02:12:40 +0000 (02:12 +0000)]
MDL-12140, making most common non-weighted and weighted settings easy for teachers
martinlanghoff [Wed, 14 Nov 2007 01:25:20 +0000 (01:25 +0000)]
htmlarea: fix in FF - MDL-11242
The previous fix for IE left some problems in the FF side of
things because we were trying additions/substractions on
width once its had turned to a string of value + unit.
Do the math before we attach 'px' to it...
fmarier [Wed, 14 Nov 2007 01:13:37 +0000 (01:13 +0000)]
mod/quiz: Revert commit which added the "go back to course" link
poltawski [Tue, 13 Nov 2007 20:03:27 +0000 (20:03 +0000)]
Adding a comment pointing to MDL-3964 which explains why we leave the
badword in the filter span title (as I almost 'fixed it' so it couldn't
be hovered over)
nicolasconnault [Tue, 13 Nov 2007 19:12:37 +0000 (19:12 +0000)]
Fixing a few bugs identified by Petr and attacking grade_item unit tests
mchurch [Tue, 13 Nov 2007 18:07:23 +0000 (18:07 +0000)]
MDL-11991 Fixing error on undefined method while using the manual plug-in.
nfreear [Tue, 13 Nov 2007 17:16:54 +0000 (17:16 +0000)]
Follow up fix for MDL-7878 "Link identification and skipping" (and MDL-9306 "Replaced weeks..") - duplicate skip_main_destination().
mchurch [Tue, 13 Nov 2007 17:02:53 +0000 (17:02 +0000)]
MDL-12149 Added code to check for selected group as well, so that privileged users get correct count when changing groups.
skodak [Tue, 13 Nov 2007 16:47:33 +0000 (16:47 +0000)]
MDL-12154 used proper cast to float before !== comparison merged from MOODLE_19_STABLE
skodak [Tue, 13 Nov 2007 16:08:39 +0000 (16:08 +0000)]
MDL-12154 used proper cast to float before !== comparison
mchurch [Tue, 13 Nov 2007 16:01:44 +0000 (16:01 +0000)]
MDL-12114 Fixed typo in elements array.
skodak [Tue, 13 Nov 2007 15:32:16 +0000 (15:32 +0000)]
MDL-10901 new SUM aggregation type
MDL-12154 used proper cast to float before !== comparison
part 2
skodak [Tue, 13 Nov 2007 15:08:59 +0000 (15:08 +0000)]
MDL-10901 new SUM aggregation type
MDL-12154 used proper cast to float before !== comparison
nfreear [Tue, 13 Nov 2007 14:46:44 +0000 (14:46 +0000)]
MDL-12153, "Validome - moodle.org invalid - require Content-Script-Type".
nicolasconnault [Tue, 13 Nov 2007 13:44:27 +0000 (13:44 +0000)]
Restoring some of the static calls which were converted unnecessarily
urs_hunkler [Tue, 13 Nov 2007 10:33:04 +0000 (10:33 +0000)]
merged from 1.9 :: removed CSSEdit reference line.
nicolasconnault [Tue, 13 Nov 2007 10:31:08 +0000 (10:31 +0000)]
More fine-tuning of gradebook classes
nicolasconnault [Tue, 13 Nov 2007 09:08:43 +0000 (09:08 +0000)]
Managed to remove static calls from the core gradebook classes without removing support for such calls in gradebook interface code. I used a singleton pattern for this (get_instance in grade_object).
moodler [Tue, 13 Nov 2007 08:46:52 +0000 (08:46 +0000)]
Merged fixes from 1.9 MDL-12145
skodak [Tue, 13 Nov 2007 08:43:20 +0000 (08:43 +0000)]
MDL-12101 cleanup/fixing/refactoring of user bulk operation and admin user browsing
nicolasconnault [Tue, 13 Nov 2007 07:36:00 +0000 (07:36 +0000)]
Managed to remove static calls from the core gradebook classes without removing support for such calls in gradebook interface code. I used a singleton pattern for this (get_instance in grade_object).
toyomoyo [Tue, 13 Nov 2007 06:55:37 +0000 (06:55 +0000)]
merged, adding vertical and horizontal highlight
toyomoyo [Tue, 13 Nov 2007 03:19:12 +0000 (03:19 +0000)]
MDL-12124, fixing styles for grader report
toyomoyo [Tue, 13 Nov 2007 03:07:48 +0000 (03:07 +0000)]
MDL-12138, set aggregate graded only as default
toyomoyo [Tue, 13 Nov 2007 02:53:18 +0000 (02:53 +0000)]
MDL-12141, category names should be mandatory
martinlanghoff [Tue, 13 Nov 2007 00:34:47 +0000 (00:34 +0000)]
admin: Introducing the mailout-debugger
A stand-in for sendmail that will log all emails instead of sending
them out. Use when debugging cron performance and output.
References:
MDL-12142
http://moodle.org/mod/forum/post.php?reply=349457
urs_hunkler [Mon, 12 Nov 2007 20:22:04 +0000 (20:22 +0000)]
merged from 1.9 :: The XHTML of the actual tab has been changed. Therefor the actual tab was not shown in front of the line any more. I changed the CSS to correct this introduced bug.
mits [Mon, 12 Nov 2007 17:56:07 +0000 (17:56 +0000)]
some tidy up on theme OceanBlue.
skodak [Mon, 12 Nov 2007 17:21:00 +0000 (17:21 +0000)]
MDL-12131 db debug messages now quoted properly
skodak [Mon, 12 Nov 2007 17:12:35 +0000 (17:12 +0000)]
MDL-12130 and MDL-12129 - fixed advanced status of elements when header not closed; disableIf now works inside grouped elements too; code cleanup in focus() and _getElNamesRecursive()
nfreear [Mon, 12 Nov 2007 16:53:53 +0000 (16:53 +0000)]
Fixes MDL-12125, Call to a member function FetchRow on a non-object in get_user_access_sitewide.
urs_hunkler [Mon, 12 Nov 2007 11:40:52 +0000 (11:40 +0000)]
merged from 1.9 :: MDL-12093 :: changed function call from get_in_popup to is_in_popup.
urs_hunkler [Mon, 12 Nov 2007 11:17:24 +0000 (11:17 +0000)]
merged from 1.9 :: MDL-12093
gbateson [Mon, 12 Nov 2007 08:54:35 +0000 (08:54 +0000)]
fix for MDL-9713 : use XMLDB functions to create tables when mod/hotpot/db/mysql.sql is not found. This allows upgrade direct from Moodle 1.5 (or earlier) to Moodle 1.8 (or later)
toyomoyo [Mon, 12 Nov 2007 06:27:42 +0000 (06:27 +0000)]
MDL-9059, when teacher creates group event on calendar, they can not see it
martinlanghoff [Mon, 12 Nov 2007 04:13:24 +0000 (04:13 +0000)]
htmlarea: Fix fullscreen editor on IE6/7 -- MDL-11242
Only say px if the width is a pure number. Under IE we
get the "100%" for the width of the editor, so blindly
appending "px" results in a JS execution error.
With this patch we only attach px if it's a pure int.
Also tested the sizing of HTMLArea in the messaging
window. So both should be working now.
toyomoyo [Mon, 12 Nov 2007 03:14:47 +0000 (03:14 +0000)]
MDL-12104, gradebook is showing 2 scales together
urs_hunkler [Sun, 11 Nov 2007 19:34:37 +0000 (19:34 +0000)]
merged from 1.9 :: MDL-10683 :: added as Eric proposed:
.mform .ftextarea #id_alltext {
width: 100%;
}
urs_hunkler [Sun, 11 Nov 2007 19:26:20 +0000 (19:26 +0000)]
merged from 1.9 :: moved the sideblock accessibility property to the sidblocks section.
urs_hunkler [Sun, 11 Nov 2007 17:30:52 +0000 (17:30 +0000)]
merged from 1.9 :: added the clearfix option to the custom_corners call for admin pages to keep the "Save Changes" button within the area.
urs_hunkler [Sun, 11 Nov 2007 16:04:08 +0000 (16:04 +0000)]
merged from 1.9 :: Some theme enhancements while working on MDL-12098 and MDL-11154.Some theme enhancements while working on MDL-12098 and MDL-11154.
urs_hunkler [Sun, 11 Nov 2007 15:04:34 +0000 (15:04 +0000)]
merged from 1.9 :: Added the check, if all opend custom_corners are closed. This way it's possible to add the close call in the footer which closes eventually open ccs.
urs_hunkler [Sun, 11 Nov 2007 11:22:54 +0000 (11:22 +0000)]
merged form 1.9 and corrected a CSS bug :: MDL-12045 :: the extra "clearer" div broke the custom_corners theme on IE7. I removed the "clearer" div and added the class "clerafix" to the surrounding coursebox.
In FF and Safari floating is a mess now. I removed float:left for "coursebox" to get the page working in all browsers. It is a single element and should not need floating.
urs_hunkler [Sun, 11 Nov 2007 09:31:41 +0000 (09:31 +0000)]
merged from 1.9 :: added missing "if ($heading)" to suppress empty page header.
mark-nielsen [Sun, 11 Nov 2007 01:26:46 +0000 (01:26 +0000)]
Merging fix for MDL-12088 from MOODLE_19_STABLE
skodak [Sat, 10 Nov 2007 14:54:39 +0000 (14:54 +0000)]
MDL-12079 fixed use of clean_param()
urs_hunkler [Sat, 10 Nov 2007 14:53:54 +0000 (14:53 +0000)]
merged from 1.9 :: MDL-12093 :: added function get_in_popup()
skodak [Sat, 10 Nov 2007 14:49:56 +0000 (14:49 +0000)]
MDL-12079 fixed use of clean_param()
skodak [Sat, 10 Nov 2007 14:35:26 +0000 (14:35 +0000)]
MDL-12092 removed newline chars, we do not know the admin's platform, one line should be ok IMHO.
stronk7 [Fri, 9 Nov 2007 20:11:43 +0000 (20:11 +0000)]
New profilefield_ lang files are now supported with
safe fallback to the "old" ones (stored in admin.php)
Merged from MOODLE_19_STABLE
stronk7 [Fri, 9 Nov 2007 19:11:40 +0000 (19:11 +0000)]
Adding lang support within profile fields to make them selfcontained.
Merged from MOODLE_19_STABLE
toyomoyo [Fri, 9 Nov 2007 02:57:05 +0000 (02:57 +0000)]
MDL-12044, adding missing string
toyomoyo [Fri, 9 Nov 2007 01:39:34 +0000 (01:39 +0000)]
MDL-12065, do not force parents to enrol in student courses
fmarier [Fri, 9 Nov 2007 01:25:28 +0000 (01:25 +0000)]
Add missing fields when upgrading/installing on Postgres
mod/exercise, mod/scorm and question/type/rqp
MDL-12023
fmarier [Fri, 9 Nov 2007 01:17:48 +0000 (01:17 +0000)]
mod/quiz: Add a link back to the course page after a quiz is completed
poltawski [Thu, 8 Nov 2007 22:19:47 +0000 (22:19 +0000)]
MDL-12070 - PARAM_CLEANHTML strips magic quotes..
poltawski [Thu, 8 Nov 2007 18:32:09 +0000 (18:32 +0000)]
MDL-12070 - re-enable the use of HTML in choice options
Merged from MOODLE_18_STABLE
sam_marshall [Thu, 8 Nov 2007 17:01:35 +0000 (17:01 +0000)]
MDL-12072 Added heading tag for calendar 'blocks'
sam_marshall [Thu, 8 Nov 2007 15:16:16 +0000 (15:16 +0000)]
MDL-12069 Make calendar events key labels and link titles consistent (also tidy up one bit of duplicated code)
skodak [Thu, 8 Nov 2007 08:59:26 +0000 (08:59 +0000)]
MDL-10365 grade history can be turned off + lifetime
toyomoyo [Thu, 8 Nov 2007 05:52:47 +0000 (05:52 +0000)]
keeping version number in sync
nicolasconnault [Thu, 8 Nov 2007 05:43:15 +0000 (05:43 +0000)]
MDL-9306 upgrade.php set to upgrade course whose format is weekscss to weeks
toyomoyo [Thu, 8 Nov 2007 05:38:01 +0000 (05:38 +0000)]
MDL-12061, <p> in html editor breaks xhtml strict
toyomoyo [Thu, 8 Nov 2007 05:13:18 +0000 (05:13 +0000)]
1.9 Beta 2 should not be read as 1.9.2 in environment page
moodler [Thu, 8 Nov 2007 05:11:47 +0000 (05:11 +0000)]
Automatic installer.php lang files by installer_builder (
20071108)
nicolasconnault [Thu, 8 Nov 2007 04:39:10 +0000 (04:39 +0000)]
MDL-11790 Fixed hard-coded strings. Merci Nicolas!
toyomoyo [Thu, 8 Nov 2007 02:01:34 +0000 (02:01 +0000)]
merged fix for MDL-11909, putting a unique constraint userid-itemid on grade_grades table
urs_hunkler [Wed, 7 Nov 2007 18:12:54 +0000 (18:12 +0000)]
merged from 1.9 :: In the first table column class="header" was missing.
nicolasconnault [Wed, 7 Nov 2007 17:59:33 +0000 (17:59 +0000)]
Unit test refactoring using mock objects. NOT FINISHED: testgradecategory and testgradeitem are incomplete. The other tests work great however, and no longer a need for DB data
nfreear [Wed, 7 Nov 2007 17:45:57 +0000 (17:45 +0000)]
Follow up fixes MDL-12029 "Glossary view needs heading markup..."
sam_marshall [Wed, 7 Nov 2007 17:33:12 +0000 (17:33 +0000)]
MDL-12055 Tweaked forum subscribe 'continue' address
sam_marshall [Wed, 7 Nov 2007 17:04:48 +0000 (17:04 +0000)]
MDL-12055 Tweaked forum subscribe 'continue' address
ethem [Wed, 7 Nov 2007 15:57:23 +0000 (15:57 +0000)]
Fix for refactoring
Fatal error: Call to undefined method enrolment_plugin_authorize::print_enrolmentkeyfrom() in /usr/local/www/data/moodle/enrol/manual/enrol.html on line 7
tjhunt [Wed, 7 Nov 2007 15:41:20 +0000 (15:41 +0000)]
Minor whitespace fixup.
tjhunt [Wed, 7 Nov 2007 15:26:37 +0000 (15:26 +0000)]
Eliminate duplicate $Id$ tag. Merged from MOODLE_19_STABLE.
tjhunt [Wed, 7 Nov 2007 15:20:57 +0000 (15:20 +0000)]
Eliminate duplicate $Id$ tag. Merged from MOODLE_19_STABLE.
tjhunt [Wed, 7 Nov 2007 12:35:33 +0000 (12:35 +0000)]
Eliminate duplicate $Id$ tag. Merged from MOODLE_19_STABLE.
ethem [Wed, 7 Nov 2007 10:54:28 +0000 (10:54 +0000)]
Access modifiers.
ethem [Wed, 7 Nov 2007 10:24:35 +0000 (10:24 +0000)]
Access modifiers.
ethem [Wed, 7 Nov 2007 10:22:37 +0000 (10:22 +0000)]
Preparation for Moodle 2.
toyomoyo [Wed, 7 Nov 2007 07:46:33 +0000 (07:46 +0000)]
MDL-12025, enable row markings via javascript to keep track of current row
moodler [Wed, 7 Nov 2007 07:17:11 +0000 (07:17 +0000)]
Merged small emglish fix from stable branches
toyomoyo [Wed, 7 Nov 2007 04:29:15 +0000 (04:29 +0000)]
MDL-12048, assignment grades not migrated into 1.9
toyomoyo [Wed, 7 Nov 2007 01:11:41 +0000 (01:11 +0000)]
backup/restore of grade histories should be off by default
nfreear [Tue, 6 Nov 2007 17:46:15 +0000 (17:46 +0000)]
Fixes MDL-7878 in new course format, "Link identification and skipping" - skip_main_destination function + use the $currenttext string (MDL-11439) - both accessibility related.
jmg324 [Tue, 6 Nov 2007 15:56:00 +0000 (15:56 +0000)]
fixes notice error caused in form validation of file attachments - need not assume variable is set but use empty()
sam_marshall [Tue, 6 Nov 2007 15:49:03 +0000 (15:49 +0000)]
MDL-12039 Added ability to configure alt text when using TeX filter
jmg324 [Tue, 6 Nov 2007 15:34:19 +0000 (15:34 +0000)]
fixes notice error in forum/user about image alt
nicolasconnault [Tue, 6 Nov 2007 14:01:13 +0000 (14:01 +0000)]
MDL-9306 Applied Ann's patches: seems to work very well, the output is entirely XHTML compliant, and displays really nicely.