urs_hunkler [Sat, 13 Oct 2007 09:16:46 +0000 (09:16 +0000)]
Merged from 1.9 ::
MDL-11729 :: Removed commenting out loading of the Chameleon files loading.
MDL-11664 :: IE6 can't display transparent PNGs. Added not transparent gifs instead and changed the background for IE6 to a solid colour.
tjhunt [Fri, 12 Oct 2007 15:55:49 +0000 (15:55 +0000)]
MDL-11741 - Convert core modules to take advantage of recent improvements to build_navigation.
This check-in removes about 400 lines of code. I hope I have not screwed anything up. I would be grateful if people could review this change, and keep an eye on the navigation bar in modules.
Any navigation bar bugs you find in the near future, feel free to file them in the tracker and assign them to me. Thanks.
If not to many problems are found, I think I would like to backport this to 1.9 stable, but I am not sure that is a good idea. Opinions to the General Developer Forum please. I am about to start a thread there.
tjhunt [Fri, 12 Oct 2007 10:36:11 +0000 (10:36 +0000)]
MDL-11699 - Further, backwards-compatible, improvement to the build navigation API to simplify a common case. Also, further improvements to the doc comment, so it is easy to use. Merged from MOODLE_19_STABLE.
tjhunt [Thu, 11 Oct 2007 11:52:34 +0000 (11:52 +0000)]
MDL-11699 - Addendum - rewrite the other half of the function too, so I can understand what it is doing, and fix a couple of minor logic errors along the way. Merged from MOODLE_19_STABLE.
jamiesensei [Wed, 10 Oct 2007 15:23:24 +0000 (15:23 +0000)]
fix for MDL-11692. There were notices about subquestions not being defined. This seems to indicate that there is a problem elsewhere that somehow matching questions without subquestions are in the site db. But suppressed the notice by testing to see if subquestions is set before looping through the questions.
tjhunt [Wed, 10 Oct 2007 14:00:41 +0000 (14:00 +0000)]
MDL-11699 - Make build_navigation more helpful by having it optionally build the activity and activityinstance links too, if you pass a $cm object. Note that this only does extra DB queries if you do pass a $cm object, and it does not have all the required fields, but in this case it will winge at you in developer debug mode. If you get your $cm using get_coursemodule_from_instance or get_coursemodule_from_id, which is best practice these days, then you won't have a problem.
skodak [Wed, 10 Oct 2007 11:03:00 +0000 (11:03 +0000)]
MDL-11694 adding error displaying into installer, it does not affect the debug and error displaying in final installation
MDL-11432 eliminated RecordCount
skodak [Wed, 10 Oct 2007 08:33:06 +0000 (08:33 +0000)]
MDL-11688 makes sure all course and user contexts exist during upgrade (all contexts when going from in 1.6) - this is needed for grade_letter upgrade; other minor tweaks - the USER->access is now loaded automatically, feedback parameters added
toyomoyo [Wed, 10 Oct 2007 06:43:23 +0000 (06:43 +0000)]
MDL-11667, adding 2 global variables to set default export decimal point and display format. During export there are 2 new settings for decimal points and display format, default to site setting. Removed letter option because it is a format that you can choose now.
moodler [Wed, 10 Oct 2007 02:52:25 +0000 (02:52 +0000)]
Added a timemodified field to forum_queue, and we now delete records
that are older than a week before processing digests.
After upgrade it's possible that some posts will be lost this way but
on the other hand it ensures that sites with problems like moodle.org
had will start working again.
We still need a recordset added to the digestposts loop.
There are multiple issues with Moodle files containing empty or blank lines
(lines consisting of white spaces or tabs only) and/or white space before or
after the PHP open and close tags, notably with config.php and theme files.
skodak [Tue, 9 Oct 2007 16:07:15 +0000 (16:07 +0000)]
MDL-11660
* user_lastaccess deleted when deleting course
* rewritten deleting of contexts - does not use get_context_instance() anymore because it is much more strict now
* added deleting of grade_letters and settings when deleting course
tjhunt [Tue, 9 Oct 2007 15:19:07 +0000 (15:19 +0000)]
MDL-11617 - 'Student may review' heading on quiz settings form is now misleading. I have fixed some lang strings and improved the help. Also, finish off the clarification of how various capabilites affect quiz review that was started in MDL-11580.
nicolasconnault [Tue, 9 Oct 2007 14:08:05 +0000 (14:08 +0000)]
MDL-11608 The $rename param was obtained with PARAM_NOTAG, I changed that to PARAM_RAW. I also changed the rename field's value to htmlspecialchars($category->name)
skodak [Tue, 9 Oct 2007 12:49:54 +0000 (12:49 +0000)]
MDL-11640
* improved handling of dirty contexts in general - caching, switching in cron, marking, loading, etc.
* role_assing() and role_unassign() now marks dirty contexts because we use has_capability() in this function - we can not do it later outside to speedup bulk operations
* fixed some inline docs
* fixed notice from rs closing
* removed cached $CONTEXT from has_capability() - $context is now required parameter; this was hiding serious bugs when context did not exist or ppl passed false as parameter
* removed some ===, we can not use these on function parameters - we must support ints, strings, '', nulls, etc. - this could be a source of really dangerous bugs in future
* some other improvements and fixes - documented inline
toyomoyo [Tue, 9 Oct 2007 05:43:35 +0000 (05:43 +0000)]
MDL-11665, users with no grade:viewhidden capability gets a wrong upgrade count because after deletion of a grade, the grade can be NULL and not hidden at the same time
skodak [Mon, 8 Oct 2007 23:09:10 +0000 (23:09 +0000)]
MDL-11578 , MDL-11578 , MDL-11573 :
* renamed Preferences to "My report preferences"
* renamed Site defaults to "Report defaults"
* rename Change site defaults to "Change report defaults"
* reintroduced Inherit option to Grader preferences - Nicolas was right, it is not possible to implement preference overrides without it with our current get_pref inplementation
* new separate option in plugin selector "Course settings"
* moved displaytype, decimals and aggregation position to "Course settings"
* created new table grade_settings + related functions grade_get/set_preference()
* user report now uses grade_seq class instead of grade_item::fetch_all(); added preloading of grade items into grade_grade instances
* other minor bugfixing/cleanup/improvements
Please note that the Grader report preferences and its defaults must be resaved again - sorry.
projects / moodle.git / log