]>
git.mjollnir.org Git - moodle.git/log
David Mudrak [Mon, 4 Jan 2010 18:22:58 +0000 (18:22 +0000)]
workshop: fixed link to the attachment in a folder
David Mudrak [Mon, 4 Jan 2010 18:22:47 +0000 (18:22 +0000)]
MDL-20058 workshop grading report fixes and small improvements
David Mudrak [Mon, 4 Jan 2010 18:22:37 +0000 (18:22 +0000)]
Do not display given grade before the workshop is closed
David Mudrak [Mon, 4 Jan 2010 18:22:27 +0000 (18:22 +0000)]
Replaced develtools with a temporary loginas tab
David Mudrak [Mon, 4 Jan 2010 18:22:10 +0000 (18:22 +0000)]
workshop: general cleanup
Moving stuff from lib.php into static methods in localib.php. Removing
things from workshop core that were implemented in a subplugin. Dropping
stuff related to features not to be implemented in 2.0.
David Mudrak [Mon, 4 Jan 2010 18:21:42 +0000 (18:21 +0000)]
MDL-19930 workshop: comments grading strategy
David Mudrak [Mon, 4 Jan 2010 18:21:24 +0000 (18:21 +0000)]
Rough search and replace accumulative > comments
David Mudrak [Mon, 4 Jan 2010 18:21:04 +0000 (18:21 +0000)]
Initial copy of form/accumulative code
David Mudrak [Mon, 4 Jan 2010 18:20:24 +0000 (18:20 +0000)]
Assessments overrides and feedbacks
This requires the patch of MDL-20623 to be applied
David Mudrak [Mon, 4 Jan 2010 18:20:10 +0000 (18:20 +0000)]
Frozen grid rubric layout fix
David Mudrak [Mon, 4 Jan 2010 18:19:58 +0000 (18:19 +0000)]
VIP Assessment review
David Mudrak [Mon, 4 Jan 2010 18:19:48 +0000 (18:19 +0000)]
Fixed submission grade aggregation
Overriding the submission grade influence the total grade, not the
aggregated one.
David Mudrak [Mon, 4 Jan 2010 18:19:37 +0000 (18:19 +0000)]
Assessment form preview handled by a dedicated script
This was part of assessment.php but it makes the things too complicated.
David Mudrak [Mon, 4 Jan 2010 18:19:24 +0000 (18:19 +0000)]
eval/best/ is officially called 'Comparison with the best assessment'
David Mudrak [Mon, 4 Jan 2010 18:19:13 +0000 (18:19 +0000)]
Allow opening assessment forms in read-only mode
David Mudrak [Mon, 4 Jan 2010 18:18:53 +0000 (18:18 +0000)]
Remember the recently used grading evaluation settings
David Mudrak [Mon, 4 Jan 2010 18:18:30 +0000 (18:18 +0000)]
Grading evaluation is now configurable on-the-fly
David Mudrak [Mon, 4 Jan 2010 18:18:00 +0000 (18:18 +0000)]
Workshop total grade calculation support
David Mudrak [Mon, 4 Jan 2010 18:17:47 +0000 (18:17 +0000)]
Display real grade values in the grading report
David Mudrak [Mon, 4 Jan 2010 18:17:37 +0000 (18:17 +0000)]
Grading grades aggregations
David Mudrak [Mon, 4 Jan 2010 18:17:27 +0000 (18:17 +0000)]
Faking assessments reworked
David Mudrak [Mon, 4 Jan 2010 18:17:17 +0000 (18:17 +0000)]
Fixed regression and broken interafce implementation
David Mudrak [Mon, 4 Jan 2010 18:17:03 +0000 (18:17 +0000)]
Getting rid of supports_evaluation()
This seems to be over-desing-patternized. Methods needed by standard
eval plugins (ie part of standard distribution) are part of strategy
API. Contributed eval methods will have to patch strategy plugins if
they need some other data from them.
David Mudrak [Mon, 4 Jan 2010 18:16:41 +0000 (18:16 +0000)]
Methods to get info about assessments and dimensions are part of strategy API
David Mudrak [Mon, 4 Jan 2010 18:16:23 +0000 (18:16 +0000)]
Pagination a sorting fix
David Mudrak [Mon, 4 Jan 2010 18:16:13 +0000 (18:16 +0000)]
Rubric: fixed best evaluation support
David Mudrak [Mon, 4 Jan 2010 18:16:02 +0000 (18:16 +0000)]
MDL-19932 Rubric grading strategy implemented
The only weak point here is that we store a raw grade into
workshop_grades and not a direct id of the selected level. Therefore,
when re-assessing, we need to actually guess what level the assessor
chose previously. This is not problem if there are not two levels with
the same grade. Such case is not common when using Rubric. In the
future, this may get refactored so Rubric would use its own storage of
filled assessment forms.
David Mudrak [Mon, 4 Jan 2010 18:15:48 +0000 (18:15 +0000)]
Moving some helper functions from the renderer to the workshop API
David Mudrak [Mon, 4 Jan 2010 18:15:38 +0000 (18:15 +0000)]
MDL-19932 First drafts of Rubric strategy
Assessment form editing should work
David Mudrak [Mon, 4 Jan 2010 18:15:24 +0000 (18:15 +0000)]
Parameter consistency check
David Mudrak [Mon, 4 Jan 2010 18:15:14 +0000 (18:15 +0000)]
Constant name fixed and improved empty input check
David Mudrak [Mon, 4 Jan 2010 18:15:00 +0000 (18:15 +0000)]
Fixed a table name
David Mudrak [Mon, 4 Jan 2010 18:14:49 +0000 (18:14 +0000)]
Initial commit of rubric code, copied from accumulative
David Mudrak [Mon, 4 Jan 2010 18:14:12 +0000 (18:14 +0000)]
Fixed a phpDoc param type
David Mudrak [Mon, 4 Jan 2010 18:14:01 +0000 (18:14 +0000)]
Grading evaluation - best subplugin
I am not happy with the algorithm at all. We should replace it with some
more sophisticated subplugin, using ICC or some similar statistics.
David Mudrak [Mon, 4 Jan 2010 18:13:42 +0000 (18:13 +0000)]
Renamed unittest files and a small change due to evaluation
David Mudrak [Mon, 4 Jan 2010 18:13:17 +0000 (18:13 +0000)]
Call the parent's constructor in renderers
David Mudrak [Mon, 4 Jan 2010 18:13:04 +0000 (18:13 +0000)]
Grading report - columns sorting support
David Mudrak [Mon, 4 Jan 2010 18:12:54 +0000 (18:12 +0000)]
Unit tests for workshop::aggregate_submission_grades_process()
David Mudrak [Mon, 4 Jan 2010 18:12:44 +0000 (18:12 +0000)]
aggregate_submission_grades() refactoring to allow unit testing
David Mudrak [Mon, 4 Jan 2010 18:12:32 +0000 (18:12 +0000)]
Improved the workshop constructor to support unit testing
Thanks to Tim Hunt for the hint.
David Mudrak [Mon, 4 Jan 2010 18:12:12 +0000 (18:12 +0000)]
MDL-20264 work in progress on grading evaluation support
Also fixes small bugs in workshop api constructor and in using "scales"
instead of "scale" for the core table name.
David Mudrak [Mon, 4 Jan 2010 18:11:48 +0000 (18:11 +0000)]
MDL-20058 Grading report, aggregation of submission grades
Not finished yet
David Mudrak [Mon, 4 Jan 2010 18:11:35 +0000 (18:11 +0000)]
Improved context handling
Getting a context from instance is very cheap and I can actually do it
just once when constructing the workshop API class. In the future, I
will get rid of all $PAGE->context which is actually meant for things
like blocks etc.
David Mudrak [Mon, 4 Jan 2010 18:11:22 +0000 (18:11 +0000)]
Assessment weight DEFAULTs to 1
David Mudrak [Mon, 4 Jan 2010 18:11:11 +0000 (18:11 +0000)]
Added an important documentation to a capability
David Mudrak [Mon, 4 Jan 2010 18:11:02 +0000 (18:11 +0000)]
Display a button to run aggregation process
David Mudrak [Mon, 4 Jan 2010 18:10:52 +0000 (18:10 +0000)]
Added timeaggregated time stamp
David Mudrak [Mon, 4 Jan 2010 18:10:42 +0000 (18:10 +0000)]
Added new helpfile (just for testing purposes)
David Mudrak [Mon, 4 Jan 2010 18:10:28 +0000 (18:10 +0000)]
Work in progress: grading report refactoring
David Mudrak [Mon, 4 Jan 2010 18:10:18 +0000 (18:10 +0000)]
Adding percent_to_value() helper + its unittests
David Mudrak [Mon, 4 Jan 2010 18:10:08 +0000 (18:10 +0000)]
Fixed the id of the string from null to nullgrade
David Mudrak [Mon, 4 Jan 2010 18:09:58 +0000 (18:09 +0000)]
Preparing for the future feature to let the user to set users per page
David Mudrak [Mon, 4 Jan 2010 18:09:48 +0000 (18:09 +0000)]
Adding new table workshop_aggregations
This table replaces the recently added workshop_evaluations and will
contain all grades aggregations done within a workshop activity. NULL
grades mean not aggregated yet.
David Mudrak [Mon, 4 Jan 2010 18:09:38 +0000 (18:09 +0000)]
Fixed an OUTPUT issue
David Mudrak [Mon, 4 Jan 2010 18:09:28 +0000 (18:09 +0000)]
Fixed a bug caused by incorrect comparison of float values
David Mudrak [Mon, 4 Jan 2010 18:09:18 +0000 (18:09 +0000)]
Workshop planner tool now correctly counts the submissions and allocations
David Mudrak [Mon, 4 Jan 2010 18:09:08 +0000 (18:09 +0000)]
Allows to fake grading
David Mudrak [Mon, 4 Jan 2010 18:08:58 +0000 (18:08 +0000)]
Make sure we do not pass empty arrays to $DB->get_in_or_equal()
David Mudrak [Mon, 4 Jan 2010 18:08:48 +0000 (18:08 +0000)]
Added a column to store the assessment weight
David Mudrak [Mon, 4 Jan 2010 18:08:38 +0000 (18:08 +0000)]
Allow submission attachments to be stored in subfolders
David Mudrak [Mon, 4 Jan 2010 18:08:27 +0000 (18:08 +0000)]
MDL-20058 first prototype of the grading report renderer
David Mudrak [Mon, 4 Jan 2010 18:08:13 +0000 (18:08 +0000)]
A lot of work here and there
DB columns userid renamed to authorid or reviewerid to make the value
clear. Improved manual allocation UI. Raw grades are stored as numeric
values from 0.00000 to 100.00000 (instead of the current 0 to 1) to be
more precise. Started to work on the Grading report (it est the overall
report of all grades form submission and grades for assessments).
David Mudrak [Mon, 4 Jan 2010 18:07:48 +0000 (18:07 +0000)]
Added workshop_evaluations to store aggregated grades for assessments
The gradinggrade can not be stored in workshop_submissions because
participants without their own submission can be reviewers, too.
David Mudrak [Mon, 4 Jan 2010 18:07:38 +0000 (18:07 +0000)]
MDL-19717 workshop manual allocator - pagination support and performance issues
David Mudrak [Mon, 4 Jan 2010 18:07:28 +0000 (18:07 +0000)]
Scalability issues
Did not display properly with dozens of users
David Mudrak [Mon, 4 Jan 2010 18:07:17 +0000 (18:07 +0000)]
Instructions for reviewers work
David Mudrak [Mon, 4 Jan 2010 18:07:07 +0000 (18:07 +0000)]
Conform the new interface requirments
David Mudrak [Mon, 4 Jan 2010 18:06:57 +0000 (18:06 +0000)]
Added and re-sorted strings
David Mudrak [Mon, 4 Jan 2010 18:06:47 +0000 (18:06 +0000)]
Fixed "Edit submission" button link
David Mudrak [Mon, 4 Jan 2010 18:06:37 +0000 (18:06 +0000)]
Fixed pluginfile support
David Mudrak [Mon, 4 Jan 2010 18:06:26 +0000 (18:06 +0000)]
Added the skelet for grading evaluation subplugins
David Mudrak [Mon, 4 Jan 2010 18:05:48 +0000 (18:05 +0000)]
MDL-20236 overall codebase architecture cleanup and fixing regression
See the issue description for more details
David Mudrak [Mon, 4 Jan 2010 18:02:27 +0000 (18:02 +0000)]
Added instructions for submitting
File API seems to be broken right now so I can't test properly. The new
mod/page code was re-used here.
David Mudrak [Mon, 4 Jan 2010 18:02:16 +0000 (18:02 +0000)]
Displays all assigned submissions to be reviewed and saves the calculated grade
David Mudrak [Mon, 4 Jan 2010 18:02:05 +0000 (18:02 +0000)]
Refactoring some critical parts
Critical issue fixed here: after recent refactorings, I called
get_users_with_capability() inside the loop in another loop! (oops :-)
This was used in my very first code using the renderers. I have learnt
I should follow the core approach (as suggested by Tim) to prepare a
data object and pass it to the renderer. The fact the renderer called
a workshop method indicated something was really wrong...
WIP
David Mudrak [Mon, 4 Jan 2010 18:01:50 +0000 (18:01 +0000)]
Go workshop, go!
David Mudrak [Mon, 4 Jan 2010 18:01:40 +0000 (18:01 +0000)]
Displays the list of submissions
David Mudrak [Mon, 4 Jan 2010 18:01:29 +0000 (18:01 +0000)]
Phases can be switched from the Workshop plan tool
There may be more conditions checks written in the future and the
explanation added on what can be expected to happen after the phase
switch.
David Mudrak [Mon, 4 Jan 2010 18:01:15 +0000 (18:01 +0000)]
Uses tabs for all actions, removed temporary links
David Mudrak [Mon, 4 Jan 2010 18:01:05 +0000 (18:01 +0000)]
More work done on the Workshop Plan UI
David Mudrak [Mon, 4 Jan 2010 18:00:54 +0000 (18:00 +0000)]
Mostly working on the view.php UI plus some changes
David Mudrak [Mon, 4 Jan 2010 18:00:34 +0000 (18:00 +0000)]
Refactored the Workshop API class
Uses the PHP magic getter to access the underlying database record. Does
not do the serialization goulash, as the passed objects should be clear
database rows.
David Mudrak [Mon, 4 Jan 2010 18:00:24 +0000 (18:00 +0000)]
Reviewed and modified the workshop capabilities
David Mudrak [Mon, 4 Jan 2010 18:00:12 +0000 (18:00 +0000)]
MDL-20183 Uses some of the new Navigation API
David Mudrak [Mon, 4 Jan 2010 18:00:02 +0000 (18:00 +0000)]
MDL-20192 Moving settings.php into suplugins and a small fix
David Mudrak [Mon, 4 Jan 2010 17:59:46 +0000 (17:59 +0000)]
Dropping obsolete function call
David Mudrak [Mon, 4 Jan 2010 17:59:34 +0000 (17:59 +0000)]
MDL-20192 Allocators and grading strategies are proper subplugins now
David Mudrak [Mon, 4 Jan 2010 17:58:45 +0000 (17:58 +0000)]
Removed the Dummy grading strategy
This was here for the code reviewing purposes only.
David Mudrak [Mon, 4 Jan 2010 17:58:26 +0000 (17:58 +0000)]
MDL-19931 Number of errors - grading strategy logic implemented
David Mudrak [Mon, 4 Jan 2010 17:58:16 +0000 (17:58 +0000)]
Fixed SQL quoting - double quotes needed here
David Mudrak [Mon, 4 Jan 2010 17:58:06 +0000 (17:58 +0000)]
Fixed a unittest bug
David Mudrak [Mon, 4 Jan 2010 17:57:54 +0000 (17:57 +0000)]
MDL-20192 Allocation and grading methods are proper subplugins now.
Still, some areas to be finished - strings and settings
David Mudrak [Mon, 4 Jan 2010 17:56:56 +0000 (17:56 +0000)]
WIP template for unit testing
David Mudrak [Mon, 4 Jan 2010 17:56:44 +0000 (17:56 +0000)]
Get rid of old navigation stuff (to finish yet) and use OUTPUT
David Mudrak [Mon, 4 Jan 2010 17:56:34 +0000 (17:56 +0000)]
Reverts the double quotes surrounding SQL
David Mudrak [Mon, 4 Jan 2010 17:56:23 +0000 (17:56 +0000)]
Better explanation of the returned value
David Mudrak [Mon, 4 Jan 2010 17:56:13 +0000 (17:56 +0000)]
Displays the radio to evaluate the assertion
Also offers all possible numbers of errors, if weighted ones are
counted. Reverts the double quotes coding style for SQL.
David Mudrak [Mon, 4 Jan 2010 17:56:01 +0000 (17:56 +0000)]
Work in progress on "Number of errors" grading strategy. Does not work yet.
David Mudrak [Mon, 4 Jan 2010 17:55:45 +0000 (17:55 +0000)]
Added a dummy grading strategy to demonstrate the basic structure of the component