jamiesensei [Mon, 28 May 2007 14:21:09 +0000 (14:21 +0000)]
MDL-9745 "Checkboxes badly lined up in forms lib, e.g. "students may review" settings on quiz settings screen." Reverted previous fix for similar problem MDL-7779 as the fix for MDL-7779 causes worse problem MDL-9745 with form elements in groups. Second part of commit in HEAD, missed a bit in HEAD.
jamiesensei [Mon, 28 May 2007 12:17:40 +0000 (12:17 +0000)]
MDL-9745 Checkboxes badly lined up in forms lib, e.g. "students may review" settings on quiz settings screen. Reverted previous fix for similar problem MDL-7779 as the fix for MDL-7779 causes worse problems with form elements in groups.
nicolasconnault [Mon, 28 May 2007 08:00:19 +0000 (08:00 +0000)]
MDL-9506 Category and Item now set their own courseid if not set explicitly, and if they have enough information from
other sources. category::set_as_parent has a new constraint: cannot set over children from different courses.
Applied recursion to grade_tree::renumber(), but still some fine-tuning to do, since only grade_items are getting updated in DB.
skodak [Sun, 27 May 2007 22:55:52 +0000 (22:55 +0000)]
MDL-9959 debugging() shows warnings when called from call_user_func() functions
MDL-9958 addslashes_recursive() and stripslashes_recursive() modifies function parameter in PHP5
jamiesensei [Sun, 27 May 2007 05:01:51 +0000 (05:01 +0000)]
made hardFreeze work properly for a whole form. New paramater in moodleform constructor 'editable' defaults to true. If true then display form as normal. If false then hardFreeze whole form. Now displays form without an submit buttons. If form is hard frozen no data is ever passed to get_data.
tjhunt [Thu, 24 May 2007 17:25:37 +0000 (17:25 +0000)]
Removing remaining references to RQP in core code. I had not realised there were so many.\r\rBy the way, I am committing this from a pub in York. Pub's with wireless, whatever next?
nicolasconnault [Thu, 24 May 2007 08:50:01 +0000 (08:50 +0000)]
MDL-9629 Beginning the edit category page. Also added dmllib::sql_max($field) and fixed a few bugs. Grade_item should now extrapolate its sortorder upon insertion if not set, by looking up the last sortorder in the table, and incrementing by 1.
nicolasconnault [Tue, 22 May 2007 09:03:33 +0000 (09:03 +0000)]
MDL-9506 Changed grade_tree fullobjects param (not fully implemented) to $include_grades param, default to false, fully implemented. Full objects are always loaded when building the tree, but grades are only loaded conditionally.
skodak [Mon, 21 May 2007 20:33:42 +0000 (20:33 +0000)]
MDL-9880 Remove user_activate() method from public API because it was used only from user_confirm() in LDAP, other plugins use only user_confirm()
MDL-9575 fix email signup in ldap auth mod
skodak [Mon, 21 May 2007 20:08:45 +0000 (20:08 +0000)]
MDL-9861 Password expiration value is calculated wrong when ldap_expirationtime2unix() returns 0 - patch by Iñaki Arenaza; merged from MOODLE_18_STABLE
nicolasconnault [Mon, 21 May 2007 08:56:44 +0000 (08:56 +0000)]
MDL-9506 Extracted the code that applies droplow and keephigh rules to aggregated values, into its own little method. Unit testing this method revealed a coding error which I have rectified.
nicolasconnault [Mon, 21 May 2007 05:54:12 +0000 (05:54 +0000)]
MDL-9506 Removed the debugging message for the fetch() methods. Added droplow and keephigh rules to grade_category::aggregate_grades(). The only question now is what to do when the droplow or keephigh field is larger than the number of grades for a given user/item combination. At the moment it just gives that value 0.