garvinhicking [Thu, 12 May 2005 10:49:41 +0000 (10:49 +0000)]
If someone is linking the additional_plugins into his installation,
the list of plugins grows too large and load_plugin() on 90 plugins consumes
more than 8MB.
Thus we need pagination for the plugins panel.
The one flaw my patch has is that it can not sort the list of all plugins alphabetically and apply pagination on that, since only loading the plugin shows the real name, and this is what we cannot do.
Any suggestions? Somehow we might need to pre-cache the names of all plugins somewhere...
garvinhicking [Wed, 11 May 2005 09:40:58 +0000 (09:40 +0000)]
Try to catch more "evil" opportunities.
GUYS: We need some volunteers to check if uploads still work as expected and our latest changes don't break stuff. And of course that it's no longer exploitable.
gzip encoding is making too many problems, set it off as default:
Warning: (null)() [ref.outcontrol]: output handler 'ob_gzhandler' cannot be
used twice in Unknown on line 0
or
Warning: ob_start(): output handler 'ob_gzhandler' cannot be used
after 'URL-Rewriter' in /include/functions.inc.php on line 28
Tom, do you know more about it, can you fix it properly? It seems the
ob_functions need to be called before our session_start, but ob_* may also
not interfer with our BC-compatibility $raw_data stuff or the
simplecache plugin.
I also firmly believe gzip compression is a webserver matter and IMHO should
not be touched in application level?
Fix PHP error which comes because session_start() is called before the obgzhandler ob_start and if session.use_trans_sid is activated.
Currently this is more a hotfix - it effectively disables gzcompression on servers with use_trans_sid. We would need to move serendipity_gzCompression before session_start, but I don't dare touch this beast I have no knowledge of. Tom?
patch up rewrite rule so that index.php may not get rewritten to index.php?url=index.html, as it only wastes cycles.
(Even though it didn't happen on my install...anyways, the rewrite rule also only steps into effect if $serendipity['indexFile'] != 'index.php', we may want to create a conditional rule here.
use a better fix, I guess.
We may need to think if there are other areas apart from RSS feeds that
may get cached using appropriate last-modified headers. Most of the frontend
will fail though, as sidebars may server dynamic content.
* Use templates_c for caching remote rss feeds
* Do not call session_start() for RSS feeds to allow caching. If session_start
is called, it would put no-cache, ... headers and disable 304/Not Modified
operations. This is a possibly hazardrous change, we need to further
watch this. That's also the reason I won't backport the fix to 0.8