]> git.mjollnir.org Git - moodle.git/log
moodle.git
17 years agoMDL-10479 Done, but would be nice to middle-align the user names vertically.
nicolasconnault [Wed, 18 Jul 2007 03:34:55 +0000 (03:34 +0000)]
MDL-10479 Done, but would be nice to middle-align the user names vertically.

17 years agoMDL-10477 Fixed a small bug in grade/edit/item.php , where I was testing for
nicolasconnault [Wed, 18 Jul 2007 03:14:06 +0000 (03:14 +0000)]
MDL-10477 Fixed a small bug in grade/edit/item.php , where I was testing for
if (!empty($data->pref_gradedisplaytype))

which returned false if the value was set to 0. I just changed !empty to isset and it fixed it.

17 years agoputting a space before {
toyomoyo [Wed, 18 Jul 2007 02:02:48 +0000 (02:02 +0000)]
putting a space before {

17 years agoMDL-10481 fixing broken form defaults - sorry
skodak [Tue, 17 Jul 2007 19:38:27 +0000 (19:38 +0000)]
MDL-10481 fixing broken form defaults - sorry

17 years agominor edit
nicolasconnault [Tue, 17 Jul 2007 19:28:22 +0000 (19:28 +0000)]
minor edit

17 years agoMDL-9628 Refactored display "Raw" string into "Real" to avoid confusion with raw...
nicolasconnault [Tue, 17 Jul 2007 19:04:50 +0000 (19:04 +0000)]
MDL-9628 Refactored display "Raw" string into "Real" to avoid confusion with raw vs final grades

17 years agoAnd key fields are lowercased too. End of MDL-10413
stronk7 [Tue, 17 Jul 2007 18:57:31 +0000 (18:57 +0000)]
And key fields are lowercased too. End of MDL-10413

Merged from MOODLE_18_STABLE

17 years agoAnd index fields are lowercased too. Part of MDL-10413
stronk7 [Tue, 17 Jul 2007 18:55:51 +0000 (18:55 +0000)]
And index fields are lowercased too. Part of MDL-10413

Merged from MOODLE_18_STABLE

17 years agoEnsuring we always retrofit lowercase tables. Part of MDL-10413.
stronk7 [Tue, 17 Jul 2007 18:49:22 +0000 (18:49 +0000)]
Ensuring we always retrofit lowercase tables. Part of MDL-10413.

Merged from MOODLE_18_STABLE

17 years agoMDL-10481
nicolasconnault [Tue, 17 Jul 2007 18:46:21 +0000 (18:46 +0000)]
MDL-10481
Two new preferences: averagesdecimalpoints and rangesdecimalpoints
Two new constants: GRADE_REPORT_PREFERENCE_INHERIT and GRADE_REPORT_PREFERENCE_DEFAULT with string values
removed GRADE_REPORT_GRADE_DISPLAY_TYPE_INHERIT in favour of the above
Added a number of language strings.

17 years agoOU bug 3463 - warnings when you start an attempt in 'each attempt builds on last...
tjhunt [Tue, 17 Jul 2007 15:27:59 +0000 (15:27 +0000)]
OU bug 3463 - warnings when you start an attempt in 'each attempt builds on last' mode.

17 years agoMDL-10481 minor form cleanup - added prefix for preferences in element names, added...
skodak [Tue, 17 Jul 2007 15:22:18 +0000 (15:22 +0000)]
MDL-10481 minor form cleanup - added prefix for preferences in element names, added header + temporary debug delay before redirect

17 years agoMDL-10481 Elements added to form. item preferences not yet recognised by report.
nicolasconnault [Tue, 17 Jul 2007 14:53:10 +0000 (14:53 +0000)]
MDL-10481 Elements added to form. item preferences not yet recognised by report.

17 years agoMDL-10065 move lib/simpletest/grade/simpletest elsewhere
skodak [Tue, 17 Jul 2007 14:25:20 +0000 (14:25 +0000)]
MDL-10065 move lib/simpletest/grade/simpletest elsewhere
+ fixed categroy locking unittest and minor problem with return value

17 years agoMDL-10395:
thepurpleblob [Tue, 17 Jul 2007 14:07:56 +0000 (14:07 +0000)]
MDL-10395:
Course managers are now displayed in the order that the user
selects in the Define Roles page.

17 years agoMDL-10495:
thepurpleblob [Tue, 17 Jul 2007 13:13:35 +0000 (13:13 +0000)]
MDL-10495:
Course Managers role's now in same order as Manage Roles screen.

17 years agotest if auth cas activated and no parameters
jgutierr25 [Tue, 17 Jul 2007 12:08:26 +0000 (12:08 +0000)]
test if auth cas activated and no parameters

17 years ago*** empty log message ***
jgutierr25 [Tue, 17 Jul 2007 11:46:19 +0000 (11:46 +0000)]
*** empty log message ***

17 years agoMoving simpletest to grade directory
moodler [Tue, 17 Jul 2007 08:50:34 +0000 (08:50 +0000)]
Moving simpletest to grade directory

17 years agoallow comments, lock checking for xml plugin
toyomoyo [Tue, 17 Jul 2007 08:40:35 +0000 (08:40 +0000)]
allow comments, lock checking for xml plugin

17 years agolatest tags
moodler [Tue, 17 Jul 2007 07:54:36 +0000 (07:54 +0000)]
latest tags

17 years agoMDL-10439 call definition_after_data() from moodleform constructor only when form...
skodak [Tue, 17 Jul 2007 07:48:58 +0000 (07:48 +0000)]
MDL-10439 call definition_after_data() from moodleform constructor only when form submitted

17 years agoMDL-10477 Implementing rangesdisplaytype, finishing off this task
nicolasconnault [Tue, 17 Jul 2007 07:41:52 +0000 (07:41 +0000)]
MDL-10477 Implementing rangesdisplaytype, finishing off this task

17 years agoMDL-10111 aggragationcof for weighted categories and extra items in old gradebook
skodak [Tue, 17 Jul 2007 07:24:35 +0000 (07:24 +0000)]
MDL-10111 aggragationcof for weighted categories and extra items in old gradebook

17 years agoMDL-10438 inline docs added, moved $gpr into grade class
skodak [Tue, 17 Jul 2007 06:09:03 +0000 (06:09 +0000)]
MDL-10438 inline docs added, moved $gpr into grade class

17 years agoMDL-10438 inline docs added
skodak [Tue, 17 Jul 2007 05:52:42 +0000 (05:52 +0000)]
MDL-10438 inline docs added

17 years agoremoved accidentally added backup file
nicolasconnault [Tue, 17 Jul 2007 05:25:31 +0000 (05:25 +0000)]
removed accidentally added backup file

17 years agofixing broken headers
toyomoyo [Tue, 17 Jul 2007 03:32:10 +0000 (03:32 +0000)]
fixing broken headers

17 years agomerged fix for MDL-10475, adding override for legacy student roles before dropping...
toyomoyo [Tue, 17 Jul 2007 02:47:48 +0000 (02:47 +0000)]
merged fix for MDL-10475, adding override for legacy student roles before dropping studentcanpost

17 years agoLatest tags file
moodler [Tue, 17 Jul 2007 02:30:08 +0000 (02:30 +0000)]
Latest tags file

17 years agoAdded check if $PAGE is set. Seams that $PAGE is not set on all pages.
urs_hunkler [Mon, 16 Jul 2007 20:59:38 +0000 (20:59 +0000)]
Added check if $PAGE is set. Seams that $PAGE is not set on all pages.

17 years agoAdding some course->xxxx missing fields to backup & restore. MDL-10444
stronk7 [Mon, 16 Jul 2007 20:18:26 +0000 (20:18 +0000)]
Adding some course->xxxx missing fields to backup & restore. MDL-10444

Merged from MOODLE_18_STABLE

17 years agoMDL-10477 Mainly the percentage grade display type
nicolasconnault [Mon, 16 Jul 2007 19:46:54 +0000 (19:46 +0000)]
MDL-10477 Mainly the percentage grade display type

17 years ago#admin-report-courseoverview-index .invisiblefieldset { display: block; }
urs_hunkler [Mon, 16 Jul 2007 19:25:11 +0000 (19:25 +0000)]
#admin-report-courseoverview-index .invisiblefieldset {  display: block; }

17 years agoMDL-10438 return tracking in grading forms; new grade plugin selector
skodak [Mon, 16 Jul 2007 18:58:09 +0000 (18:58 +0000)]
MDL-10438 return tracking in grading forms; new grade plugin selector

17 years agoMDL-10482 incorrect texarea height
skodak [Mon, 16 Jul 2007 14:50:25 +0000 (14:50 +0000)]
MDL-10482 incorrect texarea height

17 years agoAdd id="responseform" to the question preview form tag, to match the quiz form, to...
tjhunt [Mon, 16 Jul 2007 13:32:52 +0000 (13:32 +0000)]
Add id="responseform" to the question preview form tag, to match the quiz form, to make life easier for Javascript on questions. Idea thanks to Adriane Boyd.

17 years agoStop the 'remove rqp' environment message from appearing after the question type...
tjhunt [Mon, 16 Jul 2007 13:23:13 +0000 (13:23 +0000)]
Stop the 'remove rqp' environment message from appearing after the question type is gone.

17 years agoMDL-9629 New setting and language strings. Also using constants from gradelib in...
nicolasconnault [Mon, 16 Jul 2007 09:18:02 +0000 (09:18 +0000)]
MDL-9629 New setting and language strings. Also using constants from gradelib in settings.php and preferences_form.php for grader report.

17 years agoaverage class/group should not take non-graded students into consideration
toyomoyo [Mon, 16 Jul 2007 09:03:23 +0000 (09:03 +0000)]
average class/group should not take non-graded students into consideration

17 years agofixed css broken by edit_tree.php to tree.php renaming
skodak [Mon, 16 Jul 2007 07:32:51 +0000 (07:32 +0000)]
fixed css broken by edit_tree.php to tree.php renaming

17 years agouse min max bounds in update_final_grade()
skodak [Mon, 16 Jul 2007 07:16:08 +0000 (07:16 +0000)]
use min max bounds in update_final_grade()

17 years agoMDL-10474, fixing division by 0
toyomoyo [Mon, 16 Jul 2007 07:14:40 +0000 (07:14 +0000)]
MDL-10474, fixing division by 0

17 years agoMDL-9628 FIxed the CSS for category headers
moodler [Mon, 16 Jul 2007 07:06:51 +0000 (07:06 +0000)]
MDL-9628   FIxed the CSS for category headers

17 years agoChanged "Grand totals" to "averages" everywhere
moodler [Mon, 16 Jul 2007 07:04:52 +0000 (07:04 +0000)]
Changed "Grand totals" to "averages" everywhere

17 years agoSOme tidying upup of CSS MDL-9628
moodler [Mon, 16 Jul 2007 06:24:09 +0000 (06:24 +0000)]
SOme tidying upup of CSS   MDL-9628

17 years agopage param should not be in the baseurl for group selector, otherwise when you go...
toyomoyo [Mon, 16 Jul 2007 06:20:03 +0000 (06:20 +0000)]
page param should not be in the baseurl for group selector, otherwise when you go to page x and switch groups you can end up being on a blank page with no paging navigation

17 years agoChanges "show scales" everywhere to "show ranges"
moodler [Mon, 16 Jul 2007 06:17:45 +0000 (06:17 +0000)]
Changes "show scales" everywhere to "show ranges"

17 years agoFOr showing ranges in the gradebook
moodler [Mon, 16 Jul 2007 06:14:23 +0000 (06:14 +0000)]
FOr showing ranges in the gradebook

17 years agoputting a clear div
toyomoyo [Mon, 16 Jul 2007 06:10:50 +0000 (06:10 +0000)]
putting a clear div

17 years agowhen element is frozen should not escape html entities in htmleditor.
jamiesensei [Mon, 16 Jul 2007 06:04:20 +0000 (06:04 +0000)]
when element is frozen should not escape html entities in htmleditor.

17 years agofix for MDL-10345, use averages instead of totals
toyomoyo [Mon, 16 Jul 2007 06:01:19 +0000 (06:01 +0000)]
fix for MDL-10345, use averages instead of totals

17 years agoRestored a glovbal declaration for SESSION (to make sortoder work again)
moodler [Mon, 16 Jul 2007 05:56:52 +0000 (05:56 +0000)]
Restored a glovbal declaration for SESSION (to make sortoder work again)

17 years agoUse a private CSS class for this table to be more flexible
moodler [Mon, 16 Jul 2007 05:40:18 +0000 (05:40 +0000)]
Use a private CSS class for this table to be more flexible

17 years agoReport selection is now sticky due to user preference, and tidied up code a bit
moodler [Mon, 16 Jul 2007 05:34:36 +0000 (05:34 +0000)]
Report selection is now sticky due to user preference, and tidied up code a bit

17 years agoMDL-9633 Added report class for user report
nicolasconnault [Mon, 16 Jul 2007 04:09:00 +0000 (04:09 +0000)]
MDL-9633 Added report class for user report

17 years agoMOved the main link to reports.php
moodler [Mon, 16 Jul 2007 04:04:49 +0000 (04:04 +0000)]
MOved the main link to reports.php

17 years agoNow the glossary->allowcoments setting is respected. MDL-8056
stronk7 [Sun, 15 Jul 2007 22:27:16 +0000 (22:27 +0000)]
Now the glossary->allowcoments setting is respected. MDL-8056
Credit goes to Matt Clarkson. Thanks.

Merged from MOODLE_18_STABLE

17 years agoMDL-8096 fixed & in htmlarea httpsrequired parameter - xhtml strict fix
skodak [Sun, 15 Jul 2007 15:15:30 +0000 (15:15 +0000)]
MDL-8096 fixed & in htmlarea httpsrequired parameter - xhtml strict fix

17 years agofix for upgrade trouble caused by recen grade import table changes - it was IMO easie...
skodak [Sun, 15 Jul 2007 13:38:39 +0000 (13:38 +0000)]
fix for upgrade trouble caused by recen grade import table changes - it was IMO easier to recreate the tables instead of fixing the upgrade code

17 years agoMost probable default value for applicationid is 1 (moodle).
stronk7 [Sat, 14 Jul 2007 22:40:41 +0000 (22:40 +0000)]
Most probable default value for applicationid is 1 (moodle).

17 years agoDeleting duplicate applicationid field, adding one missing fk and
stronk7 [Sat, 14 Jul 2007 22:38:35 +0000 (22:38 +0000)]
Deleting duplicate applicationid field, adding one missing fk and
minor reordering of logic of mnet stuff.

17 years agoMoving mnet_application somewhere before mnet_host
stronk7 [Sat, 14 Jul 2007 22:29:17 +0000 (22:29 +0000)]
Moving mnet_application somewhere before mnet_host
and creating missing FK in mnet_host

17 years agofixing a small syntax oddity that breaks get_my_courses in postgres. quoting " means...
mjollnir_ [Sat, 14 Jul 2007 19:36:59 +0000 (19:36 +0000)]
fixing a small syntax oddity that breaks get_my_courses in postgres.  quoting " means escape table, not string

17 years agoBig reordering of table creation, following all dependencies (FKs)
stronk7 [Sat, 14 Jul 2007 19:20:43 +0000 (19:20 +0000)]
Big reordering of table creation, following all dependencies (FKs)
Small fix in some FKs pointing to wrong tables. Nothing else changed.

17 years agoReordering a bit mnet_application table and fixing missing tag that
stronk7 [Sat, 14 Jul 2007 18:46:03 +0000 (18:46 +0000)]
Reordering a bit mnet_application table and fixing missing tag that
was preventing installation of head.

17 years agoOptimising the grader report
nicolasconnault [Sat, 14 Jul 2007 04:18:35 +0000 (04:18 +0000)]
Optimising the grader report

17 years agoMDL-9633 Refactored the index.php page into a child class of grade_report
nicolasconnault [Sat, 14 Jul 2007 03:46:24 +0000 (03:46 +0000)]
MDL-9633 Refactored the index.php page into a child class of grade_report

17 years ago Merged Donal's changes to MNET to allow moodle to also network with mahara.
mjollnir_ [Sat, 14 Jul 2007 03:00:12 +0000 (03:00 +0000)]
Merged Donal's changes to MNET to allow moodle to also network with mahara.
    changelog follows

    [MNET-manual] added version.php, install.xml and upgrade.php patches
    Route remote users back to their home server without going through jump.php and land.php
    Display app-specific strings in the user view
    Display the application icon in the Remote Host block
    Hide the 'logs' tab if the application under review is not Moodle
    Hide the 'logs' tab if the application under review is not Moodle
    Update user record to note that picture == 1 once a picture has been
    transferred.
    Change 2 to uri - is this fluid?
    Add application paramter to bootstrap function
    Find the application
    Workaround for PHP5.2.2 bug: http://bugs.php.net/bug.php?id=41293
    $HTTP_RAW_POST_DATA was not being populated
    Ensure we get an application for our Peer
    Update the URI to use for MNET
    The default 'wantsurl' should be empty
    Use the appropriate 'land' url for the remote application
    Add hidden form elements for 'application'
    Add awareness of new Application concept
    Add awareness of new Application concept
    Add awareness of new Application concept
    Add awareness of new Application concept
    Add awareness of new Application concept
    Add awareness of new Application concept
    Add awareness of new Application concept

17 years agoTracker #MDL-9353 - Paypal cost of course not visible in course settings.
mchurch [Fri, 13 Jul 2007 20:31:26 +0000 (20:31 +0000)]
Tracker #MDL-9353 - Paypal cost of course not visible in course settings.

17 years agoOptimising the grader report
nicolasconnault [Fri, 13 Jul 2007 19:02:40 +0000 (19:02 +0000)]
Optimising the grader report

17 years agoMDL-10452 - start quiz UI is confusing if you have quiz:preview capability. Change...
tjhunt [Fri, 13 Jul 2007 15:58:42 +0000 (15:58 +0000)]
MDL-10452 - start quiz UI is confusing if you have quiz:preview capability. Change the 'start/continue attempt button' to say 'start/continue preview' in this case. Merged from MOODLE_17_STABLE.

17 years agoMDL-10392 changed feedback language strings to grade language strings
nicolasconnault [Fri, 13 Jul 2007 13:03:07 +0000 (13:03 +0000)]
MDL-10392 changed feedback language strings to grade language strings

17 years agoMDL-10414 Implemented tab indices (student_grades, then student_feedbacks, from left...
nicolasconnault [Fri, 13 Jul 2007 11:24:13 +0000 (11:24 +0000)]
MDL-10414 Implemented tab indices (student_grades, then student_feedbacks, from left to right and top to bottom)

17 years agoMDL-10286 Updated overlib.js (2 years diff!) and enabled overlib for HTML feedback...
nicolasconnault [Fri, 13 Jul 2007 10:09:51 +0000 (10:09 +0000)]
MDL-10286 Updated overlib.js (2 years diff!) and enabled overlib for HTML feedback format

17 years agoone more category locking fix
skodak [Fri, 13 Jul 2007 09:12:23 +0000 (09:12 +0000)]
one more category locking fix

17 years agoupdated category locking to work the same as hiding - locking of category now locks...
skodak [Fri, 13 Jul 2007 09:05:36 +0000 (09:05 +0000)]
updated category locking to work the same as hiding - locking of category now locks all children too

17 years agograde_tree minor cleanup - grades not included anymore; fixed categroy item position...
skodak [Fri, 13 Jul 2007 08:59:46 +0000 (08:59 +0000)]
grade_tree minor cleanup - grades not included anymore; fixed categroy item position in grader report

17 years agoMDL-10380:
thepurpleblob [Fri, 13 Jul 2007 08:36:14 +0000 (08:36 +0000)]
MDL-10380:
Check for randeredmatch plugin done using array_key_exists() for PHP4
compatibility
MDL-10317:
Question name is now the question ID, rather than the question text.

17 years agoMDL-10181, user management improvements fixes
toyomoyo [Fri, 13 Jul 2007 08:26:47 +0000 (08:26 +0000)]
MDL-10181, user management improvements fixes

17 years agoAutomatic installer.php lang files by installer_builder (20070713)
moodler [Fri, 13 Jul 2007 08:19:15 +0000 (08:19 +0000)]
Automatic installer.php lang files by installer_builder (20070713)

17 years agofix for MDL-10440 IE7 and IE6 on win xp error when changing "disable" state of "Start...
jamiesensei [Fri, 13 Jul 2007 08:14:37 +0000 (08:14 +0000)]
fix for MDL-10440 IE7 and IE6 on win xp error when changing "disable" state of "Start date"

17 years agoMDL-10386 Quickfeedback and quickgrading fixed! It wasn't setting $needsupdate to...
nicolasconnault [Fri, 13 Jul 2007 08:08:53 +0000 (08:08 +0000)]
MDL-10386 Quickfeedback and quickgrading fixed! It wasn't setting $needsupdate to true when the grade_grades didn't yet exist in DB.

17 years agoMDL-9363, some fixes for grade import, not finished!
toyomoyo [Fri, 13 Jul 2007 08:06:30 +0000 (08:06 +0000)]
MDL-9363, some fixes for grade import, not finished!

17 years agofixed == typo, thanks Nicolas and Yu
skodak [Fri, 13 Jul 2007 07:51:10 +0000 (07:51 +0000)]
fixed == typo, thanks Nicolas and Yu

17 years agoMDL-9628 Refactored variables and method from grader_report into grade/report/lib...
nicolasconnault [Fri, 13 Jul 2007 07:05:04 +0000 (07:05 +0000)]
MDL-9628 Refactored variables and method from grader_report into grade/report/lib.php, and renamed grade_report.php to grade/report/grader/lib.php. Updated links to these files.

17 years agoI fixed up the database creation
moodler [Fri, 13 Jul 2007 06:44:31 +0000 (06:44 +0000)]
I fixed up the database creation

17 years agoMDL-9628 Renamed edit_* to * and updated links to these files
nicolasconnault [Fri, 13 Jul 2007 05:54:30 +0000 (05:54 +0000)]
MDL-9628 Renamed edit_* to * and updated links to these files

17 years agoMDL-9628 Renamed edit_* to *
nicolasconnault [Fri, 13 Jul 2007 05:53:16 +0000 (05:53 +0000)]
MDL-9628 Renamed edit_* to *

17 years agorenaming constant
nicolasconnault [Fri, 13 Jul 2007 05:41:04 +0000 (05:41 +0000)]
renaming constant

17 years agoMDL-9628 New constants in gradelib.php: GRADE_EDIT_URL and GRADE_EDIT_DIR
nicolasconnault [Fri, 13 Jul 2007 05:26:45 +0000 (05:26 +0000)]
MDL-9628 New constants in gradelib.php: GRADE_EDIT_URL and GRADE_EDIT_DIR
Also renamed $report->get_user_pref() to $report->get_pref() , because the returned preference may come from $CFG if it isn't defined as a user preference.

17 years agoadding feedback to grade import temp table and rename rawgrade to
toyomoyo [Fri, 13 Jul 2007 05:01:32 +0000 (05:01 +0000)]
adding feedback to grade import temp table and rename rawgrade to
finalgrade

17 years agoMerged "no posts" string fix from stable
moodler [Fri, 13 Jul 2007 03:05:17 +0000 (03:05 +0000)]
Merged "no posts" string fix from stable

17 years agomajor grade editing fixes and improvements - grader form now knows if grade is editab...
skodak [Thu, 12 Jul 2007 22:31:20 +0000 (22:31 +0000)]
major grade editing fixes and improvements - grader form now knows if grade is editable; fixed broken quickgrading; feedback format is handled the same way as in the rest of moodle - automatically converted to FORMAT_HTML when editor enabled; fixed calculation of grades that was breaking locking

17 years agoMDL-10364 initial calcualtion edit form
skodak [Thu, 12 Jul 2007 20:12:07 +0000 (20:12 +0000)]
MDL-10364 initial calcualtion edit form

17 years agoMDL-10364 initial calcualtion edit form
skodak [Thu, 12 Jul 2007 20:12:06 +0000 (20:12 +0000)]
MDL-10364 initial calcualtion edit form

17 years agoMDL-10437 moved editing forms to grade/edit/ directory - these should be shared by...
skodak [Thu, 12 Jul 2007 19:40:28 +0000 (19:40 +0000)]
MDL-10437 moved editing forms to grade/edit/ directory - these should be shared by all reports, there were too many files in grader directory anyway

17 years agoMDL-10364 calcualtion icon fix
skodak [Thu, 12 Jul 2007 17:46:38 +0000 (17:46 +0000)]
MDL-10364 calcualtion icon fix

17 years agoMDL-10386 More refactoring (grade_report_grader->get_user_pref($pref_name))
nicolasconnault [Thu, 12 Jul 2007 17:42:23 +0000 (17:42 +0000)]
MDL-10386 More refactoring (grade_report_grader->get_user_pref($pref_name))

17 years agoMDL-10364 calcualtion validation improvements
skodak [Thu, 12 Jul 2007 17:36:18 +0000 (17:36 +0000)]
MDL-10364 calcualtion validation improvements