]>
git.mjollnir.org Git - moodle.git/log
David Mudrak [Mon, 4 Jan 2010 18:05:48 +0000 (18:05 +0000)]
MDL-20236 overall codebase architecture cleanup and fixing regression
See the issue description for more details
David Mudrak [Mon, 4 Jan 2010 18:02:27 +0000 (18:02 +0000)]
Added instructions for submitting
File API seems to be broken right now so I can't test properly. The new
mod/page code was re-used here.
David Mudrak [Mon, 4 Jan 2010 18:02:16 +0000 (18:02 +0000)]
Displays all assigned submissions to be reviewed and saves the calculated grade
David Mudrak [Mon, 4 Jan 2010 18:02:05 +0000 (18:02 +0000)]
Refactoring some critical parts
Critical issue fixed here: after recent refactorings, I called
get_users_with_capability() inside the loop in another loop! (oops :-)
This was used in my very first code using the renderers. I have learnt
I should follow the core approach (as suggested by Tim) to prepare a
data object and pass it to the renderer. The fact the renderer called
a workshop method indicated something was really wrong...
WIP
David Mudrak [Mon, 4 Jan 2010 18:01:50 +0000 (18:01 +0000)]
Go workshop, go!
David Mudrak [Mon, 4 Jan 2010 18:01:40 +0000 (18:01 +0000)]
Displays the list of submissions
David Mudrak [Mon, 4 Jan 2010 18:01:29 +0000 (18:01 +0000)]
Phases can be switched from the Workshop plan tool
There may be more conditions checks written in the future and the
explanation added on what can be expected to happen after the phase
switch.
David Mudrak [Mon, 4 Jan 2010 18:01:15 +0000 (18:01 +0000)]
Uses tabs for all actions, removed temporary links
David Mudrak [Mon, 4 Jan 2010 18:01:05 +0000 (18:01 +0000)]
More work done on the Workshop Plan UI
David Mudrak [Mon, 4 Jan 2010 18:00:54 +0000 (18:00 +0000)]
Mostly working on the view.php UI plus some changes
David Mudrak [Mon, 4 Jan 2010 18:00:34 +0000 (18:00 +0000)]
Refactored the Workshop API class
Uses the PHP magic getter to access the underlying database record. Does
not do the serialization goulash, as the passed objects should be clear
database rows.
David Mudrak [Mon, 4 Jan 2010 18:00:24 +0000 (18:00 +0000)]
Reviewed and modified the workshop capabilities
David Mudrak [Mon, 4 Jan 2010 18:00:12 +0000 (18:00 +0000)]
MDL-20183 Uses some of the new Navigation API
David Mudrak [Mon, 4 Jan 2010 18:00:02 +0000 (18:00 +0000)]
MDL-20192 Moving settings.php into suplugins and a small fix
David Mudrak [Mon, 4 Jan 2010 17:59:46 +0000 (17:59 +0000)]
Dropping obsolete function call
David Mudrak [Mon, 4 Jan 2010 17:59:34 +0000 (17:59 +0000)]
MDL-20192 Allocators and grading strategies are proper subplugins now
David Mudrak [Mon, 4 Jan 2010 17:58:45 +0000 (17:58 +0000)]
Removed the Dummy grading strategy
This was here for the code reviewing purposes only.
David Mudrak [Mon, 4 Jan 2010 17:58:26 +0000 (17:58 +0000)]
MDL-19931 Number of errors - grading strategy logic implemented
David Mudrak [Mon, 4 Jan 2010 17:58:16 +0000 (17:58 +0000)]
Fixed SQL quoting - double quotes needed here
David Mudrak [Mon, 4 Jan 2010 17:58:06 +0000 (17:58 +0000)]
Fixed a unittest bug
David Mudrak [Mon, 4 Jan 2010 17:57:54 +0000 (17:57 +0000)]
MDL-20192 Allocation and grading methods are proper subplugins now.
Still, some areas to be finished - strings and settings
David Mudrak [Mon, 4 Jan 2010 17:56:56 +0000 (17:56 +0000)]
WIP template for unit testing
David Mudrak [Mon, 4 Jan 2010 17:56:44 +0000 (17:56 +0000)]
Get rid of old navigation stuff (to finish yet) and use OUTPUT
David Mudrak [Mon, 4 Jan 2010 17:56:34 +0000 (17:56 +0000)]
Reverts the double quotes surrounding SQL
David Mudrak [Mon, 4 Jan 2010 17:56:23 +0000 (17:56 +0000)]
Better explanation of the returned value
David Mudrak [Mon, 4 Jan 2010 17:56:13 +0000 (17:56 +0000)]
Displays the radio to evaluate the assertion
Also offers all possible numbers of errors, if weighted ones are
counted. Reverts the double quotes coding style for SQL.
David Mudrak [Mon, 4 Jan 2010 17:56:01 +0000 (17:56 +0000)]
Work in progress on "Number of errors" grading strategy. Does not work yet.
David Mudrak [Mon, 4 Jan 2010 17:55:45 +0000 (17:55 +0000)]
Added a dummy grading strategy to demonstrate the basic structure of the component
David Mudrak [Mon, 4 Jan 2010 17:55:23 +0000 (17:55 +0000)]
Puttting a TODO note - return to this code once working on the Scheduled allocation
David Mudrak [Mon, 4 Jan 2010 17:55:13 +0000 (17:55 +0000)]
Fixing the rendering of remove icon
David Mudrak [Mon, 4 Jan 2010 17:55:02 +0000 (17:55 +0000)]
Reverting Petr's suggestion - using stdClass instead of object again
I do not agree with using object() class for no real reason.
David Mudrak [Mon, 4 Jan 2010 17:54:46 +0000 (17:54 +0000)]
Fixed function name typo
David Mudrak [Mon, 4 Jan 2010 17:54:36 +0000 (17:54 +0000)]
wip
David Mudrak [Mon, 4 Jan 2010 17:54:23 +0000 (17:54 +0000)]
Fixing regression
Raw database records and $USER are stdClasses (grrr I wonder why we ever
started with this object class)
David Mudrak [Mon, 4 Jan 2010 17:54:13 +0000 (17:54 +0000)]
Fixing the type for grades to number(10,5)
David Mudrak [Mon, 4 Jan 2010 17:54:03 +0000 (17:54 +0000)]
Dropping support for Workshop password
Discussed with Petr. Password protection should be sorted out at the
core level (conditionlib maybe).
David Mudrak [Mon, 4 Jan 2010 17:53:53 +0000 (17:53 +0000)]
Petr's review: private member variables do not have underscore prefix
David Mudrak [Mon, 4 Jan 2010 17:53:43 +0000 (17:53 +0000)]
English string fixed, thank to Stephan Rinke
http://moodle.org/mod/forum/discuss.php?d=130085
David Mudrak [Mon, 4 Jan 2010 17:53:33 +0000 (17:53 +0000)]
Adding new install.php file
David Mudrak [Mon, 4 Jan 2010 17:53:20 +0000 (17:53 +0000)]
Petr's review: Removing assignments by reference where not needed
David Mudrak [Mon, 4 Jan 2010 17:53:10 +0000 (17:53 +0000)]
Fixing regression - $DB does not return objects() but stdClasses() :-(
David Mudrak [Mon, 4 Jan 2010 17:52:59 +0000 (17:52 +0000)]
Petr's review: use object instead of stdClass
David Mudrak [Mon, 4 Jan 2010 17:52:45 +0000 (17:52 +0000)]
Petr's review: Removing assignment by reference
David Mudrak [Mon, 4 Jan 2010 17:52:35 +0000 (17:52 +0000)]
Accumulative grading: calculation of grade given by peer reviewer
David Mudrak [Mon, 4 Jan 2010 17:52:25 +0000 (17:52 +0000)]
Added an unique index on workshop_grades
David Mudrak [Mon, 4 Jan 2010 17:52:14 +0000 (17:52 +0000)]
Removing unittesting of implementation details
David Mudrak [Mon, 4 Jan 2010 17:52:04 +0000 (17:52 +0000)]
Refactoring and fixing
There was a chaos in dimension masterids and localids
David Mudrak [Mon, 4 Jan 2010 17:51:54 +0000 (17:51 +0000)]
Fixed wroing using of static cache
David Mudrak [Mon, 4 Jan 2010 17:51:44 +0000 (17:51 +0000)]
Removing static variables. Double quoting SQL. Named param
David Mudrak [Mon, 4 Jan 2010 17:51:34 +0000 (17:51 +0000)]
Prepared a framework for calculating the grade for submission as suggested by the reviewer
David Mudrak [Mon, 4 Jan 2010 17:51:22 +0000 (17:51 +0000)]
Fixed regressions
David Mudrak [Mon, 4 Jan 2010 17:51:10 +0000 (17:51 +0000)]
Accumulative assessment saves (and loads already saved) evaluation
David Mudrak [Mon, 4 Jan 2010 17:50:59 +0000 (17:50 +0000)]
Use standard elements for setting the grades and scales
David Mudrak [Mon, 4 Jan 2010 17:50:48 +0000 (17:50 +0000)]
Displays embeded files in assessment forms
David Mudrak [Mon, 4 Jan 2010 17:50:38 +0000 (17:50 +0000)]
Removing TODO.txt file
David Mudrak [Mon, 4 Jan 2010 17:50:24 +0000 (17:50 +0000)]
Migrated deprecated popup_form()
David Mudrak [Mon, 4 Jan 2010 17:50:13 +0000 (17:50 +0000)]
Replacing deprecated print_user_picture()
David Mudrak [Mon, 4 Jan 2010 17:50:03 +0000 (17:50 +0000)]
Display "Edit submission" button at submission page
David Mudrak [Mon, 4 Jan 2010 17:49:53 +0000 (17:49 +0000)]
Deletes the embeded media when deleting the assessment dimension
David Mudrak [Mon, 4 Jan 2010 17:49:43 +0000 (17:49 +0000)]
Do not support tags yet until the API stabilizes
The generated form uses deprecated calls at the moment.
David Mudrak [Mon, 4 Jan 2010 17:49:33 +0000 (17:49 +0000)]
Replaces deprecated update_module_button()
David Mudrak [Mon, 4 Jan 2010 17:49:23 +0000 (17:49 +0000)]
Assessment dimensions now have unique id which allows to embed media.
David Mudrak [Mon, 4 Jan 2010 17:49:13 +0000 (17:49 +0000)]
DB structure change
Every dimension has to have its own ID so it may become itemid within
File API framework. Using the same model as we have with course modules
and module instances.
Also, removing some obsolete fields.
David Mudrak [Mon, 4 Jan 2010 17:49:01 +0000 (17:49 +0000)]
A lot of changes here and there
David Mudrak [Mon, 4 Jan 2010 17:48:33 +0000 (17:48 +0000)]
Uses workshop renderer to display assessment page
Some small refactoring like using single function to group users done.
David Mudrak [Mon, 4 Jan 2010 17:48:20 +0000 (17:48 +0000)]
MDL-19941 Submission attachments and embedded files draft support
Plus some cleaning up here and there
David Mudrak [Mon, 4 Jan 2010 17:48:07 +0000 (17:48 +0000)]
Adding a development tools script
David Mudrak [Mon, 4 Jan 2010 17:47:54 +0000 (17:47 +0000)]
In response to MDL-19603 changing the text length to big everywhere
Also, the submission wysiwyg part is going to be stored in "content"
instead of current "data".
David Mudrak [Mon, 4 Jan 2010 17:47:43 +0000 (17:47 +0000)]
Extending workshop class constructor
Every action script in 99% starts with fetching course, course module,
and module instance record. Workshop class will keep the reference to
the course record in courserecord public member variable (do not confuse
with course integer property).
David Mudrak [Mon, 4 Jan 2010 17:47:32 +0000 (17:47 +0000)]
MDL-19870 Random allocation - work in progress
Random allocation implemented. More testing needed.
David Mudrak [Mon, 4 Jan 2010 17:47:22 +0000 (17:47 +0000)]
Fix: do not remove allocation if it should be kept
David Mudrak [Mon, 4 Jan 2010 17:47:09 +0000 (17:47 +0000)]
MDL-19870 Initial work on random allocator
Initial sketches of random allocator. Refactoring of the rest of the
module here and there. Also, this commit removes trailing whitespace and
running empty lines.
David Mudrak [Mon, 4 Jan 2010 17:46:44 +0000 (17:46 +0000)]
Use the new output->table() rendering method
David Mudrak [Mon, 4 Jan 2010 17:46:33 +0000 (17:46 +0000)]
Manual allocator uses the new subrendering feature
David Mudrak [Mon, 4 Jan 2010 17:46:05 +0000 (17:46 +0000)]
MDL-19717 First drafts of allocation support
David Mudrak [Mon, 4 Jan 2010 17:45:27 +0000 (17:45 +0000)]
Added capabilities
David Mudrak [Mon, 4 Jan 2010 17:45:14 +0000 (17:45 +0000)]
Use the new output approach
David Mudrak [Mon, 4 Jan 2010 17:45:03 +0000 (17:45 +0000)]
Removed anonymity and hidegrades
These will be controlled by capabilities, as suggested by Eloy.
David Mudrak [Mon, 4 Jan 2010 17:44:52 +0000 (17:44 +0000)]
First drafts of assessment support
David Mudrak [Mon, 4 Jan 2010 17:44:30 +0000 (17:44 +0000)]
Renaming {load|save}_grading_form() methods
After I started work on assessment support, I realized that "grading
form" would not be consistent with "assessment form".
David Mudrak [Mon, 4 Jan 2010 17:44:07 +0000 (17:44 +0000)]
Renaming gradingform.php to edit_form.php
David Mudrak [Mon, 4 Jan 2010 17:43:31 +0000 (17:43 +0000)]
First drafts of the Number of errors grading strategy
David Mudrak [Mon, 4 Jan 2010 17:43:12 +0000 (17:43 +0000)]
Display the strategy name
David Mudrak [Mon, 4 Jan 2010 17:43:02 +0000 (17:43 +0000)]
Edit grading form refactoring
The previous desing was too "base-class oriented". I have realized that
strategies have to deal with loading and saving dimension definitions in
their own way. Getting rid of all db<->form field mappings as it would
work for very simple strategies only.
David Mudrak [Mon, 4 Jan 2010 17:42:49 +0000 (17:42 +0000)]
Added submission form strings
David Mudrak [Mon, 4 Jan 2010 17:42:37 +0000 (17:42 +0000)]
Some plays with submission, to do
David Mudrak [Mon, 4 Jan 2010 17:42:27 +0000 (17:42 +0000)]
Adding formal source code conventions
David Mudrak [Mon, 4 Jan 2010 17:42:17 +0000 (17:42 +0000)]
Explaining nattachments better
David Mudrak [Mon, 4 Jan 2010 17:38:29 +0000 (17:38 +0000)]
Initial draft of submission support
David Mudrak [Mon, 4 Jan 2010 17:37:53 +0000 (17:37 +0000)]
Some mform refactoring
Uses customdata instead of modified constructor.
David Mudrak [Mon, 4 Jan 2010 17:37:31 +0000 (17:37 +0000)]
Yay! Saving dimensions works
Cooking dimension editor's raw data is done by the strategy class.
David Mudrak [Mon, 4 Jan 2010 17:37:04 +0000 (17:37 +0000)]
Fixed the missing table in Error banded strategy and renaming it to Number of errors.
David Mudrak [Mon, 4 Jan 2010 17:36:43 +0000 (17:36 +0000)]
Use strategy-specific term for assessment dimension
David Mudrak [Mon, 4 Jan 2010 17:36:15 +0000 (17:36 +0000)]
Applying Eloy's suggestions
David Mudrak [Mon, 4 Jan 2010 17:35:56 +0000 (17:35 +0000)]
More work on the strategy API
David Mudrak [Mon, 4 Jan 2010 17:35:12 +0000 (17:35 +0000)]
Some files renamed to fit the coding style
David Mudrak [Mon, 4 Jan 2010 17:34:08 +0000 (17:34 +0000)]
MDL-17827 workshop: initial check in of the files
Exported from David's git repository
David Mudrak [Mon, 4 Jan 2010 17:12:35 +0000 (17:12 +0000)]
Adding locallib.php to store internal functions
Petr Skoda [Mon, 4 Jan 2010 14:40:34 +0000 (14:40 +0000)]
MDL-20204 improved pix docs
Petr Skoda [Mon, 4 Jan 2010 09:46:47 +0000 (09:46 +0000)]
MDL-21236 removing spurious popup action from normal action links, thanks sam