toyomoyo [Wed, 10 Oct 2007 06:43:23 +0000 (06:43 +0000)]
MDL-11667, adding 2 global variables to set default export decimal point and display format. During export there are 2 new settings for decimal points and display format, default to site setting. Removed letter option because it is a format that you can choose now.
moodler [Wed, 10 Oct 2007 02:52:25 +0000 (02:52 +0000)]
Added a timemodified field to forum_queue, and we now delete records
that are older than a week before processing digests.
After upgrade it's possible that some posts will be lost this way but
on the other hand it ensures that sites with problems like moodle.org
had will start working again.
We still need a recordset added to the digestposts loop.
There are multiple issues with Moodle files containing empty or blank lines
(lines consisting of white spaces or tabs only) and/or white space before or
after the PHP open and close tags, notably with config.php and theme files.
skodak [Tue, 9 Oct 2007 16:07:15 +0000 (16:07 +0000)]
MDL-11660
* user_lastaccess deleted when deleting course
* rewritten deleting of contexts - does not use get_context_instance() anymore because it is much more strict now
* added deleting of grade_letters and settings when deleting course
tjhunt [Tue, 9 Oct 2007 15:19:07 +0000 (15:19 +0000)]
MDL-11617 - 'Student may review' heading on quiz settings form is now misleading. I have fixed some lang strings and improved the help. Also, finish off the clarification of how various capabilites affect quiz review that was started in MDL-11580.
nicolasconnault [Tue, 9 Oct 2007 14:08:05 +0000 (14:08 +0000)]
MDL-11608 The $rename param was obtained with PARAM_NOTAG, I changed that to PARAM_RAW. I also changed the rename field's value to htmlspecialchars($category->name)
skodak [Tue, 9 Oct 2007 12:49:54 +0000 (12:49 +0000)]
MDL-11640
* improved handling of dirty contexts in general - caching, switching in cron, marking, loading, etc.
* role_assing() and role_unassign() now marks dirty contexts because we use has_capability() in this function - we can not do it later outside to speedup bulk operations
* fixed some inline docs
* fixed notice from rs closing
* removed cached $CONTEXT from has_capability() - $context is now required parameter; this was hiding serious bugs when context did not exist or ppl passed false as parameter
* removed some ===, we can not use these on function parameters - we must support ints, strings, '', nulls, etc. - this could be a source of really dangerous bugs in future
* some other improvements and fixes - documented inline
toyomoyo [Tue, 9 Oct 2007 05:43:35 +0000 (05:43 +0000)]
MDL-11665, users with no grade:viewhidden capability gets a wrong upgrade count because after deletion of a grade, the grade can be NULL and not hidden at the same time
skodak [Mon, 8 Oct 2007 23:09:10 +0000 (23:09 +0000)]
MDL-11578 , MDL-11578 , MDL-11573 :
* renamed Preferences to "My report preferences"
* renamed Site defaults to "Report defaults"
* rename Change site defaults to "Change report defaults"
* reintroduced Inherit option to Grader preferences - Nicolas was right, it is not possible to implement preference overrides without it with our current get_pref inplementation
* new separate option in plugin selector "Course settings"
* moved displaytype, decimals and aggregation position to "Course settings"
* created new table grade_settings + related functions grade_get/set_preference()
* user report now uses grade_seq class instead of grade_item::fetch_all(); added preloading of grade items into grade_grade instances
* other minor bugfixing/cleanup/improvements
Please note that the Grader report preferences and its defaults must be resaved again - sorry.
moodler [Mon, 8 Oct 2007 07:26:29 +0000 (07:26 +0000)]
Some fixes to make preferences work correctly (if not set then they are 0) and so now ranges and averages show correctly on grader report when these are set to defaults in preferences MDL-11618
skodak [Fri, 5 Oct 2007 15:06:38 +0000 (15:06 +0000)]
MDL-11521 fixed problems when creating contexts and aprents does not exist yet
MDL-11527 fixed warning from $CFG->defaultuserroleid when installing and upgrading
+ removed reusing of previous contexts in has_capability() and get_context_instance() because it was hiding critical errors when context was false, not specified, etc.
+ tweaked roles defaults - faster and defaults are applied when roles exist
+ SYSCONTEXTID may be specified in config.php to eliminate 1 db query
+ static context cache is now reset after rebuilding of context paths
+ path field in context table is now nullable - pg compatibility requirement
+ other minor fixes