From 0271a05d5a330f6888c47b34340b5db5659eca05 Mon Sep 17 00:00:00 2001 From: Petr Skoda Date: Tue, 12 Jan 2010 10:54:33 +0000 Subject: [PATCH] MDL-21318 more TODO info --- repository/remotemoodle/repository.class.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/repository/remotemoodle/repository.class.php b/repository/remotemoodle/repository.class.php index 061b285003..f80b42b26c 100644 --- a/repository/remotemoodle/repository.class.php +++ b/repository/remotemoodle/repository.class.php @@ -74,7 +74,8 @@ class repository_remotemoodle extends repository { ///check the the user is known ///he has to be previously connected to the server site in order to be in the database - //TODO: MDL-21318 this seems weird - is it executed from cron or what? Please review + //TODO: MDL-21318 this looks problematic, because global $USER would need to be set back after this, + // also is the user allowed to roam? $USER = $DB->get_record('user',array('username' => $username, 'mnethostid' => $MNET_REMOTE_CLIENT->id)); if (empty($USER)) { exit(mnet_server_fault(9016, get_string('usernotfound', 'repository_remotemoodle', $username))); @@ -116,7 +117,8 @@ class repository_remotemoodle extends repository { ///check the the user is known ///he has to be previously connected to the server site in order to be in the database - //TODO: MDL-21318 this seems weird - is it executed from cron or what? Please review + //TODO: MDL-21318 this looks problematic, because global $USER would need to be set back after this, + // also is the user allowed to roam? $USER = $DB->get_record('user',array('username' => $username, 'mnethostid' => $MNET_REMOTE_CLIENT->id)); if (empty($USER)) { exit(mnet_server_fault(9016, get_string('usernotfound', 'repository_remotemoodle', $username))); -- 2.39.5