From 04299b1f191e2cf57ec1d924c396320bb7fa30ae Mon Sep 17 00:00:00 2001 From: jamiesensei Date: Wed, 24 Sep 2008 10:45:05 +0000 Subject: [PATCH] MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" Ooops. We do need highlighting on the reponses report. The responses page does have a grade displayed that needs highlighting. I was looking at an ungraded quiz. Need highlighting to highlight grade of graded attempt. Reverted earlier patch and instead using a different colour for highlighting graded grade. Now using light yellow with a darker yellow border instead of green which is used in reports to highlight the correct answer. --- mod/quiz/report/reportlib.php | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/mod/quiz/report/reportlib.php b/mod/quiz/report/reportlib.php index 081b1dd475..ba77bd674d 100644 --- a/mod/quiz/report/reportlib.php +++ b/mod/quiz/report/reportlib.php @@ -287,7 +287,7 @@ function quiz_report_grade_bands($bandwidth, $bands, $quizid, $userids=array()){ unset($data[$bands]); return $data; } -function quiz_report_highlighting_grading_method($quiz, $qmsubselect, $qmfilter, $highlight=true){ +function quiz_report_highlighting_grading_method($quiz, $qmsubselect, $qmfilter){ if ($quiz->attempts == 1) {//only one attempt allowed on this quiz return "

".get_string('onlyoneattemptallowed', "quiz_overview")."

"; } else if (!$qmsubselect){ @@ -295,11 +295,8 @@ function quiz_report_highlighting_grading_method($quiz, $qmsubselect, $qmfilter, } else if ($qmfilter){ return "

".get_string('showinggraded', "quiz_overview")."

"; }else { - $a = quiz_get_grading_option_name($quiz->grademethod); - if ($highlight){ - $a = ''.$a.''; - } - return "

".get_string('showinggradedandungraded', "quiz_overview", $a)."

"; + return "

".get_string('showinggradedandungraded', "quiz_overview", + (''.quiz_get_grading_option_name($quiz->grademethod).''))."

"; } } -- 2.39.5