From 09575480bbe53e0b714b3d5da435700cb83281a9 Mon Sep 17 00:00:00 2001
From: skodak <skodak>
Date: Sun, 17 Sep 2006 18:07:35 +0000
Subject: [PATCH] fixed several warnings in get_course()

---
 course/index.php |  2 +-
 lib/datalib.php  | 40 ++++++++++++++++++++++++----------------
 2 files changed, 25 insertions(+), 17 deletions(-)

diff --git a/course/index.php b/course/index.php
index 6fbd3808bc..b83a4a1a47 100644
--- a/course/index.php
+++ b/course/index.php
@@ -265,7 +265,7 @@
     }
 
 /// Find any orphan courses that don't yet have a valid category and set to default
-    if ($courses = get_courses(NULL,NULL,'c.id, c.category, c.sortorder')) {
+    if ($courses = get_courses(NULL,NULL,'c.id, c.category, c.sortorder, c.visible')) {
         foreach ($courses as $course) {
             if ($course->category and !isset($categories[$course->category])) {
                 set_field("course", "category", $default, "id", $course->id);
diff --git a/lib/datalib.php b/lib/datalib.php
index 2b8cea1315..e5b8158682 100644
--- a/lib/datalib.php
+++ b/lib/datalib.php
@@ -483,30 +483,38 @@ function get_courses($categoryid="all", $sort="c.sortorder ASC", $fields="c.*")
 
     global $USER, $CFG;
     
-    $categoryselect = "";
     if ($categoryid != "all" && is_numeric($categoryid)) {
         $categoryselect = "WHERE c.category = '$categoryid'";
     } else {
         $categoryselect = "";  
-    }  
+    }
+
+    if (empty($sort)) {
+        $sortstatement = "";
+    } else {
+        $sortstatement = "ORDER BY $sort";
+    }
+
+    $visiblecourses = array();
     
     // pull out all course matching the cat
-    $courses = get_records_sql("SELECT $fields 
+    if ($courses = get_records_sql("SELECT $fields 
                                 FROM {$CFG->prefix}course c 
                                 $categoryselect
-                                ORDER BY $sort");
-    $visiblecourses = array();
-    
-    // loop throught them
-    foreach ($courses as $course) {
-        if ($course->visible <= 0) {
-            // for hidden courses, require visibility check
-            if (has_capability('moodle/course:viewhiddencourses', get_context_instance(CONTEXT_COURSE, $course->id))) {
+                                $sortstatement")) {
+
+        // loop throught them
+        foreach ($courses as $course) {
+
+            if ($course->visible <= 0) {
+                // for hidden courses, require visibility check
+                if (has_capability('moodle/course:viewhiddencourses', get_context_instance(CONTEXT_COURSE, $course->id))) {
+                    $visiblecourses [] = $course;  
+                }
+            } else {
                 $visiblecourses [] = $course;  
-            }
-        } else {
-            $visiblecourses [] = $course;  
-        } 
+            } 
+        }
     }
     return $visiblecourses;
 
@@ -1540,4 +1548,4 @@ function category_parent_visible($parent = 0) {
 }
 
 // vim:autoindent:expandtab:shiftwidth=4:tabstop=4:tw=140:
-?>
+?>
\ No newline at end of file
-- 
2.39.5