From 1ad5c6380f2e5e1045fd7e7ddf8eec8400e5d935 Mon Sep 17 00:00:00 2001 From: martinlanghoff Date: Tue, 26 Sep 2006 05:11:05 +0000 Subject: [PATCH] mod/quiz: remove deprecated sql_paging_limit(), use offset, limit parameters --- mod/quiz/report/grading/report.php | 8 +------- mod/quiz/report/overview/report.php | 10 ++-------- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/mod/quiz/report/grading/report.php b/mod/quiz/report/grading/report.php index 774cc9f9f3..184f2529ef 100644 --- a/mod/quiz/report/grading/report.php +++ b/mod/quiz/report/grading/report.php @@ -240,14 +240,8 @@ class quiz_report extends quiz_default_report { $total = count_records_sql('SELECT COUNT(DISTINCT('.sql_concat('u.id', '\'#\'', $db->IfNull('qa.attempt', '0')).')) '.$from.$where); $table->pagesize(10, $total); - // this is for getting the correct records for a given page - if($table->get_page_start() !== '' && $table->get_page_size() !== '') { - $limit = ' '.sql_paging_limit($table->get_page_start(), $table->get_page_size()); - } else { - $limit = ''; - } // get the attempts and process them - if ($attempts = get_records_sql($select.$from.$where.$sort.$limit)) { + if ($attempts = get_records_sql($select.$from.$where.$sort,$table->get_page_start(), $table->get_page_size())) { foreach($attempts as $attempt) { $picture = print_user_picture($attempt->userid, $quiz->course, $attempt->picture, false, true); diff --git a/mod/quiz/report/overview/report.php b/mod/quiz/report/overview/report.php index bc45b31fe8..c207d78a6c 100644 --- a/mod/quiz/report/overview/report.php +++ b/mod/quiz/report/overview/report.php @@ -94,7 +94,6 @@ class quiz_report extends quiz_default_report { if ($download) { $filename = clean_filename("$course->shortname ".format_string($quiz->name,true)); $sort = ''; - $limit = ''; } // Define table columns @@ -339,12 +338,6 @@ class quiz_report extends quiz_default_report { $pagesize = 10; } $table->pagesize($pagesize, $total); - - if($table->get_page_start() !== '' && $table->get_page_size() !== '') { - $limit = ' '.sql_paging_limit($table->get_page_start(), $table->get_page_size()); - } else { - $limit = ''; - } } // If there is feedback, include it in the query. @@ -357,7 +350,8 @@ class quiz_report extends quiz_default_report { // Fetch the attempts if (!empty($from)) { // if we're in the site course and displaying no attempts, it makes no sense to do the query. - $attempts = get_records_sql($select.$from.$where.$sort.$limit); + $attempts = get_records_sql($select.$from.$where.$sort, + $table->get_page_start(), $table->get_page_size()); } else { $attempts = array(); } -- 2.39.5