From 1cc2110b686ac0377aae02cb433c4401a96de122 Mon Sep 17 00:00:00 2001 From: poltawski Date: Wed, 30 Apr 2008 11:59:41 +0000 Subject: [PATCH] MDL-12614 - Bad regular expression matching was causing syntactically invalid js when returning to previously attempted SCORM package. Credit to Peter Chamberlin of ljcreate.com merged from MOODLE_19_STABLE --- mod/scorm/datamodels/scorm_13.js.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mod/scorm/datamodels/scorm_13.js.php b/mod/scorm/datamodels/scorm_13.js.php index fffd175ec4..dba2a5795f 100644 --- a/mod/scorm/datamodels/scorm_13.js.php +++ b/mod/scorm/datamodels/scorm_13.js.php @@ -210,9 +210,9 @@ function SCORMapi1_3() { $objectives = ''; foreach($userdata as $element => $value){ if (substr($element,0,14) == 'cmi.objectives') { - preg_match('/\.(\d+)\./',$element,$matches); - $element = preg_replace('/\.(\d+)\./',".N\$1.",$element); - if ($matches[1] == $count) { + $element = preg_replace('/\.(\d+)\./', "_\$1.", $element); + preg_match('/_(\d+)\./', $element, $matches); + if (isset($matches[1]) && $matches[1] == $count) { $count++; $end = strpos($element,$matches[1])+strlen($matches[1]); $subelement = substr($element,0,$end); -- 2.39.5