From 2338ad323963ef3bbe3c6213df87c6db210a399f Mon Sep 17 00:00:00 2001 From: martinlanghoff Date: Tue, 18 Jul 2006 04:39:01 +0000 Subject: [PATCH] Close Bug #5670 - get_courses_page() - remove costly and redundant DISTINCT get_courses_page() uses get_records_sql() which means that it will actually break if the first field requested isn't c.id. This in turn means that the DISTINCT is not needed at all. So let's go fast again! --- lib/datalib.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/datalib.php b/lib/datalib.php index 264e278ed2..15434e7e4d 100644 --- a/lib/datalib.php +++ b/lib/datalib.php @@ -2185,7 +2185,7 @@ function get_courses_page($categoryid="all", $sort="c.sortorder ASC", $fields="c $totalcount = count_records_sql("SELECT COUNT(DISTINCT c.id) FROM $selectsql"); - return get_records_sql("SELECT DISTINCT $fields FROM $selectsql ".((!empty($sort)) ? "ORDER BY $sort" : "")." $limit"); + return get_records_sql("SELECT $fields FROM $selectsql ".((!empty($sort)) ? "ORDER BY $sort" : "")." $limit"); } -- 2.39.5