From 26d7de8bfe0b0b7d633a0b182233a8e83e900a03 Mon Sep 17 00:00:00 2001 From: toyomoyo Date: Fri, 26 Oct 2007 02:30:04 +0000 Subject: [PATCH] merged fix for MDL-11902, gradebook formula dereferencing problem --- lib/grade/grade_item.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/grade/grade_item.php b/lib/grade/grade_item.php index 4140ad2191..f19414362a 100644 --- a/lib/grade/grade_item.php +++ b/lib/grade/grade_item.php @@ -1666,9 +1666,13 @@ class grade_item extends grade_object { } else { $useditems = array(); } - + + // MDL-11902 + // unset the value if formula is trying to reference to itself + // but array keys does not match itemid if (!empty($this->id)) { - unset($useditems[$this->id]); + $useditems = array_diff($useditems, array($this->id)); + //unset($useditems[$this->id]); } // prepare formula and init maths library -- 2.39.5