From 2b49ae96a6e4ef823c0fb3b58e15d7d774196b33 Mon Sep 17 00:00:00 2001
From: martinlanghoff <martinlanghoff>
Date: Thu, 18 Nov 2004 02:37:52 +0000
Subject: [PATCH] Merged from MOODLE_14_STABLE
 moodle--eduforge--1.3.3--patch-305 - Postgres SQL bugfix for
 instance_is_visible()

---
 lib/datalib.php | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/lib/datalib.php b/lib/datalib.php
index 6e2ef1e9d5..5d1cf8c861 100644
--- a/lib/datalib.php
+++ b/lib/datalib.php
@@ -2494,19 +2494,20 @@ function instance_is_visible($moduletype, $module) {
 
     global $CFG;
 
-    if ($records = get_records_sql("SELECT cm.instance, cm.visible
-                                    FROM {$CFG->prefix}course_modules cm,
-                                         {$CFG->prefix}modules m
-                                   WHERE cm.course = '$module->course' AND
-                                         cm.module = m.id AND
-                                         m.name = '$moduletype' AND
-                                         cm.instance = '$module->id'")) {
-
-        foreach ($records as $record) { // there should only be one - use the first one
-            return $record->visible;
+    if (!empty($module->id)) {
+        if ($records = get_records_sql("SELECT cm.instance, cm.visible
+                                        FROM {$CFG->prefix}course_modules cm,
+                                             {$CFG->prefix}modules m
+                                       WHERE cm.course = '$module->course' AND
+                                             cm.module = m.id AND
+                                             m.name = '$moduletype' AND
+                                             cm.instance = '$module->id'")) {
+    
+            foreach ($records as $record) { // there should only be one - use the first one
+                return $record->visible;
+            }
         }
     }
-
     return true;  // visible by default!
 }
 
-- 
2.39.5