From 2c3d57558785a24e88ffd0038ec400e589a58163 Mon Sep 17 00:00:00 2001 From: martinlanghoff Date: Tue, 4 Dec 2007 06:25:42 +0000 Subject: [PATCH] mod/assignment: Remove SQL "id,id" which causes errors on Oracle - MDL-12425 This loop also needs some rewriting - it is _very_ inefficient on large courses. --- mod/assignment/lib.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mod/assignment/lib.php b/mod/assignment/lib.php index 07d9d7fcdb..d29175d676 100644 --- a/mod/assignment/lib.php +++ b/mod/assignment/lib.php @@ -2750,8 +2750,8 @@ function assignment_print_overview($courses, &$htmlarray) { $submissions = 0; // init if ($students = get_users_by_capability($context, 'mod/assignment:submit', '', '', '', '', 0, '', false)) { foreach ($students as $student) { - if (get_records_sql("SELECT id,id FROM {$CFG->prefix}assignment_submissions - WHERE assignment = $assignment->id AND + if (record_exists_sql("SELECT id FROM {$CFG->prefix}assignment_submissions + WHERE assignment = $assignment->id AND userid = $student->id AND teacher = 0 AND timemarked = 0")) { -- 2.39.5