From 30d6173ed6eb3a646a8aa677de128492f65b6c08 Mon Sep 17 00:00:00 2001 From: moodler Date: Wed, 1 Jan 2003 07:37:19 +0000 Subject: [PATCH] Fixes for Log display --- course/lib.php | 8 +++++--- course/log.php | 22 +++++++++++++++++----- 2 files changed, 22 insertions(+), 8 deletions(-) diff --git a/course/lib.php b/course/lib.php index 529705a0b2..1ff0e9a1a2 100644 --- a/course/lib.php +++ b/course/lib.php @@ -17,11 +17,13 @@ function print_log_selector_form($course, $selecteduser=0, $selecteddate="today" $users = array(); if ($course->category) { - if (!$users = get_course_users($course->id, "u.lastaccess DESC")) { - $users = array(); + if ($courseusers = get_course_users($course->id, "u.lastaccess DESC")) { + foreach ($courseusers as $courseuser) { + $users[$courseuser->id] = "$courseuser->firstname $courseuser->lastname"; + } } if ($guest = get_guest()) { - $users["$guest->id"] = "$guest->firstname $guest->lastname"; + $users[$guest->id] = "$guest->firstname $guest->lastname"; } } diff --git a/course/log.php b/course/log.php index 29450a2c0f..7176f32453 100644 --- a/course/log.php +++ b/course/log.php @@ -26,6 +26,7 @@ } $strlogs = get_string("logs"); + $stradministration = get_string("administration"); if ($user || $date) { @@ -42,9 +43,15 @@ $dateinfo = userdate($date, "%A, %d %B %Y"); } - print_header("$course->shortname: $strlogs", "$course->fullname", - "id\">$course->shortname -> - id\">$strlogs -> $userinfo, $dateinfo", ""); + if ($course->category) { + print_header("$course->shortname: $strlogs", "$course->fullname", + "id\">$course->shortname -> + id\">$strlogs -> $userinfo, $dateinfo", ""); + } else { + print_header("$course->shortname: $strlogs", "$course->fullname", + "wwwroot/admin/\">$stradministration -> + id\">$strlogs -> $userinfo, $dateinfo", ""); + } print_heading("$course->fullname: $userinfo, $dateinfo (".usertimezone().")"); @@ -53,8 +60,13 @@ print_log($course, $user, $date, "ORDER BY l.time DESC"); } else { - print_header("$course->shortname: $strlogs", "$course->fullname", - "id\">$course->shortname -> $strlogs", ""); + if ($course->category) { + print_header("$course->shortname: $strlogs", "$course->fullname", + "id\">$course->shortname -> $strlogs", ""); + } else { + print_header("$course->shortname: $strlogs", "$course->fullname", + "wwwroot/admin/\">$stradministration -> $strlogs", ""); + } print_heading(get_string("chooselogs").":"); -- 2.39.5