From 324d65763c92ca2af060a8443e6993cfdc89d2c0 Mon Sep 17 00:00:00 2001
From: tjhunt <tjhunt>
Date: Thu, 26 Feb 2009 08:30:45 +0000
Subject: [PATCH] quiz editing: MDL-17284 Major coding style cleanup.

This is a mixture of stuff in the coding guildelines and personal preference.
---
 mod/quiz/edit.php | 439 +++++++++++++++++++++++-----------------------
 1 file changed, 217 insertions(+), 222 deletions(-)

diff --git a/mod/quiz/edit.php b/mod/quiz/edit.php
index 3ad1170c4e..3f177cdedc 100644
--- a/mod/quiz/edit.php
+++ b/mod/quiz/edit.php
@@ -47,62 +47,60 @@
  * @package quiz
  *//** */
 
-require_once("../../config.php");
-require_once($CFG->dirroot.'/mod/quiz/editlib.php');
-require_once($CFG->dirroot."/question/category_class.php");
-require_js(array('yui_yahoo','yui_dom-event','yui_container','yui_dragdrop'));
+require_once('../../config.php');
+require_once($CFG->dirroot . '/mod/quiz/editlib.php');
+require_once($CFG->dirroot . '/question/category_class.php');
+require_js(array('yui_yahoo', 'yui_dom-event', 'yui_container', 'yui_dragdrop'));
 
 /**
  * Callback function called from question_list() function
  * (which is called from showbank())
  * Displays button in form with checkboxes for each question.
  */
-function module_specific_buttons($cmid, $cmoptions){
-    if($cmoptions->hasattempts){
-        $disabled='disabled="disabled"';
-    }else{
-        $disabled='';
-    }
+function module_specific_buttons($cmid, $cmoptions) {
     global $THEME;
-    $straddtoquiz = get_string("addtoquiz", "quiz");
-    $out = "<input type=\"submit\" name=\"add\"
-            value=\"{$THEME->larrow} $straddtoquiz\" $disabled />\n";
+    if ($cmoptions->hasattempts) {
+        $disabled = 'disabled="disabled" ';
+    } else {
+        $disabled = '';
+    }
+    $straddtoquiz = get_string('addtoquiz', 'quiz');
+    $out = '<input type="submit" name="add" value="' . $THEME->larrow . ' ' . $straddtoquiz .
+            '" ' . $disabled . "/>\n";
     return $out;
 }
 
-
 /**
  * Callback function called from question_list() function
  * (which is called from showbank())
  */
-function module_specific_controls($totalnumber, $recurse, $category, $cmid, $cmoptions){
-    global $THEME,$QTYPES;
+function module_specific_controls($totalnumber, $recurse, $category, $cmid, $cmoptions) {
+    global $THEME, $QTYPES;
     $out = '';
     $catcontext = get_context_instance_by_id($category->contextid);
-    if (has_capability('moodle/question:useall', $catcontext)){
-        if($cmoptions->hasattempts){
-            $disabled='disabled="disabled"';
-        }else{
-            $disabled='';
+    if (has_capability('moodle/question:useall', $catcontext)) {
+        if ($cmoptions->hasattempts) {
+            $disabled = 'disabled="disabled"';
+        } else {
+            $disabled = '';
         }
         $randomusablequestions =
                 $QTYPES['random']->get_usable_questions_from_category($category->id, $recurse, '0');
         $maxrand = count($randomusablequestions);
         if ($maxrand > 0) {
-            for ($i = 1;$i <= min(10, $maxrand); $i++) {
+            for ($i = 1; $i <= min(10, $maxrand); $i++) {
                 $randomcount[$i] = $i;
             }
-            for ($i = 20;$i <= min(100, $maxrand); $i += 10) {
+            for ($i = 20; $i <= min(100, $maxrand); $i += 10) {
                 $randomcount[$i] = $i;
             }
-            $straddtoquiz = get_string("addtoquiz", "quiz");
-            $out = '<strong><label for="menurandomcount">'.get_string('addrandomfromcategory','quiz').
+            $straddtoquiz = get_string('addtoquiz', 'quiz');
+            $out = '<strong><label for="menurandomcount">'.get_string('addrandomfromcategory', 'quiz').
                     '</label></strong><br />';
             $out .= get_string('addrandom', 'quiz', choose_from_menu($randomcount,
-                    'randomcount', '1', '', '', '', true,$cmoptions->hasattempts));
+                    'randomcount', '1', '', '', '', true, $cmoptions->hasattempts));
             $out .= '<input type="hidden" name="recurse" value="'.$recurse.'" />';
-            $out .= "<input type=\"hidden\" name=\"categoryid\"
-                    value=\"$category->id\" />";
+            $out .= '<input type="hidden" name="categoryid" value="' . $category->id . '" />';
             $out .= ' <input type="submit" name="addrandom" value="'.
                     $straddtoquiz.'" '.$disabled.' />';
             $out .= helpbutton('random', get_string('random', 'quiz'), 'quiz',
@@ -116,22 +114,23 @@ list($thispageurl, $contexts, $cmid, $cm, $quiz, $pagevars) =
         question_edit_setup('editq', true);
 
 $defaultcategoryobj = question_make_default_categories($contexts->all());
-$defaultcategoryid=$defaultcategoryobj->id;
-$defaultcategorycontext=$defaultcategoryobj->contextid;
-$defaultcategory="$defaultcategoryid,$defaultcategorycontext";
+$defaultcategoryid = $defaultcategoryobj->id;
+$defaultcategorycontext = $defaultcategoryobj->contextid;
+$defaultcategory = $defaultcategoryid . ',' . $defaultcategorycontext;
+
 //these params are only passed from page request to request while we stay on
 //this page otherwise they would go in question_edit_setup
 $quiz_reordertool = optional_param('reordertool', 0, PARAM_BOOL);
 $quiz_qbanktool = optional_param('qbanktool', -1, PARAM_BOOL);
 if ($quiz_qbanktool > -1) {
     $thispageurl->param('qbanktool', $quiz_qbanktool);
-    set_user_preference("quiz_qbanktool_open",$quiz_qbanktool);
+    set_user_preference('quiz_qbanktool_open', $quiz_qbanktool);
 } else {
-    $quiz_qbanktool = get_user_preferences("quiz_qbanktool_open",0);
+    $quiz_qbanktool = get_user_preferences('quiz_qbanktool_open', 0);
 }
 
 //will be set further down in the code
-$quiz_has_attempts=false;
+$quiz_has_attempts = false;
 
 if ($quiz_reordertool != 0) {
     $thispageurl->param('reordertool', $quiz_reordertool);
@@ -139,18 +138,19 @@ if ($quiz_reordertool != 0) {
 
 $strquizzes = get_string('modulenameplural', 'quiz');
 $strquiz = get_string('modulename', 'quiz');
-$streditingquestions = get_string('editquestions', "quiz");
+$streditingquestions = get_string('editquestions', 'quiz');
 
 //this just does not work for at least finnish, where words are conjugated:
 //$streditingquiz = get_string('editinga', 'moodle', $strquiz);
 $streditingquiz = get_string('editingquiz', 'quiz');
 $strorderingquiz = get_string('orderingquiz', 'quiz');
-$pagetitle=$streditingquiz;
-if($quiz_reordertool){
-    $pagetitle=$strorderingquiz;
+$pagetitle = $streditingquiz;
+if ($quiz_reordertool) {
+    $pagetitle = $strorderingquiz;
 }
 // Get the course object and related bits.
-if (! $course = $DB->get_record('course', array('id' => $quiz->course))) {
+$course = $DB->get_record('course', array('id' => $quiz->course));
+if (!$course) {
     print_error('invalidcourseid', 'error');
 }
 
@@ -160,30 +160,29 @@ $questionbank = new quiz_question_bank_view($contexts, $thispageurl, $course, $c
 add_to_log($cm->course, 'quiz', 'editquestions',
             "view.php?id=$cm->id", "$quiz->id", $cm->id);
 
-//you need mod/quiz:manage in addition to question capabilities to access
-//this page.
+// You need mod/quiz:manage in addition to question capabilities to access this page.
 require_capability('mod/quiz:manage', $contexts->lowest());
 
-if (isset($quiz->instance) && empty($quiz->grades)){  // Construct an array to hold all the grades.
+if (isset($quiz->instance) && empty($quiz->grades)) {  // Construct an array to hold all the grades.
     $quiz->grades = quiz_get_all_question_grades($quiz);
 }
 
 // SECTION: PROCESS COMMANDS //
-/// Now, check for commands on this page and modify variables as necessary
-// If any edit action makes a sifnificant change to the structure of the quiz,
+// If any edit action makes a significant change to the structure of the quiz,
 // then we will need to delete all preview attempts.
 $significantchangemade = false;
-if (($up = optional_param('up', false, PARAM_INT)) !== false and
-        confirm_sesskey()) { /// Move the given question up a slot
-    $questions = explode(",", $quiz->questions);
-    if ($up > 0 and isset($questions[$up])) {
+
+if (($up = optional_param('up', false, PARAM_INT)) !== false && confirm_sesskey()) {
+/// Move the given question up a slot
+    $questions = explode(',', $quiz->questions);
+    if ($up > 0 && isset($questions[$up])) {
         //$prevkey = ($questions[$up-1] == 0) ? $up-2 : $up-1;
         $prevkey = $up-1;
         $swap = $questions[$prevkey];
         $questions[$prevkey] = $questions[$up];
-        $questions[$up]   = $swap;
-        $quiz->questions = implode(",", $questions);
-        $quiz->questions=quiz_clean_layout($quiz->questions);
+        $questions[$up] = $swap;
+        $quiz->questions = implode(',', $questions);
+        $quiz->questions = quiz_clean_layout($quiz->questions);
         if (!$DB->set_field('quiz', 'questions', $quiz->questions,
                 array('id' => $quiz->instance))) {
             print_error('cannotsavequestion', 'quiz');
@@ -192,18 +191,17 @@ if (($up = optional_param('up', false, PARAM_INT)) !== false and
     }
 }
 
-
-if (($down = optional_param('down', false, PARAM_INT)) !== false and
-        confirm_sesskey()) { /// Move the given question down a slot
-    $questions = explode(",", $quiz->questions);
+if (($down = optional_param('down', false, PARAM_INT)) !== false && confirm_sesskey()) {
+/// Move the given question down a slot
+    $questions = explode(',', $quiz->questions);
     if ($down < count($questions)) {
         //$nextkey = ($questions[$down+1] == 0) ? $down+2 : $down+1;
         $nextkey = $down+1;
         $swap = $questions[$nextkey];
         $questions[$nextkey] = $questions[$down];
-        $questions[$down]   = $swap;
-        $quiz->questions = implode(",", $questions);
-        $quiz->questions=quiz_clean_layout($quiz->questions);
+        $questions[$down] = $swap;
+        $quiz->questions = implode(',', $questions);
+        $quiz->questions = quiz_clean_layout($quiz->questions);
         if (!$DB->set_field('quiz', 'questions', $quiz->questions,
                 array('id' => $quiz->instance))) {
             print_error('cannotsavequestion', 'quiz');
@@ -211,15 +209,16 @@ if (($down = optional_param('down', false, PARAM_INT)) !== false and
         $significantchangemade = true;
     }
 }
-if (($addquestion = optional_param('addquestion', 0, PARAM_INT)) and
-        confirm_sesskey()) { /// Add a single question to the current quiz
-    $addonpage = optional_param('addonpage',0,PARAM_INT);
+
+if (($addquestion = optional_param('addquestion', 0, PARAM_INT)) && confirm_sesskey()) {
+/// Add a single question to the current quiz
+    $addonpage = optional_param('addonpage', 0, PARAM_INT);
     quiz_add_quiz_question($addquestion, $quiz, $addonpage);
     $significantchangemade = true;
 }
 
-if (optional_param('add', false, PARAM_BOOL) and
-        confirm_sesskey()) { /// Add selected questions to the current quiz
+if (optional_param('add', false, PARAM_BOOL) && confirm_sesskey()) {
+/// Add selected questions to the current quiz
     $rawdata = (array) data_submitted();
     foreach ($rawdata as $key => $value) {    // Parse input for question ids
         if (preg_match('!^q([0-9]+)$!', $key, $matches)) {
@@ -239,33 +238,34 @@ $qcobject = new question_category_object(
     null,
     $contexts->having_cap('moodle/question:add'));
 
-$newrandomcategory=false;
-$newquestioninfo=quiz_process_randomquestion_formdata($qcobject);
-if($newquestioninfo){
-    $newrandomcategory=$newquestioninfo->newrandomcategory;
-    if (!$newrandomcategory){
+$newrandomcategory = false;
+$newquestioninfo = quiz_process_randomquestion_formdata($qcobject);
+if ($newquestioninfo) {
+    $newrandomcategory = $newquestioninfo->newrandomcategory;
+    if (!$newrandomcategory) {
         print_r($newquestioninfo);
-        print_error("cannotcreatecategory");
-    }else{
+        print_error('cannotcreatecategory');
+    } else {
         add_to_log($quiz->course, 'quiz', 'addcategory',
-                "view.php?id=$cm->id", "$newrandomcategory", $cm->id);
+                "view.php?id=$cm->id", $newrandomcategory, $cm->id);
     }
 }
 
-if ((optional_param('addrandom', false, PARAM_BOOL) OR $newrandomcategory)
-        and confirm_sesskey()) {
+if ((optional_param('addrandom', false, PARAM_BOOL) || $newrandomcategory) && confirm_sesskey()) {
+
     /// Add random questions to the quiz
     $recurse = optional_param('recurse', 0, PARAM_BOOL);
-    $addonpage = optional_param('addonpage',0,PARAM_INT);
-    if($newrandomcategory){
+    $addonpage = optional_param('addonpage', 0, PARAM_INT);
+    if ($newrandomcategory) {
         $categoryid = $newrandomcategory;
-        $randomcount = optional_param('randomcount',1, PARAM_INT);
-    }else{
+        $randomcount = optional_param('randomcount', 1, PARAM_INT);
+    } else {
         $categoryid = required_param('categoryid', PARAM_INT);
         $randomcount = required_param('randomcount', PARAM_INT);
     }
     // load category
-    if (! $category = $DB->get_record('question_categories', array('id' => $categoryid))) {
+    $category = $DB->get_record('question_categories', array('id' => $categoryid));
+    if (!$category) {
         print_error('invalidcategoryid', 'error');
     }
     $catcontext = get_context_instance_by_id($category->contextid);
@@ -281,8 +281,7 @@ if ((optional_param('addrandom', false, PARAM_BOOL) OR $newrandomcategory)
                 AND NOT EXISTS (SELECT * FROM {quiz_question_instances} WHERE question = q.id)
             ORDER BY id", array($category->id, $recurse))) {
         // Take as many of these as needed.
-        while (($existingquestion = array_shift($existingquestions))
-                and $randomcount > 0) {
+        while (($existingquestion = array_shift($existingquestions)) && $randomcount > 0) {
             quiz_add_quiz_question($existingquestion->id, $quiz, $addonpage);
             $randomcount--;
         }
@@ -298,7 +297,7 @@ if ((optional_param('addrandom', false, PARAM_BOOL) OR $newrandomcategory)
         $form->defaultgrade = 1;
         $form->hidden = 1;
         for ($i = 0; $i < $randomcount; $i++) {
-            $form->category = "$category->id,$category->contextid";
+            $form->category = $category->id . ',' . $category->contextid;
             $form->stamp = make_unique_id_code(); // Set the unique
                     //code (not to be changed)
             $question = new stdClass;
@@ -314,46 +313,47 @@ if ((optional_param('addrandom', false, PARAM_BOOL) OR $newrandomcategory)
 
     $significantchangemade = true;
 }
-$addpagesafterquestions=array();
-if($addnewpagesafterselected=optional_param('addnewpagesafterselected',null)){
+
+$addpagesafterquestions = array();
+if ($addnewpagesafterselected = optional_param('addnewpagesafterselected', null)) {
     $rawgrades = (array) data_submitted();
     foreach ($rawgrades as $key => $value) {
         /// Parse input for question -> grades
-        if (preg_match('!^s([0-9]+)$!', $key, $matches)){
-            $addpagesafterquestions[]=$matches[1];
+        if (preg_match('!^s([0-9]+)$!', $key, $matches)) {
+            $addpagesafterquestions[] = $matches[1];
         }
     }
 }
 
-if ( (($addpage = optional_param('addpage', false, PARAM_INT)) OR
-        !empty($addpagesafterquestions))
-            and confirm_sesskey() ) { /// Move the given question up a slot
+$addpage = optional_param('addpage', false, PARAM_INT);
+if (($addpage || !empty($addpagesafterquestions)) && confirm_sesskey()) {
+/// Move the given question up a slot
 
-    $questions = explode(",", $quiz->questions);
+    $questions = explode(',', $quiz->questions);
 
-    $pagebreakid='0';
+    $pagebreakid = '0';
     if ($addpage > 0 && isset($questions[$addpage])) {
         array_splice($questions, $addpage, 0, $pagebreakid);
         $significantchangemade = true;
     }
-    foreach($addpagesafterquestions as $key => $questionid){
-        $addpage=array_search($questionid, $questions)+1;
+    foreach ($addpagesafterquestions as $key => $questionid) {
+        $addpage = array_search($questionid, $questions)+1;
         if ($addpage > 0 && isset($questions[$addpage])) {
-            $pagebreakid='0';
+            $pagebreakid = '0';
             array_splice($questions, $addpage, 0, $pagebreakid);
             $significantchangemade = true;
         }
     }
-    $quiz->questions = implode(",", $questions);
-    $quiz->questions=quiz_clean_layout($quiz->questions);
+    $quiz->questions = implode(',', $questions);
+    $quiz->questions = quiz_clean_layout($quiz->questions);
 
     if (!$DB->set_field('quiz', 'questions', $quiz->questions,
             array('id' => $quiz->instance))) {
         print_error('cannotsavequestion', 'quiz');
     }
-
 }
-if (optional_param('repaginate', false, PARAM_BOOL) and confirm_sesskey()) {
+
+if (optional_param('repaginate', false, PARAM_BOOL) && confirm_sesskey()) {
     // Re-paginate the quiz
     $questionsperpage = optional_param('questionsperpage',
             $quiz->questionsperpage, PARAM_INT);
@@ -365,21 +365,20 @@ if (optional_param('repaginate', false, PARAM_BOOL) and confirm_sesskey()) {
     $significantchangemade = true;
 }
 
-
-if ((($deleteemptypage = optional_param('deleteemptypage', false, PARAM_INT))
-        !==false) and confirm_sesskey()) {
-    $questions = explode(",", $quiz->questions);
-    if($deleteemptypage>0){
+$deleteemptypage = optional_param('deleteemptypage', false, PARAM_INT);
+if (($deleteemptypage !== false) && confirm_sesskey()) {
+    $questions = explode(',', $quiz->questions);
+    if ($deleteemptypage>0) {
         //it points to a value one too big due to the display logic
         $deleteemptypage--;
     }
-    if( ((int)$questions[$deleteemptypage]) == 0 ){
-        $questions = explode(",", $quiz->questions);
-        $endpart=array_slice($questions,$deleteemptypage+1,null,true);
-        $beginpart=array_slice($questions,0,$deleteemptypage,true);
-        $questions=array_merge($beginpart,$endpart);
-        $quiz->questions = implode(",", $questions);
-        $quiz->questions=quiz_clean_layout($quiz->questions);
+    if (((int)$questions[$deleteemptypage]) == 0) {
+        $questions = explode(',', $quiz->questions);
+        $endpart = array_slice($questions, $deleteemptypage + 1, null, true);
+        $beginpart = array_slice($questions, 0, $deleteemptypage, true);
+        $questions = array_merge($beginpart, $endpart);
+        $quiz->questions = implode(',', $questions);
+        $quiz->questions = quiz_clean_layout($quiz->questions);
     }
     if (!$DB->set_field('quiz', 'questions', $quiz->questions,
             array('id' => $quiz->instance))) {
@@ -387,55 +386,53 @@ if ((($deleteemptypage = optional_param('deleteemptypage', false, PARAM_INT))
     }
 }
 
-$deletequestions=array();
-if($quizdeleteselected=optional_param('quizdeleteselected',false)){
+$deletequestions = array();
+if ($quizdeleteselected = optional_param('quizdeleteselected', false)) {
     $rawgrades = (array) data_submitted();
     foreach ($rawgrades as $key => $value) {
         /// Parse input for question -> grades
-        if (preg_match('!^s([0-9]+)$!', $key, $matches)){
-            $deletequestions[]=$matches[1];
+        if (preg_match('!^s([0-9]+)$!', $key, $matches)) {
+            $deletequestions[] = $matches[1];
         }
     }
 }
 
-if ( (($delete = optional_param('delete', false, PARAM_INT)) !== false OR
-        !empty($deletequestions)) and confirm_sesskey() ) {
+$delete = optional_param('delete', false, PARAM_INT);
+if (($delete !== false || !empty($deletequestions)) && confirm_sesskey()) {
 
     //was:     if ($delete > 0 ) {
     if ($delete !==false) {
         quiz_delete_quiz_question($delete, $quiz);
         $significantchangemade = true;
     }
-    foreach($deletequestions as $key=>$questionid){
-        $questions = explode(",", $quiz->questions);
-        $delete=array_search($questionid, $questions);
+    foreach ($deletequestions as $key => $questionid) {
+        $questions = explode(',', $quiz->questions);
+        $delete = array_search($questionid, $questions);
         if ($delete !== false) {
             quiz_delete_quiz_question($delete, $quiz);
             $significantchangemade = true;
         }
     }
-    $quiz->questions=quiz_clean_layout($quiz->questions);
+    $quiz->questions = quiz_clean_layout($quiz->questions);
 
     if (!$DB->set_field('quiz', 'questions', $quiz->questions,
             array('id' => $quiz->instance))) {
         print_error('cannotsavequestion', 'quiz');
     }
-
 }
 
-if (optional_param('savechanges', false, PARAM_BOOL) and confirm_sesskey()) {
-    $oldquestions = explode(",", $quiz->questions); // the questions in the old order
+if (optional_param('savechanges', false, PARAM_BOOL) && confirm_sesskey()) {
+    $oldquestions = explode(',', $quiz->questions); // the questions in the old order
     $questions = array(); // for questions in the new order
     $rawgrades = (array) data_submitted();
     $moveonpagequestions = array();
-    $moveselectedonpage=0;
-    $moveselectedonpagetop=optional_param("moveselectedonpagetop",0,PARAM_INT);
-    $moveselectedonpagebottom=optional_param("moveselectedonpagebottom",0,
-            PARAM_INT);
-    if($moveselectedonpagetop){
-        $moveselectedonpage=$moveselectedonpagetop;
-    }else if($moveselectedonpagebottom){
-        $moveselectedonpage=$moveselectedonpagebottom;
+    $moveselectedonpage = 0;
+    $moveselectedonpagetop = optional_param('moveselectedonpagetop', 0, PARAM_INT);
+    $moveselectedonpagebottom = optional_param("moveselectedonpagebottom", 0, PARAM_INT);
+    if ($moveselectedonpagetop) {
+        $moveselectedonpage = $moveselectedonpagetop;
+    } else if($moveselectedonpagebottom) {
+        $moveselectedonpage = $moveselectedonpagebottom;
     }
 
     foreach ($rawgrades as $key => $value) {
@@ -445,7 +442,7 @@ if (optional_param('savechanges', false, PARAM_BOOL) and confirm_sesskey()) {
             $quiz->grades[$key] = $value;
             quiz_update_question_instance($quiz->grades[$key], $key, $quiz->instance);
 
-        } elseif (preg_match('!^o([0-9]+)$!', $key, $matches)) {
+        } else if (preg_match('!^o([0-9]+)$!', $key, $matches)) {
             /// Parse input for ordering info
             $key = $matches[1];
             // Make sure two questions don't overwrite each other.
@@ -457,60 +454,59 @@ if (optional_param('savechanges', false, PARAM_BOOL) and confirm_sesskey()) {
             }
             $questions[$value] = $oldquestions[$key];
 
-        } elseif (preg_match('!^s([0-9]+)$!', $key, $matches)){
+        } else if (preg_match('!^s([0-9]+)$!', $key, $matches)) {
             // Parse input for selected questions
             // (add new pages after questions in quiz)
             $key = $matches[1];
-            if($moveselectedonpage){
-                $moveonpagequestions[]=$key;
+            if ($moveselectedonpage) {
+                $moveonpagequestions[] = $key;
             }
         }
     }
     // If ordering info was given, reorder the questions
     if ($questions) {
         ksort($questions);
-        $quiz->questions = implode(",", $questions);
-        $quiz->questions .=",0";
-        $quiz->questions=quiz_clean_layout($quiz->questions);
+        $quiz->questions = implode(',', $questions) . ',0';
+        $quiz->questions = quiz_clean_layout($quiz->questions);
 
     }
     //get a list of questions to move, later to be added in the appropriate
     //place in the string
-    if($moveonpagequestions){
-        $questions = explode(",", $quiz->questions);
-        foreach($moveonpagequestions as $page=>$question){
+    if ($moveonpagequestions) {
+        $questions = explode(',', $quiz->questions);
+        foreach ($moveonpagequestions as $page => $question) {
             //remove the questions from their original positions first
-            while(($delpos=array_search($question,$questions))!==FALSE){
+            while (($delpos = array_search($question, $questions)) !== FALSE) {
                 //in case there are multiple instances because of an error, remove all
                 unset($questions[$delpos]);
             }
         }
         //reindex
-        foreach($questions as $question){
-            $newquestions[]=$question;
+        foreach ($questions as $question) {
+            $newquestions[] = $question;
         }
-        $questions=$newquestions;
-        
+        $questions = $newquestions;
+
         //find all pagebreaks
-        $pagecount=quiz_number_of_pages($quiz->questions);
-        if($moveselectedonpage>$pagecount){
+        $pagecount = quiz_number_of_pages($quiz->questions);
+        if ($moveselectedonpage > $pagecount) {
             // move to the last page is a page beyond last page was requested
-            $moveselectedonpage=$pagecount;
+            $moveselectedonpage = $pagecount;
         }
-        if($moveselectedonpage<1){
-            $moveselectedonpage=1;
+        if ($moveselectedonpage < 1) {
+            $moveselectedonpage = 1;
         }
-        $pagebreakpositions=array_keys($questions,0);
+        $pagebreakpositions = array_keys($questions, 0);
         //move to the end of the selected page
-        $moveselectedpos=$pagebreakpositions[$moveselectedonpage-1];
+        $moveselectedpos = $pagebreakpositions[$moveselectedonpage - 1];
         foreach ($moveonpagequestions as $question) {
             array_splice($questions, $moveselectedpos, 0, $question);
             //place the next one after this one:
             $moveselectedpos++;
         }
-        $quiz->questions = implode(",",$questions);
+        $quiz->questions = implode(',', $questions);
     }
-    if($moveonpagequestions or $questions){
+    if ($moveonpagequestions || $questions) {
         if (!$DB->set_field('quiz', 'questions', $quiz->questions,
                 array('id' => $quiz->instance))) {
             print_error('cannotsavequestion', 'quiz');
@@ -543,24 +539,24 @@ $questionbank->process_actions($thispageurl, $cm);
 
 /// all commands have been dealt with, now print the page
 
-if (isset($quiz->instance) and $DB->record_exists_select('quiz_attempts',
-        "quiz = ? AND preview = '0'", array($quiz->instance))){
+if (isset($quiz->instance) && $DB->record_exists_select('quiz_attempts',
+        'quiz = ? AND preview = 0', array($quiz->instance))) {
     $questionbank->set_quiz_has_attempts(true);
 }
 
 // Print the header.
-$questionbankmanagement='<a href="'.$CFG->wwwroot.
+$questionbankmanagement = '<a href="'.$CFG->wwwroot.
         '/question/edit.php?courseid='.$course->id.'">'.
-        get_string("questionbankmanagement","quiz").'</a> ';
+        get_string('questionbankmanagement', 'quiz').'</a> ';
 $strupdatemodule = has_capability('moodle/course:manageactivities',
         $contexts->lowest()) ?
         update_module_button($cm->id, $course->id,
         get_string('modulename', 'quiz')) :
         "";
 $navigation = build_navigation($pagetitle, $cm);
-$localcss= '<link rel="stylesheet" type="text/css" href="'.$CFG->wwwroot.
+$localcss = '<link rel="stylesheet" type="text/css" href="'.$CFG->wwwroot.
         '/lib/yui/container/assets/container.css" />';
-print_header_simple($pagetitle, '', $navigation, "", $localcss,true,
+print_header_simple($pagetitle, '', $navigation, "", $localcss, true,
         $questionbankmanagement.$strupdatemodule);
 //TODO: these skip links really need to be right after the opening of the body element,
 // and preferably implemented in an <ul> element. See MDL-17730.
@@ -578,29 +574,28 @@ print_js_config($quizeditconfig, 'quiz_edit_config');
 require_js('mod/quiz/edit.js');
 
 // Print the tabs.
+$currenttab = 'edit';
 $mode = 'editq';
-$currenttab="edit";
-if($quiz_reordertool){
-    $mode="reorder";
+if ($quiz_reordertool) {
+    $mode = 'reorder';
 }
 include('tabs.php');
 
-if($quiz_qbanktool){
-    $bankclass="";
-    $quizcontentsclass="";
-}else{
-    $bankclass="collapsed";
-    $quizcontentsclass="quizwhenbankcollapsed";
-}
-print_side_block_start(get_string('questionbankcontents','quiz').
-        ' <a href="'.
-$thispageurl->out(false,array('qbanktool'=>'1')).
-       '" id="showbankcmd">['.get_string("show").
+if ($quiz_qbanktool) {
+    $bankclass = '';
+    $quizcontentsclass = '';
+} else {
+    $bankclass = 'collapsed';
+    $quizcontentsclass = 'quizwhenbankcollapsed';
+}
+print_side_block_start(get_string('questionbankcontents', 'quiz') .
+        ' <a href="' . $thispageurl->out(false, array('qbanktool' => '1')) .
+       '" id="showbankcmd">[' . get_string('show').
        ']</a>
-       <a href="'.$thispageurl->out(false,array('qbanktool'=>'0')).
-       '" id="hidebankcmd">['.get_string("hide").
+       <a href="' . $thispageurl->out(false, array('qbanktool' => '0')) .
+       '" id="hidebankcmd">[' . get_string('hide').
        ']</a>
-       ', array("class"=>"questionbankwindow $bankclass"));
+       ', array('class' => 'questionbankwindow ' . $bankclass));
 
 echo '<span id="questionbank"></span>';
 echo '<div class="container">';
@@ -612,74 +607,74 @@ $questionbank->display('editq',
         $pagevars['qsortorderdecoded'],
         $pagevars['cat'], $pagevars['recurse'], $pagevars['showhidden'],
         $pagevars['showquestiontext']);
-echo '</div> <!-- end .bd -->';
-echo '</div> <!-- end .module -->';
-echo '</div> <!-- end .container -->';
+echo '</div>';
+echo '</div>';
+echo '</div>';
 print_side_block_end();
 
-if (!$quizname = $DB->get_field($cm->modname, 'name', array('id'=>$cm->instance))) {
+if (!$quizname = $DB->get_field($cm->modname, 'name', array('id' => $cm->instance))) {
     print_error('cannotmodulename');
 }
 
-echo '<div class="quizcontents '.$quizcontentsclass.'" id="quizcontentsblock">';
+echo '<div class="quizcontents ' . $quizcontentsclass . '" id="quizcontentsblock">';
 $questionsperpagebool = ($quiz->questionsperpage < 1) ? 0 : 1;
-if($questionsperpagebool){
-    $repaginatingdisabledhtml='disabled="disabled"';
-    $repaginatingdisabled=true;
-}else{
-    $repaginatingdisabledhtml='';
-    $repaginatingdisabled=false;
-}
-if($quiz_reordertool){
+if ($questionsperpagebool) {
+    $repaginatingdisabledhtml = 'disabled="disabled"';
+    $repaginatingdisabled = true;
+} else {
+    $repaginatingdisabledhtml = '';
+    $repaginatingdisabled = false;
+}
+if ($quiz_reordertool) {
     echo '<div class="repaginatecommand"><button id="repaginatecommand" '.$repaginatingdisabledhtml.'>'.
-            get_string("repaginatecommand","quiz").'...</button>';
+            get_string('repaginatecommand', 'quiz').'...</button>';
     echo '</div>';
 }
 print_heading($pagetitle.": ".$quizname, 'left', 2);
-helpbutton("editconcepts", get_string("basicideasofquiz","quiz"), "quiz",
-        true,get_string("basicideasofquiz","quiz"));
+helpbutton('editconcepts', get_string('basicideasofquiz', 'quiz'), 'quiz',
+        true, get_string('basicideasofquiz', 'quiz'));
 
-$notifystring="";
-if($quiz_has_attempts){
-    $string=get_string('cannoteditafterattempts', 'quiz');
-    $string.='<br /><a href="report.php?mode=overview&amp;id=' . $cm->id . '">' .
+$notifystring = '';
+if ($quiz_has_attempts) {
+    $string = get_string('cannoteditafterattempts', 'quiz');
+    $string .= '<br /><a href="report.php?mode=overview&amp;id=' . $cm->id . '">' .
         quiz_num_attempt_summary($quiz, $cm) . '</a><br />' ;
-    $notifystring.=notify($string,$style='notifyproblem', $align='center', $return=true);
+    $notifystring .= notify($string, 'notifyproblem', 'center', true);
 }
-if($questionsperpagebool && $quiz_reordertool){
-    $updateurl=new moodle_url("$CFG->wwwroot/course/mod.php",
-            array("return"=>"true","update"=>$quiz->cmid, "sesskey"=>sesskey()));
+if ($questionsperpagebool && $quiz_reordertool) {
+    $updateurl = new moodle_url("$CFG->wwwroot/course/mod.php",
+            array('return' => 'true', 'update' => $quiz->cmid, 'sesskey' => sesskey()));
     $linkstring = '<a href="'.$updateurl->out().'">';
-    $linkstring.=get_string('updatethis', '', get_string('modulename', 'quiz'));
-    $linkstring.='</a>';
-    $string=get_string('questionsperpageselected', 'quiz', $linkstring);
-    $notifystring.=notify($string,$style='notifyproblem', $align='center', $return=true);
-}
-if($quiz->shufflequestions && $quiz_reordertool){
-    $updateurl=new moodle_url("$CFG->wwwroot/course/mod.php",
-            array("return"=>"true","update"=>$quiz->cmid, "sesskey"=>sesskey()));
+    $linkstring .= get_string('updatethis', '', get_string('modulename', 'quiz'));
+    $linkstring .= '</a>';
+    $string = get_string('questionsperpageselected', 'quiz', $linkstring);
+    $notifystring .= notify($string, 'notifyproblem', 'center', true);
+}
+if ($quiz->shufflequestions && $quiz_reordertool) {
+    $updateurl = new moodle_url("$CFG->wwwroot/course/mod.php",
+            array('return' => 'true', 'update' => $quiz->cmid, 'sesskey' => sesskey()));
     $linkstring = '<a href="'.$updateurl->out().'">';
-    $linkstring.=get_string('updatethis', '', get_string('modulename', 'quiz'));
-    $linkstring.='</a>';
-    $string=get_string('shufflequestionsselected', 'quiz',$linkstring);
-    $notifystring.=notify($string,$style='notifyproblem', $align='center', $return=true);
+    $linkstring .= get_string('updatethis', '', get_string('modulename', 'quiz'));
+    $linkstring .= '</a>';
+    $string = get_string('shufflequestionsselected', 'quiz', $linkstring);
+    $notifystring .= notify($string, 'notifyproblem', 'center', true);
 }
-if(!empty($notifystring)){
+if (!empty($notifystring)) {
     //TODO: make the box closable so it is not in the way
     print_box_start();
     echo $notifystring;
     print_box_end();
 }
 
-if($quiz_reordertool){
+if ($quiz_reordertool) {
     $perpage= array();
     $perpage[0] = get_string('allinone', 'quiz');
-    for ($i=1; $i<=50; ++$i) {
+    for ($i = 1; $i <= 50; ++$i) {
         $perpage[$i] = $i;
     }
-    $gostring=get_string('go');
+    $gostring = get_string('go');
     echo '<div id="repaginatedialog"><div class="hd">';
-    echo get_string("repaginatecommand","quiz");
+    echo get_string('repaginatecommand', 'quiz');
     echo '</div><div class="bd">';
     echo '<form action="edit.php" method="post">';
     echo '<fieldset class="invisiblefieldset">';
@@ -690,14 +685,14 @@ if($quiz_reordertool){
     echo '<input type="hidden" name="repaginate" value="'.$gostring.'" />';
     print_string('repaginate', 'quiz',
             choose_from_menu($perpage, 'questionsperpage',
-            $quiz->questionsperpage, '', '', '', true,$repaginatingdisabled));
+            $quiz->questionsperpage, '', '', '', true, $repaginatingdisabled));
     echo '<div class="quizquestionlistcontrols">';
     echo ' <input type="submit" name="repaginate" value="'. $gostring .'" '.$repaginatingdisabledhtml.' />';
     echo '</div></fieldset></form></div></div>';
 }
-$tabindex=0;
+$tabindex = 0;
 
-if(!$quiz_reordertool){
+if (!$quiz_reordertool) {
     quiz_print_grading_form($quiz, $thispageurl, $tabindex);
 }
 quiz_print_status_bar($quiz);
@@ -711,7 +706,7 @@ quiz_print_status_bar($quiz);
 // Close <div class="quizcontents">:
 echo '</div>';
 
-if(!$quiz_reordertool){
+if (!$quiz_reordertool) {
     // display category adding UI
     ?>
 <div id="randomquestiondialog">
-- 
2.39.5