From 32e385857892415a301b1449ae22f9455170491e Mon Sep 17 00:00:00 2001
From: David Mudrak <david.mudrak@gmail.com>
Date: Mon, 4 Jan 2010 17:47:22 +0000
Subject: [PATCH] Fix: do not remove allocation if it should be kept
---
mod/workshop/allocation/random/allocator.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mod/workshop/allocation/random/allocator.php b/mod/workshop/allocation/random/allocator.php
index 7ceca1c9b8..4591f771b0 100644
--- a/mod/workshop/allocation/random/allocator.php
+++ b/mod/workshop/allocation/random/allocator.php
@@ -119,7 +119,7 @@ class workshop_random_allocator implements workshop_allocator {
// random allocator should not be able to delete assessments that have already been graded
// by reviewer
$o[] = 'info::' . get_string('numofdeallocatedassessment', 'workshop', count($delassessments));
- foreach ($delassessments as $delassessmentid) {
+ foreach ($delassessments as $delassessmentkey => $delassessmentid) {
$a = new stdClass();
$a->authorname = fullname((object)array(
'lastname' => $assessments[$delassessmentid]->authorlastname,
@@ -129,7 +129,7 @@ class workshop_random_allocator implements workshop_allocator {
'firstname' => $assessments[$delassessmentid]->reviewerfirstname));
if (!is_null($assessments[$delassessmentid]->grade)) {
$o[] = 'error::ident::' . get_string('allocationdeallocategraded', 'workshop', $a);
- unset($delassessments[$delassessmentid]);
+ unset($delassessments[$delassessmentkey]);
} else {
$o[] = 'info::ident::' . get_string('assessmentdeleteddetail', 'workshop', $a);
}
--
2.39.5