From 35bf63526aa2e3f1a36b66de044a1b0c2ede96f4 Mon Sep 17 00:00:00 2001 From: jamiesensei Date: Sun, 20 Jul 2008 14:40:22 +0000 Subject: [PATCH] MDL-15718 "overview report slow for large data sets - print_user_picture queries the db if only provided with a userid" --- mod/quiz/report/responses/report.php | 2 +- mod/quiz/report/responses/responses_table.php | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/mod/quiz/report/responses/report.php b/mod/quiz/report/responses/report.php index aed1073d9e..7237c4fdb5 100644 --- a/mod/quiz/report/responses/report.php +++ b/mod/quiz/report/responses/report.php @@ -187,7 +187,7 @@ class quiz_responses_report extends quiz_default_report { } $fields .='qa.uniqueid AS attemptuniqueid, qa.id AS attempt, u.id AS userid, u.idnumber, u.firstname,'. - ' u.lastname, u.institution, u.department, u.email, u.picture, '. + ' u.lastname, u.institution, u.department, u.email, u.picture, u.imagealt, '. 'qa.sumgrades, qa.timefinish, qa.timestart, qa.timefinish - qa.timestart AS duration '; // This part is the same for all cases - join users and quiz_attempts tables diff --git a/mod/quiz/report/responses/responses_table.php b/mod/quiz/report/responses/responses_table.php index 4a13c86c48..99a8967870 100644 --- a/mod/quiz/report/responses/responses_table.php +++ b/mod/quiz/report/responses/responses_table.php @@ -84,7 +84,13 @@ class quiz_report_responses_table extends table_sql { function col_picture($attempt){ global $COURSE; - return print_user_picture($attempt->userid, $COURSE->id, $attempt->picture, false, true); + $user = new object(); + $user->id = $attempt->userid; + $user->lastname = $attempt->lastname; + $user->firstname = $attempt->firstname; + $user->imagealt = $attempt->imagealt; + $user->picture = $attempt->picture; + return print_user_picture($user, $COURSE->id, $attempt->picture, false, true); } -- 2.39.5