From 375381a006b72e96588c46d5294b42896c896154 Mon Sep 17 00:00:00 2001
From: jamiesensei <jamiesensei>
Date: Sun, 20 Jul 2008 11:56:35 +0000
Subject: [PATCH] MDL-15718 "overview report slow for large data sets -
 print_user_picture queries the db if only provided with a userid"

---
 mod/quiz/report/overview/overview_table.php | 8 +++++++-
 mod/quiz/report/overview/report.php         | 3 ++-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/mod/quiz/report/overview/overview_table.php b/mod/quiz/report/overview/overview_table.php
index ce2e69ef43..dfa4486fef 100644
--- a/mod/quiz/report/overview/overview_table.php
+++ b/mod/quiz/report/overview/overview_table.php
@@ -116,7 +116,13 @@ class quiz_report_overview_table extends table_sql {
 
     function col_picture($attempt){
         global $COURSE;
-        return print_user_picture($attempt->userid, $COURSE->id, $attempt->picture, false, true);
+        $user = new object();
+        $user->id = $attempt->userid;
+        $user->lastname = $attempt->lastname;
+        $user->firstname = $attempt->firstname;
+        $user->imagealt = $attempt->imagealt;
+        $user->picture = $attempt->picture;
+        return print_user_picture($user, $COURSE->id, $attempt->picture, false, true);
     }
 
 
diff --git a/mod/quiz/report/overview/report.php b/mod/quiz/report/overview/report.php
index 59aa06687f..c436508de4 100644
--- a/mod/quiz/report/overview/report.php
+++ b/mod/quiz/report/overview/report.php
@@ -249,7 +249,8 @@ class quiz_overview_report extends quiz_default_report {
             // Construct the SQL
             $fields = $DB->sql_concat('u.id', '\'#\'', 'COALESCE(qa.attempt, \'0\')').' AS uniqueid, '.
                 ($qmsubselect?"($qmsubselect) AS gradedattempt, ":'').
-                'qa.uniqueid AS attemptuniqueid, qa.id AS attempt, u.id AS userid, u.idnumber, u.firstname, u.lastname, u.picture, '.
+                'qa.uniqueid AS attemptuniqueid, qa.id AS attempt, ' .
+                'u.id AS userid, u.idnumber, u.firstname, u.lastname, u.picture, u.imagealt, '.
                 'qa.sumgrades, qa.timefinish, qa.timestart, qa.timefinish - qa.timestart AS duration ';
 
             // This part is the same for all cases - join users and quiz_attempts tables
-- 
2.39.5