From 3b0ee367a79150aa367ec812a2184bd68fe32523 Mon Sep 17 00:00:00 2001 From: tjhunt Date: Wed, 26 Sep 2007 21:31:54 +0000 Subject: [PATCH] MDL-11466 - failing to check for the case $rs = false in the accesslib performance improvements. Credit for the fix goes to Gareth Morgan. --- lib/datalib.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/datalib.php b/lib/datalib.php index 22d15b6053..cdbfc931a0 100644 --- a/lib/datalib.php +++ b/lib/datalib.php @@ -1240,8 +1240,7 @@ function get_categories($parent='none', $sort=NULL, $shallow=true) { } $categories = array(); - $rs = get_recordset_sql($sql); - if ($rs->RecordCount()) { + if( $rs = get_recordset_sql($sql) ){ while ($cat = rs_fetch_next_record($rs)) { $cat = make_context_subobj($cat); if ($cat->visible || has_capability('moodle/course:create',$cat->context)) { -- 2.39.5