From 3d903fcbcc34c5e614414a3b78998b71b45b6cef Mon Sep 17 00:00:00 2001
From: thepurpleblob <thepurpleblob>
Date: Tue, 30 Jan 2007 15:16:47 +0000
Subject: [PATCH] MDL-8342
PHP5 migration thing causing string offset fatal
 error when data not present in XML file. Added some checks.

---
 question/format/blackboard/format.php | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/question/format/blackboard/format.php b/question/format/blackboard/format.php
index 12afb7403e..ac09fa21af 100644
--- a/question/format/blackboard/format.php
+++ b/question/format/blackboard/format.php
@@ -1,5 +1,6 @@
 
 <?php // $Id$
+
 ////////////////////////////////////////////////////////////////////////////
 /// Blackboard 6.0 Format
 ///
@@ -267,9 +268,9 @@ function process_fib($xml, &$questions) {
     else {
         return;
     }
+    
 
     for ($i = 0; $i < sizeof ($fibquestions); $i++) {
-
         $question = $this->defaultquestion();
 
         $question->qtype = SHORTANSWER;
@@ -292,11 +293,23 @@ function process_fib($xml, &$questions) {
 
         $question->answer[] = addslashes($answer);
         $question->fraction[] = 1;
-        $question->feedback[0] = addslashes(trim(@$thisquestion["#"]["GRADABLE"][0]["#"]["FEEDBACK_WHEN_CORRECT"][0]["#"]));
-        $question->feedback[1] = addslashes(trim(@$thisquestion["#"]["GRADABLE"][0]["#"]["FEEDBACK_WHEN_INCORRECT"][0]["#"]));
+        $question->feedback = array();
+
+        if (is_array( $thisquestion['#']['GRADABLE'][0]['#'] )) {
+            $question->feedback[0] = addslashes(trim($thisquestion["#"]["GRADABLE"][0]["#"]["FEEDBACK_WHEN_CORRECT"][0]["#"]));
+        }
+        else {
+            $question->feedback[0] = '';
+        }      
+        if (is_array( $thisquestion["#"]["GRADABLE"][0]["#"] )) {
+            $question->feedback[1] = addslashes(trim($thisquestion["#"]["GRADABLE"][0]["#"]["FEEDBACK_WHEN_INCORRECT"][0]["#"]));
+        }
+        else {
+            $question->feedback[1] = '';
+        }        
          
         $questions[] = $question;
-      }
+      } 
 }
 
 //----------------------------------------
-- 
2.39.5