From 3dc579ad6dbd9b65da5f9321e7a7ce1453200409 Mon Sep 17 00:00:00 2001
From: skodak <skodak>
Date: Mon, 20 Nov 2006 10:19:55 +0000
Subject: [PATCH] removed JS submission from stats code MDL-7492

---
 admin/report/stats/index.php  |  2 +-
 course/report/stats/index.php |  2 +-
 course/report/stats/lib.php   | 11 ++---------
 3 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/admin/report/stats/index.php b/admin/report/stats/index.php
index 602fab8ace..a526314be5 100644
--- a/admin/report/stats/index.php
+++ b/admin/report/stats/index.php
@@ -59,7 +59,7 @@
 //    $strreports = get_string("reports");
 //    $strstats = get_string('stats');
 //
-//    $menu = report_stats_mode_menu($course, $mode, $time);
+//    $menu = report_stats_mode_menu($course, $mode, $time); // add 4th $url parameter if uncommented!
 //
 //
 //    $crumb = "<a href=\"{$CFG->wwwroot}/admin\">".get_string('administration')."</a> ->
diff --git a/course/report/stats/index.php b/course/report/stats/index.php
index 3d819a18b2..ddf11eb5e2 100644
--- a/course/report/stats/index.php
+++ b/course/report/stats/index.php
@@ -52,7 +52,7 @@
     $strreports = get_string("reports");
     $strstats = get_string('stats');
 
-    $menu = report_stats_mode_menu($course, $mode, $time);
+    $menu = report_stats_mode_menu($course, $mode, $time, "$CFG->wwwroot/course/report/stats/index.php");
 
     $crumb = "<a href=\"../../view.php?id=$course->id\">$course->shortname</a> ->
               <a href=\"../../report.php?id=$course->id\">$strreports</a> ->
diff --git a/course/report/stats/lib.php b/course/report/stats/lib.php
index f22a7432dc..f281d210f1 100644
--- a/course/report/stats/lib.php
+++ b/course/report/stats/lib.php
@@ -8,7 +8,7 @@
     require_once($CFG->dirroot.'/lib/statslib.php');
 
 
-    function report_stats_mode_menu($course, $mode, $time) {
+    function report_stats_mode_menu($course, $mode, $time, $url) {
         global $CFG;
         /*        
         $reportoptions = stats_get_report_options($course->id, $mode);
@@ -24,15 +24,8 @@
         if (has_capability('moodle/site:viewreports', get_context_instance(CONTEXT_SYSTEM, SITEID))) {
             $options[STATS_MODE_RANKED] = get_string('reports');
         }
-
-        $menu = choose_from_menu($options,'mode',$mode,'','this.form.submit();',0,true);
-
-        $menu = '<form action="index.php" method="post">'."\n"
-            .'<input type="hidden" name="course" value="'.$course->id.'" />'."\n"
-            .'<input type="hidden" name="time" value="'.$time.'" />'."\n"
-            .$menu."\n".'</form>';
         
-        return $menu;
+        return popup_form($url."?course=$course->id&amp;time=$time&amp;mode=", $options, 'switchmode', $mode, '', '', '', true);
     }
 
 
-- 
2.39.5