From 4354a3e563345b4ca9dbe5d3288f4bf5f99707ec Mon Sep 17 00:00:00 2001 From: moodler Date: Mon, 8 Oct 2007 07:26:29 +0000 Subject: [PATCH] Some fixes to make preferences work correctly (if not set then they are 0) and so now ranges and averages show correctly on grader report when these are set to defaults in preferences MDL-11618 --- grade/report/grader/lib.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/grade/report/grader/lib.php b/grade/report/grader/lib.php index 20f24cae0a..d1d7a06286 100644 --- a/grade/report/grader/lib.php +++ b/grade/report/grader/lib.php @@ -908,7 +908,8 @@ class grade_report_grader extends grade_report { $displaytype = GRADE_DISPLAY_TYPE_REAL; } else if ($averagesdisplaytype == GRADE_REPORT_PREFERENCE_DEFAULT - or $averagesdisplaytype == GRADE_REPORT_PREFERENCE_INHERIT) { + || $averagesdisplaytype == GRADE_REPORT_PREFERENCE_INHERIT + || $averagesdisplaytype == 0) { $displaytype = $item->get_displaytype(); } else { @@ -917,7 +918,7 @@ class grade_report_grader extends grade_report { // Override grade_item setting if a display preference (not inherit) was set for the averages if ($averagesdecimalpoints == GRADE_REPORT_PREFERENCE_DEFAULT - or $averagesdecimalpoints == GRADE_REPORT_PREFERENCE_INHERIT) { + || $averagesdecimalpoints == GRADE_REPORT_PREFERENCE_INHERIT) { $decimalpoints = $item->get_decimals(); } else { @@ -967,7 +968,8 @@ class grade_report_grader extends grade_report { $displaytype = GRADE_DISPLAY_TYPE_REAL; } else if ($rangesdisplaytype == GRADE_REPORT_PREFERENCE_DEFAULT - or $rangesdisplaytype == GRADE_REPORT_PREFERENCE_INHERIT) { + || $rangesdisplaytype == GRADE_REPORT_PREFERENCE_INHERIT + || $rangesdisplaytype == 0 ) { $displaytype = $item->get_displaytype(); } else { -- 2.39.5