From 44eb3b6e9eb0c5174dadb07afeddf5afaa743b26 Mon Sep 17 00:00:00 2001 From: jamiesensei Date: Thu, 8 May 2008 09:53:31 +0000 Subject: [PATCH] For the overview report : MDL-14199 "Option to only show / export final grade" small improvement to UI. Include highlighted message in the form about what the current grading method is. Merged from 1.9 branch. --- lang/en_utf8/quiz_overview.php | 2 +- mod/quiz/report/overview/overviewsettings_form.php | 3 ++- mod/quiz/report/overview/report.php | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lang/en_utf8/quiz_overview.php b/lang/en_utf8/quiz_overview.php index 1bb41d4156..3b3c496624 100644 --- a/lang/en_utf8/quiz_overview.php +++ b/lang/en_utf8/quiz_overview.php @@ -15,7 +15,7 @@ $string['optallattempts'] = 'all attempts'; $string['optallstudents'] = 'all \'$a\''; $string['optattemptsonly'] = '\'$a\' with attempts only'; $string['optnoattemptsonly'] = '\'$a\' with no attempts only'; -$string['optonlygradedattempts'] = 'only the attempt that is graded for each user'; +$string['optonlygradedattempts'] = 'only the attempt that is graded for each user ($a)'; $string['overview'] = 'Overview'; $string['overviewdownload'] = 'Overview download'; $string['overviewdownload'] = 'Overview download'; diff --git a/mod/quiz/report/overview/overviewsettings_form.php b/mod/quiz/report/overview/overviewsettings_form.php index cf9c765321..9adffff28a 100644 --- a/mod/quiz/report/overview/overviewsettings_form.php +++ b/mod/quiz/report/overview/overviewsettings_form.php @@ -18,7 +18,8 @@ class mod_quiz_report_overview_settings extends moodleform { } $mform->addElement('select', 'attemptsmode', get_string('show', 'quiz_overview'), $options); if ($this->_customdata['qmsubselect']){ - $mform->addElement('advcheckbox', 'qmfilter', get_string('show', 'quiz_overview'), get_string('optonlygradedattempts', 'quiz_overview'), null, array(0,1)); + $gm = ''.quiz_get_grading_option_name($this->_customdata['quiz']->grademethod).''; + $mform->addElement('advcheckbox', 'qmfilter', get_string('show', 'quiz_overview'), get_string('optonlygradedattempts', 'quiz_overview', $gm), null, array(0,1)); } //------------------------------------------------------------------------------- $mform->addElement('header', 'general', get_string('preferencesuser', 'quiz_overview')); diff --git a/mod/quiz/report/overview/report.php b/mod/quiz/report/overview/report.php index 8b22adf37b..3ff3e3f83e 100644 --- a/mod/quiz/report/overview/report.php +++ b/mod/quiz/report/overview/report.php @@ -66,7 +66,7 @@ class quiz_report extends quiz_default_report { $reporturl = new moodle_url($CFG->wwwroot.'/mod/quiz/report.php', $pageoptions); $qmsubselect = quiz_report_qm_filter_subselect($quiz); - $mform = new mod_quiz_report_overview_settings($reporturl, compact('qmsubselect')); + $mform = new mod_quiz_report_overview_settings($reporturl, compact('qmsubselect', 'quiz')); if ($fromform = $mform->get_data()){ $attemptsmode = $fromform->attemptsmode; if ($qmsubselect){ -- 2.39.5