From 46c6731707edbbdfa465fb2974a441614cbfdadc Mon Sep 17 00:00:00 2001 From: mudrd8mz Date: Fri, 28 Aug 2009 11:34:01 +0000 Subject: [PATCH] NOBUG: fixed incorect use of $output variable I propose to use $output variable name for renderer instance only. Also, this did not work at all as $output was not returned. --- lib/outputrenderers.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/outputrenderers.php b/lib/outputrenderers.php index a34ef08f18..1d788c47a5 100644 --- a/lib/outputrenderers.php +++ b/lib/outputrenderers.php @@ -1845,10 +1845,11 @@ class moodle_core_renderer extends moodle_renderer_base { $field = clone($field); $field->prepare(); $this->prepare_event_handlers($field); + $returned = ''; if (!empty($field->label->text)) { - $output .= $this->label($field->label); + $returned .= $this->label($field->label); } - return $this->output_empty_tag('input', array( + $returned .= $this->output_empty_tag('input', array( 'type' => $field->type, 'name' => $field->name, 'id' => $field->id, @@ -1857,6 +1858,7 @@ class moodle_core_renderer extends moodle_renderer_base { 'alt' => $field->alt, 'title' => $field->title, 'maxlength' => $field->maxlength)); + return $returned; } /** -- 2.39.5